bcd41810f4
Reader-facing prose and rustdoc carried opaque shorthand like
"Decision 10", "clause-5", "mq.1", "ct.1", "eob.1", "rpe.1",
"post-mq.3", and "Iter 22b.1:" with no in-repo definition the reader
could follow. This commit replaces every such occurrence in the
durable tier the reader is most likely to land on (design/ ledger +
source //! module headers + the central /// public-item rustdoc) with
an inline content phrase plus, where applicable, a Markdown link to
the file that defines the referenced concept.
design/ ledger — 16 files:
Definition-site headings demoted from "Decision N: <title>" to
"<title>": authoring-surface, tail-calls, memory-model section in
rc-uniqueness.md, dual-allocator section, typeclass design,
effects "pure core + algebraic effects".
Cross-reference sites: "Decision 1" -> canonical-schema principle
(data-model); "Decision 3/4" -> effects + scope-boundaries; "Decision
6" -> authoring-surface; "Decision 8" -> tail-calls; "Decision 9" ->
rc-uniqueness (dual-allocator); "Decision 10" -> memory-model;
"Decision 11" -> typeclasses (model). "clause-5" -> body-link
durability gate. "clause-3" (in language-constraints) ->
bug-class-reintroduction discriminator. "mq.1/2/3", "ct.1/4",
"eob.1", "rpe.1" -> the canonical-form rule / the type-driven
dispatch / the Str carve-out / etc. "post-mq.3" -> "type-driven".
design/contracts/feature-acceptance.md: file-local "clauses 1/2/3"
-> "criteria 1/2/3" (sprachliche Kohärenz mit der File-Überschrift
"Feature-acceptance criterion"); "the clause-3 mechanism" -> "the
bug-class-reintroduction discriminator".
Source //! module headers — 24 files:
Stripped "Iter X.Y:" prefixes and "(Decision N)" / "(mq.X)" tags
from spec_drift, uniqueness, reuse_shape, migrate_canonical_types,
typeclass_22b{2,3,c}, suppress_filter, lift, mono, linearity,
diagnostic, method_dispatch_pin, method_collision_pin,
no_per_type_print_ops, mq3_multi_class_e2e, print_mono_body_shape,
print_no_leak_pin, cli_diag_human_workspace_load_error,
ct1_check_cli, prose snapshot, unbound_in_instance_method_pin,
mono_xmod_ctor_pattern, desugar.
Central /// public-item rustdoc:
ast.rs (full sweep — every "Iter X" + "Decision N" prefix
reformulated; mode/Type::Fn rustdoc now points at memory-model.md;
Constraint / SuperclassRef / InstanceDef / ClassDef rustdoc points
at typeclasses contract).
diagnostic.rs (all "(Iter X)" / "(mq.X)" tags on diagnostic codes
removed).
lib.rs (FORM_A_SPEC rustdoc points at authoring-surface.md
instead of "Decision 6").
canonical.rs (type_hash + Float-literal rustdoc).
Still outstanding (for a follow-up commit): ~500 inline `//`
code-body comments with `Iter X.Y` markers across the workspace, and
a handful of `///` rustdoc items in hash_pin / workspace_pin / lift /
mono / suppress_filter test-pin and internal-function bodies. Code
identifiers (test filenames like `mq3_multi_class_e2e.rs`, function
names like `iter18e_drop_iterative_default_preserves_hashes`) stay
verbatim per the user's "code identifiers stay verbatim" rule.
Tests: design_index_pin 5/5 + docs_honesty_pin 5/5; workspace builds
clean; full `cargo test --workspace` previously green (every
`test result: ok` line, no FAILED line).
155 lines
5.1 KiB
Rust
155 lines
5.1 KiB
Rust
//! Pin tests on `resolve_method_dispatch` — the
|
|
//! dispatch-resolution helper that synth's `Term::Var` arm consults
|
|
//! per the spec's 5-step rule.
|
|
//!
|
|
//! Six cases:
|
|
//! 1. Unique candidate.
|
|
//! 2. Multi + explicit qualifier matching one.
|
|
//! 3. Multi + explicit qualifier matching none → UnknownClass.
|
|
//! 4. Multi + type-driven filter narrows to one.
|
|
//! 5. Multi + constraint-driven filter narrows to one (rigid var case).
|
|
//! 6. Multi + true ambiguity → AmbiguousMethodResolution.
|
|
|
|
use ailang_check::{resolve_method_dispatch, MethodDispatchOutcome};
|
|
use ailang_core::ast::{Constraint, Type};
|
|
use ailang_core::canonical;
|
|
use std::collections::{BTreeMap, BTreeSet};
|
|
|
|
fn registry_with(entries: &[(&str, &str)]) -> BTreeMap<(String, String), ()> {
|
|
// Returns a synthetic registry: keys are (qualified_class, type_hash)
|
|
// values are unit (instance presence flag).
|
|
let mut reg = BTreeMap::new();
|
|
for (cls, ty_name) in entries {
|
|
let t = Type::Con { name: ty_name.to_string(), args: vec![] };
|
|
let h = canonical::type_hash(&t);
|
|
reg.insert((cls.to_string(), h), ());
|
|
}
|
|
reg
|
|
}
|
|
|
|
fn candidates_of(classes: &[&str]) -> BTreeSet<String> {
|
|
classes.iter().map(|s| s.to_string()).collect()
|
|
}
|
|
|
|
/// Case 1: unique candidate → returns that class.
|
|
#[test]
|
|
fn case1_unique_candidate_resolves() {
|
|
let candidates = candidates_of(&["prelude.Eq"]);
|
|
let registry = registry_with(&[("prelude.Eq", "Int")]);
|
|
let arg_ty = Type::Con { name: "Int".to_string(), args: vec![] };
|
|
let result = resolve_method_dispatch(
|
|
/*method*/ "eq",
|
|
/*qualifier_prefix*/ None,
|
|
/*candidates*/ &candidates,
|
|
/*concrete_arg_type*/ Some(&arg_ty),
|
|
/*declared_constraints*/ &[],
|
|
/*registry*/ ®istry,
|
|
);
|
|
assert_eq!(result, MethodDispatchOutcome::Resolved("prelude.Eq".to_string()));
|
|
}
|
|
|
|
/// Case 2: multi + explicit qualifier matching one → returns that class.
|
|
#[test]
|
|
fn case2_qualifier_matches_one() {
|
|
let candidates = candidates_of(&["prelude.Show", "userlib.Show"]);
|
|
let registry = registry_with(&[
|
|
("prelude.Show", "Int"),
|
|
("userlib.Show", "Int"),
|
|
]);
|
|
let arg_ty = Type::Con { name: "Int".to_string(), args: vec![] };
|
|
let result = resolve_method_dispatch(
|
|
"show",
|
|
Some("userlib.Show"),
|
|
&candidates,
|
|
Some(&arg_ty),
|
|
&[],
|
|
®istry,
|
|
);
|
|
assert_eq!(result, MethodDispatchOutcome::Resolved("userlib.Show".to_string()));
|
|
}
|
|
|
|
/// Case 3: multi + explicit qualifier matching none → UnknownClass.
|
|
#[test]
|
|
fn case3_qualifier_matches_none_unknown_class() {
|
|
let candidates = candidates_of(&["prelude.Show", "userlib.Show"]);
|
|
let registry = registry_with(&[("prelude.Show", "Int")]);
|
|
let arg_ty = Type::Con { name: "Int".to_string(), args: vec![] };
|
|
let result = resolve_method_dispatch(
|
|
"show",
|
|
Some("nonexistent.Show"),
|
|
&candidates,
|
|
Some(&arg_ty),
|
|
&[],
|
|
®istry,
|
|
);
|
|
assert_eq!(
|
|
result,
|
|
MethodDispatchOutcome::UnknownClass("nonexistent.Show".to_string()),
|
|
);
|
|
}
|
|
|
|
/// Case 4: multi + type-driven filter narrows to one → returns that class.
|
|
#[test]
|
|
fn case4_type_driven_filter_narrows_to_one() {
|
|
let candidates = candidates_of(&["prelude.Show", "userlib.Show"]);
|
|
let registry = registry_with(&[("prelude.Show", "Int")]); // only prelude.Show has Show Int
|
|
let arg_ty = Type::Con { name: "Int".to_string(), args: vec![] };
|
|
let result = resolve_method_dispatch(
|
|
"show",
|
|
None,
|
|
&candidates,
|
|
Some(&arg_ty),
|
|
&[],
|
|
®istry,
|
|
);
|
|
assert_eq!(result, MethodDispatchOutcome::Resolved("prelude.Show".to_string()));
|
|
}
|
|
|
|
/// Case 5: multi + constraint-driven filter narrows to one (rigid var) → returns that class.
|
|
#[test]
|
|
fn case5_constraint_driven_filter_narrows_to_one() {
|
|
let candidates = candidates_of(&["prelude.Show", "userlib.Show"]);
|
|
let registry = registry_with(&[]);
|
|
let rigid_a = Type::Var { name: "a".to_string() };
|
|
let declared = vec![Constraint {
|
|
class: "prelude.Show".to_string(),
|
|
type_: Type::Var { name: "a".to_string() },
|
|
}];
|
|
let result = resolve_method_dispatch(
|
|
"show",
|
|
None,
|
|
&candidates,
|
|
Some(&rigid_a), // rigid var, can't drive registry lookup
|
|
&declared,
|
|
®istry,
|
|
);
|
|
assert_eq!(result, MethodDispatchOutcome::Resolved("prelude.Show".to_string()));
|
|
}
|
|
|
|
/// Case 6: multi + true ambiguity → AmbiguousMethodResolution.
|
|
#[test]
|
|
fn case6_true_ambiguity() {
|
|
let candidates = candidates_of(&["prelude.Show", "userlib.Show"]);
|
|
let registry = registry_with(&[
|
|
("prelude.Show", "Int"),
|
|
("userlib.Show", "Int"),
|
|
]);
|
|
let arg_ty = Type::Con { name: "Int".to_string(), args: vec![] };
|
|
let result = resolve_method_dispatch(
|
|
"show",
|
|
None,
|
|
&candidates,
|
|
Some(&arg_ty),
|
|
&[],
|
|
®istry,
|
|
);
|
|
assert_eq!(
|
|
result,
|
|
MethodDispatchOutcome::Ambiguous {
|
|
method: "show".to_string(),
|
|
at_type: "Int".to_string(),
|
|
candidates: vec!["prelude.Show".to_string(), "userlib.Show".to_string()],
|
|
},
|
|
);
|
|
}
|