26fb3459d8
The runtime print path now writes exactly the bytes of its
argument with no implicit trailing newline. `io/print_str` is
byte-faithful; authors who want a newline emit `(do io/print_str
"\n")` themselves.
## Codegen
`crates/ailang-codegen/src/lib.rs`:
- Module preamble: `@puts(ptr)` → `@fputs(ptr, ptr)` plus
`@stdout = external global ptr` (libc's `FILE *stdout`).
- Effect-op lowering for `io/print_str`: emit
`getelementptr +8` then `load ptr, ptr @stdout` then
`call/tail call i32 @fputs(ptr bytes, ptr fp)`. Identical
bytes-pointer GEP, distinct sink.
- The pinned IR-shape test renames from
`print_str_calls_puts_with_bytes_pointer` to
`print_str_calls_fputs_with_bytes_pointer_and_stdout` and now
asserts: bytes-GEP present, stdout-load present, both module-
preamble declarations present, and no `@puts(` call anywhere
in the emitted IR.
## Why this shape, and not the alternatives
- *Rename `io/print_str` to `io/println_str` (issue #29 option 2)*
— kept the auto-newline, just relabelled it. AILang's design
bias is explicit-over-implicit (CLAUDE.md: implicit conversions
cut). Auto-newline is a hidden runtime augmentation; the rename
would have preserved it. Rejected.
- *Append `\n` inside the polymorphic `print` (Show-mediated)
function in `examples/prelude.ail`* — would have been a one-line
fix. Rejected: `print` is the Show-mediated formatter, not a
newline emitter; baking a newline into it would have re-imposed
the same implicit-augmentation problem one layer up, breaking
callers that legitimately want pure-bytes output.
## Fixture / test sweep
30 `.ail` fixtures whose owning tests asserted line-separated
stdout now emit explicit `(do io/print_str "\n")` after each
print. Tests that asserted on multi-line stdout (`show_print_e2e`,
`floats_e2e`, `str_concat_e2e`, `eq_ord_e2e`, several `print_*`
smoke tests) had their fixtures sweetened the same way; assertions
themselves remain the canonical observable output. Fixtures that
never relied on the newline (no test ever read the absence of one)
were left untouched.
## Migrated metadata
- `crates/ailang-core/tests/hash_pin.rs`: the `ordering_match::main`
canonical hash is refreshed (`b65a7f834703ffb4` →
`8ed47b4062ce00f5`). The comment now names both successive
corpus migrations honestly: the per-type-print-retirement (which
moved `(do io/print_int x)` to `(app print x)`) AND this
fputs swap (which wrapped that with `(seq ... (do io/print_str
"\n"))`).
- `design/contracts/str-abi.md`: the consumer-ABI table now lists
`@fputs` as the print sink. A prose paragraph documents the
byte-faithful semantics and references this issue.
- `examples/ordering_match.prose.txt`: regenerated from the
updated `ordering_match.ail`.
- `crates/ail/tests/snapshots/{hello,sum,max3,list,ws_main}.ll`:
IR snapshots regenerated via `UPDATE_SNAPSHOTS=1`.
- Stale `@puts` comments in `runtime/str.c`,
`crates/ail/tests/{e2e,show_print_e2e,print_no_leak_pin}.rs`
replaced with `@fputs`.
## Verification
- `cargo test -p ail --test print_str_no_auto_newline_e2e` — both
RED tests from commit c8ecfa3 now pass.
- `cargo test --workspace` — 90 test groups GREEN, 0 failures.
- `cargo build --workspace` — GREEN.
- No new clippy lints (24 warnings pre-existing in
`crates/ailang-core/src/lib.rs:129`).
- Stats: `bench/orchestrator-stats/2026-05-21-iter-bugfix-print-
str-fputs.json` — 1/1 tasks, 0 re-loops, 0 review loops.
## Empirical evidence cited
Caught in the 2026-05-21 Qwen3-Coder naming-A/B run
(`experiments/2026-05-21-naming-ab/runs/r1/`): every cohort wrote
`(do io/print_str "...\n")` with explicit `\n` and got doubled
newlines, failing the `t3_main_prints` stdout match across all
three cohorts. The empirical LLM-natural form already assumes the
new (post-this-commit) semantics — confirming the
feature-acceptance test in CLAUDE.md.
closes #29
111 lines
4.9 KiB
Rust
111 lines
4.9 KiB
Rust
//! End-to-end tests for the `print` polymorphic helper shipped in
|
|
//! milestone 24.3.
|
|
//!
|
|
//! Each test compiles a `.ail.json` workspace via the `ail build`
|
|
//! subcommand, runs the resulting native binary, and asserts on stdout.
|
|
//!
|
|
//! Properties protected:
|
|
//! - `print_primitives_smoke_runs_end_to_end`: `print` at four primitive
|
|
//! types (Int / Bool / Str / Float) emits the expected textual
|
|
//! representation of each value via the prelude Show instances +
|
|
//! `io/print_str`. The four `print__T` mono symbols synthesise from
|
|
//! the prelude `instance prelude.Show T` bodies and route through the
|
|
//! corresponding `<T>_to_str` runtime primitive.
|
|
//! - `print_user_adt_runs_end_to_end`: `print` composes with a
|
|
//! user-declared `instance prelude.Show IntBox` to emit a user-ADT's
|
|
//! structural representation. Confirms that the post-mono synthesised
|
|
//! `print__<UserType>` body's nested `show x` call rewrites to the
|
|
//! user instance's `show__<UserType>` mono symbol and that the
|
|
//! cross-module reference from `prelude.print__<UserType>` to
|
|
//! `<user_module>.show__<UserType>` lowers cleanly through codegen.
|
|
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
|
|
fn fixture_path(name: &str) -> PathBuf {
|
|
PathBuf::from(env!("CARGO_MANIFEST_DIR"))
|
|
.join("../../examples")
|
|
.join(name)
|
|
}
|
|
|
|
fn build_and_run(fixture: &str) -> String {
|
|
let src = fixture_path(fixture);
|
|
let out = std::env::temp_dir().join(format!("ail_{}.bin", fixture.replace('.', "_")));
|
|
|
|
let build = Command::new(env!("CARGO_BIN_EXE_ail"))
|
|
.args(["build", src.to_str().unwrap(), "-o", out.to_str().unwrap()])
|
|
.output()
|
|
.expect("ail build");
|
|
assert!(
|
|
build.status.success(),
|
|
"ail build failed for {fixture}:\nstdout: {}\nstderr: {}",
|
|
String::from_utf8_lossy(&build.stdout),
|
|
String::from_utf8_lossy(&build.stderr),
|
|
);
|
|
|
|
let run = Command::new(&out).output().expect("run binary");
|
|
assert!(
|
|
run.status.success(),
|
|
"binary exited non-zero:\nstdout: {}\nstderr: {}",
|
|
String::from_utf8_lossy(&run.stdout),
|
|
String::from_utf8_lossy(&run.stderr),
|
|
);
|
|
String::from_utf8_lossy(&run.stdout).trim().to_string()
|
|
}
|
|
|
|
#[test]
|
|
fn print_primitives_smoke_runs_end_to_end() {
|
|
let stdout = build_and_run("show_print_smoke.ail");
|
|
// Post Gitea #29 (io/print_str → @fputs), the print path no
|
|
// longer appends an implicit newline. The fixture now emits
|
|
// each value with an explicit `(do io/print_str "\n")` after
|
|
// the print, so the raw stdout is "42\ntrue\nhello\n3.14\n"
|
|
// and `.trim()` lands at "42\ntrue\nhello\n3.14".
|
|
// print 42 → "42" (int_to_str), then explicit "\n"
|
|
// print true → "true" (bool_to_str), then explicit "\n"
|
|
// print "hello" → "hello" (str_clone), then explicit "\n"
|
|
// print 3.14 → "3.14" (float_to_str / libc %g)
|
|
assert_eq!(stdout, "42\ntrue\nhello\n3.14", "got: {stdout:?}");
|
|
}
|
|
|
|
#[test]
|
|
fn print_user_adt_runs_end_to_end() {
|
|
let stdout = build_and_run("show_user_adt.ail");
|
|
// print (MkIntBox 7) → "7\n" (via user instance prelude.Show
|
|
// IntBox that unwraps via match + int_to_str).
|
|
assert_eq!(stdout, "7", "got: {stdout:?}");
|
|
}
|
|
|
|
/// RED pin (rpe-bug-1, 2026-05-14): `(app print <arg>)` where `<arg>`
|
|
/// contains a class-method call (here `eq 1 2 : Bool`) must lower
|
|
/// cleanly. The iter 24.3 rewire taught `synth` to push a `Show T`
|
|
/// residual for `print`'s declared constraint at the same `Var` site
|
|
/// where the poly-free-fn observation is pushed (see
|
|
/// `crates/ailang-check/src/lib.rs` lines 2908-2960). But the
|
|
/// mono-rewrite walker in `crates/ailang-check/src/mono.rs`
|
|
/// (`interleave_slots` and `rewrite_mono_calls`) treats every
|
|
/// poly-free-fn `Var` as consuming exactly one free-fn slot — it does
|
|
/// not advance the class-residual cursor for the constraint that was
|
|
/// pushed at the same site. The consequence is a one-position
|
|
/// misalignment: the *next* class-method call in the body consumes
|
|
/// the `Show T` slot, rewriting `eq` → `show__Bool`. Codegen then
|
|
/// reports `call prelude.show__Bool arg type mismatch: expected i1,
|
|
/// got i64`.
|
|
///
|
|
/// Property protected: a `print` call whose argument contains a
|
|
/// class-method invocation lowers to a valid IR call sequence — the
|
|
/// `eq` (or other class-method) call is rewritten to its correct
|
|
/// mono symbol, not to a stale `Show T` residual symbol.
|
|
///
|
|
/// Fixture `examples/print_eq_arg_repro.ail` exercises the shape
|
|
/// `(app print (app eq 1 2))`. Expected stdout: `"false"` (Show Bool
|
|
/// of `eq 1 2` → false). This test is GREEN once the cursor
|
|
/// alignment in `interleave_slots` / `rewrite_mono_calls` is fixed
|
|
/// to advance the class cursor for constraints carried by a
|
|
/// poly-free-fn Var.
|
|
#[test]
|
|
fn print_with_class_method_arg_does_not_misalign_mono_cursor() {
|
|
let stdout = build_and_run("print_eq_arg_repro.ail");
|
|
assert_eq!(stdout, "false", "got: {stdout:?}");
|
|
}
|