Brummel
77b28ad64d
First half of the form-a-default-authoring milestone-close iter (Boss-decided strategy C, big-bang). All five tasks DONE; cargo test --workspace green at every per-task boundary. T1 — Add three new tests: - parse_is_deterministic_over_every_ail_fixture (round_trip.rs) - cli_parse_then_render_then_parse_is_idempotent (roundtrip_cli.rs) - carve_out_inventory.rs (new file; #[ignore]'d until T8 deletion) T2 — Bulk-render the 99 missing examples/<stem>.ail files via `ail render`. Corpus 58 .ail (pre-iter) -> 157 .ail. Eight .ail.json carve-outs (7 §C4(a) subject-matter + 1 §C4(b) prelude) preserved. One re-loop triggered: load_workspace prefers .ail siblings since ext-cli.1, so the newly-rendered imports broke seven Group-A entries whose JSON entry-paths now resolved imports to fresh .ail. Repair: pre-emptive forward-pull of five T3 migrations + 4 transient #[ignore]s on workspace.rs mod tests (cleanly relocated in T5). T3 — 14 Group-A test files migrated from ailang_core::load_workspace to ailang_surface::load_workspace + .ail paths. Carve-out lines preserved verbatim (7 sites in typeclass_22b2.rs / typeclass_22b3.rs). T4 — 12 Group-B test files: bulk regex flip on build_and_run / build_and_run_with_alloc / build_and_run_with_rc_stats call sites (~70 e2e.rs invocations + 11 subprocess sites). Four files mis-classified Group-A as Group-B in plan recon (mono_hash_stability, prelude_free_fns, print_mono_body_shape, show_mono_synthesis); two files mis-classified Group-B as Group-A (mono_recursive_fn, mono_xmod_qualified_ref). Migrated per actual shape, not plan label. T5 — Relocated #[cfg(test)] mod tests from production source to integration test crates with ailang-surface dev-dependency: - crates/ailang-core/tests/hash_pin.rs (10 tests from hash.rs) - crates/ailang-core/tests/workspace_pin.rs (10 non-carve-out tests from workspace.rs) - crates/ailang-codegen/tests/eq_primitives_pin.rs (3 tests from codegen/src/lib.rs:3717-3799) - ailang-prose/tests/snapshot.rs migrated (helper + 8 fixtures) to .ail + ailang_surface::load_module Carve-out tests in workspace.rs mod tests preserved in-place (3× 22b2 + 3× ct1 = 6 tests). Tempdir-based loader-mechanism tests (3 sites) also preserved — they don't consume examples/. Tests: 560 passed, 0 failed, 4 ignored (was 558 + 3 T1 new - 1 transit carve_out_inventory #[ignore] = 560 active). Tasks 6-12 (bench-driver suffix flips, e2e diff-test rewrite + 4 additional raw-JSON-inspect handlers, .ail.json deletion, retiring obsolete roundtrip tests + schema_coverage corpus flip, §C3 DESIGN.md restatement, §A4 doctrine edits, WhatsNew + roadmap strike) ship in the next dispatch on this iter ID. Known debt inherited to T6-12: 4 raw-JSON-inspect tests in e2e.rs (borrow_own_demo / reuse_as_demo / render_parse_round_trip_canonical / ail_run_accepts_ail_source_with_same_stdout_as_ail_json dual-form smoke) need rewrite or #[ignore] before T8 deletion; recorded in journal Concerns + Known debt sections.
74 lines
2.9 KiB
Rust
74 lines
2.9 KiB
Rust
//! Bug regression: the workspace-monomorphisation pass must seed
|
|
//! `env.globals` for the current module before re-running `synth` on
|
|
//! a fn body, otherwise self-recursive top-level fns are rejected with
|
|
//! `unknown identifier` whenever the workspace also contains a
|
|
//! `Def::Class` (which makes the mono pass actually traverse bodies
|
|
//! instead of identity-cloning the workspace).
|
|
//!
|
|
//! Surfaced by the 2026-05-10 mono-vs-vdisp micro-benchmark: the
|
|
//! original bench fixture had a self-recursive `loop` fn alongside a
|
|
//! `Foo` class, and `ail build` failed at the mono pass with
|
|
//! `monomorphise_workspace: unknown identifier: \`loop\``. The bench
|
|
//! worked around it by also wrapping the loop in a class method,
|
|
//! masking but not fixing the defect.
|
|
|
|
use std::path::Path;
|
|
use std::process::Command;
|
|
|
|
fn ail_bin() -> &'static str {
|
|
env!("CARGO_BIN_EXE_ail")
|
|
}
|
|
|
|
/// Property: a workspace that mixes a `Def::Class` / `Def::Instance`
|
|
/// with a self-recursive top-level `Def::Fn` (one whose body refers
|
|
/// to its own name) must build and run end-to-end. The mono pass
|
|
/// re-runs `synth` on every fn body to recover residual class
|
|
/// constraints; that env must agree with the env the main typecheck
|
|
/// path used, including `env.globals` for the current module.
|
|
///
|
|
/// Pre-fix: `ail build` fails at the mono pass with
|
|
/// `monomorphise_workspace: unknown identifier: \`loop\`` because
|
|
/// `mono::build_workspace_env` populates `env.module_globals` but
|
|
/// never seeds `env.globals` from the current module's fns —
|
|
/// `synth`'s `Term::Var` lookup at `lib.rs:1678` falls through to
|
|
/// the qualified-cross-module branch and finally to `UnknownIdent`.
|
|
/// The analogous gap for ADTs / ctors was fixed in commit 5c5180f
|
|
/// (iter 22c); this is the sibling gap for plain top-level fns.
|
|
#[test]
|
|
fn mono_pass_handles_recursive_fn_in_class_workspace() {
|
|
let manifest_dir = env!("CARGO_MANIFEST_DIR");
|
|
let workspace = Path::new(manifest_dir).parent().unwrap().parent().unwrap();
|
|
let src = workspace
|
|
.join("examples")
|
|
.join("test_mono_recursive_fn_bug.ail");
|
|
let tmp = std::env::temp_dir().join(format!(
|
|
"ailang_mono_recursive_fn_{}",
|
|
std::process::id()
|
|
));
|
|
std::fs::create_dir_all(&tmp).unwrap();
|
|
let out = tmp.join("bin");
|
|
|
|
let build = Command::new(ail_bin())
|
|
.args(["build", src.to_str().unwrap(), "-o"])
|
|
.arg(&out)
|
|
.output()
|
|
.expect("ail build failed to run");
|
|
assert!(
|
|
build.status.success(),
|
|
"ail build failed: stderr={}",
|
|
String::from_utf8_lossy(&build.stderr)
|
|
);
|
|
|
|
let run = Command::new(&out).output().expect("execute binary");
|
|
assert!(
|
|
run.status.success(),
|
|
"binary {} exited non-zero",
|
|
out.display()
|
|
);
|
|
// loop(0, 5) = 0 + 5 + 4 + 3 + 2 + 1 = 15
|
|
assert_eq!(
|
|
String::from_utf8(run.stdout).expect("stdout utf8").trim(),
|
|
"15"
|
|
);
|
|
}
|