Brummel
77b28ad64d
First half of the form-a-default-authoring milestone-close iter (Boss-decided strategy C, big-bang). All five tasks DONE; cargo test --workspace green at every per-task boundary. T1 — Add three new tests: - parse_is_deterministic_over_every_ail_fixture (round_trip.rs) - cli_parse_then_render_then_parse_is_idempotent (roundtrip_cli.rs) - carve_out_inventory.rs (new file; #[ignore]'d until T8 deletion) T2 — Bulk-render the 99 missing examples/<stem>.ail files via `ail render`. Corpus 58 .ail (pre-iter) -> 157 .ail. Eight .ail.json carve-outs (7 §C4(a) subject-matter + 1 §C4(b) prelude) preserved. One re-loop triggered: load_workspace prefers .ail siblings since ext-cli.1, so the newly-rendered imports broke seven Group-A entries whose JSON entry-paths now resolved imports to fresh .ail. Repair: pre-emptive forward-pull of five T3 migrations + 4 transient #[ignore]s on workspace.rs mod tests (cleanly relocated in T5). T3 — 14 Group-A test files migrated from ailang_core::load_workspace to ailang_surface::load_workspace + .ail paths. Carve-out lines preserved verbatim (7 sites in typeclass_22b2.rs / typeclass_22b3.rs). T4 — 12 Group-B test files: bulk regex flip on build_and_run / build_and_run_with_alloc / build_and_run_with_rc_stats call sites (~70 e2e.rs invocations + 11 subprocess sites). Four files mis-classified Group-A as Group-B in plan recon (mono_hash_stability, prelude_free_fns, print_mono_body_shape, show_mono_synthesis); two files mis-classified Group-B as Group-A (mono_recursive_fn, mono_xmod_qualified_ref). Migrated per actual shape, not plan label. T5 — Relocated #[cfg(test)] mod tests from production source to integration test crates with ailang-surface dev-dependency: - crates/ailang-core/tests/hash_pin.rs (10 tests from hash.rs) - crates/ailang-core/tests/workspace_pin.rs (10 non-carve-out tests from workspace.rs) - crates/ailang-codegen/tests/eq_primitives_pin.rs (3 tests from codegen/src/lib.rs:3717-3799) - ailang-prose/tests/snapshot.rs migrated (helper + 8 fixtures) to .ail + ailang_surface::load_module Carve-out tests in workspace.rs mod tests preserved in-place (3× 22b2 + 3× ct1 = 6 tests). Tempdir-based loader-mechanism tests (3 sites) also preserved — they don't consume examples/. Tests: 560 passed, 0 failed, 4 ignored (was 558 + 3 T1 new - 1 transit carve_out_inventory #[ignore] = 560 active). Tasks 6-12 (bench-driver suffix flips, e2e diff-test rewrite + 4 additional raw-JSON-inspect handlers, .ail.json deletion, retiring obsolete roundtrip tests + schema_coverage corpus flip, §C3 DESIGN.md restatement, §A4 doctrine edits, WhatsNew + roadmap strike) ship in the next dispatch on this iter ID. Known debt inherited to T6-12: 4 raw-JSON-inspect tests in e2e.rs (borrow_own_demo / reuse_as_demo / render_parse_round_trip_canonical / ail_run_accepts_ail_source_with_same_stdout_as_ail_json dual-form smoke) need rewrite or #[ignore] before T8 deletion; recorded in journal Concerns + Known debt sections.
76 lines
3.2 KiB
Rust
76 lines
3.2 KiB
Rust
//! mq.3.5: repurposed pin tests for the post-`MethodNameCollision`-
|
|
//! retirement workspace-load path. The two on-disk fixtures that fired
|
|
//! `WorkspaceLoadError::MethodNameCollision` pre-mq.3 now load cleanly;
|
|
//! the assertion migrates from "expect collision diagnostic" to "load
|
|
//! successful + `Env.method_to_candidate_classes` carries the
|
|
//! expected multi-entry set" (class-class case) or "load successful +
|
|
//! class-fn coexistence is legal" (class-fn case).
|
|
//!
|
|
//! The relocation from `crates/ailang-core/src/workspace.rs` to this
|
|
//! file is required because the post-retirement assertions read
|
|
//! `Env.method_to_candidate_classes`, which is built by `ailang-check`
|
|
//! (`build_check_env`) and not visible from `ailang-core`.
|
|
|
|
use ailang_check::build_check_env;
|
|
use ailang_surface::load_workspace;
|
|
use std::path::Path;
|
|
|
|
fn examples_dir() -> std::path::PathBuf {
|
|
let manifest = env!("CARGO_MANIFEST_DIR");
|
|
Path::new(manifest)
|
|
.parent().expect("CARGO_MANIFEST_DIR has a parent (crates/ailang-check)")
|
|
.parent().expect("CARGO_MANIFEST_DIR has a grandparent (crates/)")
|
|
.join("examples")
|
|
}
|
|
|
|
/// mq.3.5 (class-class repurpose): the fixture
|
|
/// `examples/test_22b2_method_name_collision_class_class.ail.json`
|
|
/// declares two classes `A` and `B` in the same module, each declaring
|
|
/// the method `foo`. Pre-mq.3 this fired
|
|
/// `WorkspaceLoadError::MethodNameCollision { kind: "class-class" }`.
|
|
/// Post-mq.3 the workspace loads cleanly and
|
|
/// `env.method_to_candidate_classes` carries both qualified classes as
|
|
/// candidates for the method name `foo`.
|
|
#[test]
|
|
fn mq3_class_class_collision_loads_clean_and_populates_candidates() {
|
|
let entry = examples_dir()
|
|
.join("test_22b2_method_name_collision_class_class.ail");
|
|
let ws = load_workspace(&entry)
|
|
.expect("post-mq.3: workspace loads without collision diagnostic");
|
|
|
|
let env = build_check_env(&ws);
|
|
let candidates = env
|
|
.method_to_candidate_classes
|
|
.get("foo")
|
|
.expect("`foo` must be in method_to_candidate_classes");
|
|
assert!(
|
|
candidates.contains("test_22b2_method_name_collision_class_class.A"),
|
|
"candidates must include class A: {candidates:?}",
|
|
);
|
|
assert!(
|
|
candidates.contains("test_22b2_method_name_collision_class_class.B"),
|
|
"candidates must include class B: {candidates:?}",
|
|
);
|
|
assert_eq!(
|
|
candidates.len(),
|
|
2,
|
|
"exactly two candidate classes for `foo`: {candidates:?}",
|
|
);
|
|
}
|
|
|
|
/// mq.3.5 (class-fn repurpose): the fixture
|
|
/// `examples/test_22b2_method_name_collision_class_fn.ail.json`
|
|
/// declares `class Greet { greet }` and `fn greet`. Pre-mq.3 this
|
|
/// fired `WorkspaceLoadError::MethodNameCollision { kind: "class-fn" }`.
|
|
/// Post-mq.3 the workspace loads cleanly — the method-vs-fn
|
|
/// coexistence is now legal at load time; the call-site emits a
|
|
/// `class-method-shadowed-by-fn` warning (covered by mq.3.6 E2E,
|
|
/// not this load-level pin).
|
|
#[test]
|
|
fn mq3_class_fn_collision_loads_clean() {
|
|
let entry = examples_dir()
|
|
.join("test_22b2_method_name_collision_class_fn.ail");
|
|
load_workspace(&entry)
|
|
.expect("post-mq.3: workspace loads — class-vs-fn name overlap is no longer a load error");
|
|
}
|