Brummel
76b21c00eb
Deletes `ParamMode::Implicit`. `ParamMode` is now `{Own, Borrow}`:
every fn-type slot on every signature carries an explicit `own` or
`borrow`, no defaulted position survives anywhere (model 0008 §2,
spec 0062). The parser rejects a bare fn-type slot; `borrow-return`
and `borrow-over-value` reject at the signature; the corpus is
migrated to minimal-ownership modes (consumed ⇒ own, read-only-heap
⇒ borrow, value ⇒ trivial-own). The documented `Implicit`-ret-mode
leak is fixed: an owned heap return now drops exactly once (live=0,
acceptance criterion 5).
This was the easy half. Removing the default ACTIVATED a family of
drop paths that `Implicit` had silently skipped — the pre-cutover
language was leaking (and in places mis-dropping) here rather than
crashing, because an Implicit scrutinee turned the drop off. Making
the modes explicit (Own) turned those paths on and exposed two
latent-bug clusters, all fixed RED-first as part of this cutover:
Drop-soundness family (four legs):
A. lit-sub-pattern double-free — the desugar re-matched the same
owned scrutinee in the lit fall-through; fixed by grouping
consecutive same-ctor arms into one match (bind fields once),
in ailang-core desugar.
B. Cons-husk leak on non-tail arm bodies — the lit-sub-pattern
desugar rebound the owned scrutinee via `Let $mp = xs`, which
bumped consume_count and suppressed the existing fn-return
partial_drop. Fixed by not rebinding a bare-Var scrutinee
(one husk-freeing mechanism, not two).
C. polymorphic `drop_<T>` rc_dec'd monomorphised value fields —
the per-ADT drop fn was emitted once from the polymorphic
TypeDef, defaulting type-var fields to ptr and rc_dec'ing
inline Ints (segfault). Fixed with per-monomorph drop
functions (new ailang-codegen::dropmono): the drop set is
collected from the lowered MIR, value-type fields are skipped,
heap fields still freed once; monomorphic-concrete ADTs keep
their byte-identical un-suffixed drop symbol.
D. static Str literal passed to an `(own Str)` param — the
literal lowers to a header-less rodata constant; the callee's
now-active rc_dec read its length field as a refcount and
freed a static address (segfault). Fixed with the missing
fourth StrRep::Static→Heap promotion in lower_to_mir's App arm,
gated on Own mode (borrow args stay static, no regression).
over-strict-mode lint over-fired: it suggested `(borrow V)` for
value-typed params (which `borrow-over-value` rejects — own is the
only legal mode there) and fired on `(intrinsic)` bodies (whose
consumption the linearity walk cannot observe). Tightened to skip
both; contract 0008 updated to the narrowed firing scope.
Irreversible step — canonical-form hash reset (model 0008 §6,
acceptance criterion 6). Every signature now carries explicit modes,
so the hashable canonical JSON changed for every module. RATIFY:
the corpus-wide hash-pin reset (hash_pin, prelude_module_hash_pin,
mono_hash_stability, eq_ord_e2e, embed_export_hash_stable, the
ct4/iter*/loop_recur schema-extension pins) and the list ir_snapshot
golden were regenerated once, deliberately, as the intended one-time
consequence of removing the mode elision from the canonical form —
not a regression. Each regenerated hash verified deterministic across
two runs.
Also fixes a pre-existing latent failure surfaced by the verification
gate, unrelated to this cutover: the `every_contract_names_a_resolvable_
ratifying_test` resolver (design_index_pin) could not resolve the
" + " dual-link ratifying-test form (`uniqueness.rs + linearity.rs`)
that the #57 audit-close (dfdc65f) introduced — it shipped red on that
commit. Resolver taught the dual-link form, mirroring its sibling.
Verification: cargo test --workspace = 731 passed, 0 failed (twice,
stable); e2e 102 passed, no binary exits non-zero (corpus crash-free);
grep-clean for Implicit/fn_implicit/mode_eq across crates; every drop
fix confirmed via emitted IR + AILANG_RC_STATS balance on the head==K,
head!=K, and Nil paths. Three BLOCKEDs en route (the unsound first
husk-dec attempt, the over-strict derivation premise, the leg-B fix
direction) were each treated as a real design/spec gap and rediagnosed,
not patched over.
Supersedes #54 (return-position-only leak patch). Precondition #57
(linearity hardening) was already met. Spec docs/specs/0062, plan
docs/plans/0121.
closes #55
53 lines
2.3 KiB
Plaintext
53 lines
2.3 KiB
Plaintext
; RED fixture (refs #55, Implicit-cutover husk leak — leg B, Nil sub-case).
|
|
;
|
|
; Property under test: an owned scrutinee threaded through the
|
|
; lit-sub-pattern chain desugar must have its OUTER cell freed
|
|
; exactly once on EVERY return path — including the path that
|
|
; matches the Nil arm and touches neither inner re-match.
|
|
;
|
|
; `first_or_default` has a lit sub-pattern arm `(Cons (pat-lit 0) _)`,
|
|
; so the 16c desugar (crates/ailang-core/src/desugar.rs `desugar_match`)
|
|
; is forced off the `is_flat` fast-path: it let-binds the owned
|
|
; scrutinee `xs` into a fresh `$mp` var and lowers the arms to a chain
|
|
; of single-level matches over `$mp`. Two breakages follow once the
|
|
; param mode is `Own` (post-#55 cutover):
|
|
; 1. the `Let $mp = xs` consumes `xs` (consume_count := 1), which
|
|
; trips the codegen fn-return gate `if consume_count != 0 {
|
|
; continue }` (crates/ailang-codegen/src/lib.rs ~1522) and
|
|
; SUPPRESSES the husk free that the equivalent single-match fn
|
|
; (e.g. std_list List_map) emits as `partial_drop_<T>(arg_xs, 2)`;
|
|
; 2. the husk obligation moves to the internal `$mp` binder, which the
|
|
; gate (it iterates `f.params` only) never inspects.
|
|
; Net effect: the outer cell of `xs` is never freed.
|
|
;
|
|
; This fixture isolates the Nil path specifically: `main` calls
|
|
; `first_or_default` with a bare `(IntList Nil)`. That path returns -1
|
|
; and flows entry -> Nil-arm -> fn-return join, touching neither inner
|
|
; Cons re-match. The Nil cell (one 8-byte alloc) leaks -> live=1.
|
|
; The companion fixture lit_pat_ctor_tail_drop.ail covers the Cons
|
|
; path; this one pins the distinct Nil path so a Cons-only fix cannot
|
|
; pass while still leaking Nil husks.
|
|
|
|
(module lit_pat_nil_scrutinee_drop
|
|
|
|
(data IntList
|
|
(ctor Nil)
|
|
(ctor Cons (con Int) (con IntList)))
|
|
|
|
(fn first_or_default
|
|
(doc "Empty -> -1; first element 0 -> 0; otherwise the head.")
|
|
(type (fn-type (params (borrow (con IntList))) (ret (own (con Int)))))
|
|
(params xs)
|
|
(body
|
|
(match xs
|
|
(case (pat-ctor Nil) -1)
|
|
(case (pat-ctor Cons (pat-lit 0) _) 0)
|
|
(case (pat-ctor Cons h _) h))))
|
|
|
|
(fn main
|
|
(doc "Drive the Nil scrutinee only. Expected output: -1.")
|
|
(type (fn-type (params) (ret (own (con Unit))) (effects IO)))
|
|
(params)
|
|
(body
|
|
(seq (app print (app first_or_default (term-ctor IntList Nil))) (do io/print_str "\n")))))
|