9fdc4cacff
Second half of the form-a-default-authoring milestone-close iter
(Boss-decided strategy C, big-bang). All seven tasks DONE; cargo
test --workspace green at every per-task boundary.
T6 — Bench-driver suffix flip from .ail.json to .ail across 4
Python scripts + run.sh. compile_check.py + cross_lang.py exit 0.
T7 — Re-author e2e.rs raw-JSON-inspect tests:
- diff_detects_changed_def — derive sum.ail.json on-the-fly via
`ail parse examples/sum.ail` into tempdir, then mutate + diff.
- borrow_own_demo_modes_are_metadata_only — same pattern.
- reuse_as_demo_under_rc_uses_inplace_rewrite — same pattern.
- render_parse_round_trip_canonical — RETIRED (subsumed by T1's
cli_parse_then_render_then_parse_is_idempotent over whole corpus).
- ail_run_accepts_ail_source_with_same_stdout_as_ail_json —
re-authored to derive hello.ail.json in a per-process tempdir
from hello.ail via `ail parse`, then assert dual-form stdout.
T8 — Bulk-delete 156 non-carve-out .ail.json. Inventory:
8 .ail.json (carve-outs, alphabetical: broken_unbound + prelude
+ 3× test_22b2_* + 3× test_ct1_*) + 157 .ail. carve_out_inventory
test un-#[ignore]'d and green. Forward-pulled 20 repairs that the
T1-5 dispatch's recon missed (12 Group-B suffix + 5 Group-A
load_workspace + 3 ail_run sites). Also forward-pulled T9 Step 5
(schema_coverage corpus flip from .ail.json to .ail) to satisfy
T8's green-gate.
T9 — Retire obsolete roundtrip tests:
- print_then_parse_round_trips_every_fixture (round_trip.rs)
- every_ail_fixture_matches_its_json_counterpart (round_trip.rs)
- cli_render_then_parse_preserves_canonical_bytes_on_every_fixture
- Dead helpers: list_json_fixtures ×2, round_trip_one,
strip_trailing_newlines.
Schema-coverage corpus already flipped in T8 (forward-pull).
T10 — DESIGN.md §"Roundtrip Invariant" (lines 2027-2109) restated
with parse-determinism + idempotency + CLI-pipeline-idempotency +
carve-out-anchor framing. Five surviving enforcement tests named.
§"Float literals" and §"Why anchored at top level" preserved.
T11 — §A4 doctrine edits: CLAUDE.md:5-6 + DESIGN.md:465-466.
Canonical form remains JSON-AST; authoring projection is .ail;
build derives JSON-AST in-process via ailang_surface::parse.
T12 — Milestone close:
- WhatsNew entry: user-facing language, lead with the change.
- Roadmap: [milestone] form-a struck [x] with closing note.
- Final inventory verified: 8 .ail.json + 157 .ail.
- Final cargo test --workspace: 557 passed, 0 failed, 3 ignored.
- bench/compile_check.py + bench/cross_lang.py: exit 0.
Test math: pre-iter 558 baseline + 3 new T1 tests = 561, − 1
(T7 retire) − 3 (T9 retire) = 557 final.
INDEX.md appended with the full iter summary covering T1-T12 (the
T1-5 commit at 77b28ad deferred the INDEX line to full-iter close).
Milestone [Form-A as the default authoring surface] structurally
closed. The compile-time-embed carve-out (prelude.ail.json) is
the subject of the queued follow-up milestone [Prelude embed:
Form-A as compile-time source]. audit-form-a runs as the next
dispatch.
400 lines
12 KiB
Rust
400 lines
12 KiB
Rust
//! Schema-coverage audit: every AST enum variant of `Def`, `Term`,
|
|
//! `Pattern`, `Literal`, `Type`, `ParamMode` is exercised by at
|
|
//! least one fixture under `examples/`.
|
|
//!
|
|
//! Why this exists: the round-trip tests in `ailang-surface` are
|
|
//! only as strong as the fixture corpus that drives them. A schema
|
|
//! variant with zero fixture coverage round-trips trivially — there
|
|
//! is nothing to round-trip. This test makes the corpus's coverage
|
|
//! observable, so a gap surfaces as a fail-loud test, not as silent
|
|
//! confidence.
|
|
//!
|
|
//! How it stays in sync with the AST: every match arm below is
|
|
//! exhaustive (no `_ => ...` wildcard). When a new AST variant
|
|
//! lands, the compiler rejects this file until the visitor and the
|
|
//! `VariantTag` enum are extended in lockstep.
|
|
//!
|
|
//! Pure reader: this test loads fixtures but does not modify any
|
|
//! committed content. A failure means a fixture must be added (in
|
|
//! a separate iteration); the test must not be relaxed.
|
|
|
|
use std::collections::HashSet;
|
|
use std::path::PathBuf;
|
|
|
|
use ailang_core::ast::{
|
|
Def, InstanceMethod, Literal, Module, ParamMode, Pattern, Term, Type,
|
|
};
|
|
|
|
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
|
|
enum VariantTag {
|
|
// Def
|
|
DefFn,
|
|
DefConst,
|
|
DefType,
|
|
DefClass,
|
|
DefInstance,
|
|
// Term
|
|
TermLit,
|
|
TermVar,
|
|
TermApp,
|
|
TermLet,
|
|
TermLetRec,
|
|
TermIf,
|
|
TermDo,
|
|
TermCtor,
|
|
TermMatch,
|
|
TermLam,
|
|
TermSeq,
|
|
TermClone,
|
|
TermReuseAs,
|
|
// Pattern
|
|
PatternWild,
|
|
PatternVar,
|
|
PatternLit,
|
|
PatternCtor,
|
|
// Literal
|
|
LiteralInt,
|
|
LiteralBool,
|
|
LiteralStr,
|
|
LiteralUnit,
|
|
LiteralFloat,
|
|
// Type
|
|
TypeCon,
|
|
TypeFn,
|
|
TypeVar,
|
|
TypeForall,
|
|
// ParamMode
|
|
ParamModeImplicit,
|
|
ParamModeOwn,
|
|
ParamModeBorrow,
|
|
}
|
|
|
|
/// Lists every expected variant. Stored as a const array so that
|
|
/// adding a new `VariantTag` here and forgetting to add the
|
|
/// corresponding match arm in the visitor is a Rust compile error
|
|
/// (and vice versa).
|
|
const EXPECTED_VARIANTS: &[VariantTag] = &[
|
|
VariantTag::DefFn,
|
|
VariantTag::DefConst,
|
|
VariantTag::DefType,
|
|
VariantTag::DefClass,
|
|
VariantTag::DefInstance,
|
|
VariantTag::TermLit,
|
|
VariantTag::TermVar,
|
|
VariantTag::TermApp,
|
|
VariantTag::TermLet,
|
|
VariantTag::TermLetRec,
|
|
VariantTag::TermIf,
|
|
VariantTag::TermDo,
|
|
VariantTag::TermCtor,
|
|
VariantTag::TermMatch,
|
|
VariantTag::TermLam,
|
|
VariantTag::TermSeq,
|
|
VariantTag::TermClone,
|
|
VariantTag::TermReuseAs,
|
|
VariantTag::PatternWild,
|
|
VariantTag::PatternVar,
|
|
VariantTag::PatternLit,
|
|
VariantTag::PatternCtor,
|
|
VariantTag::LiteralInt,
|
|
VariantTag::LiteralBool,
|
|
VariantTag::LiteralStr,
|
|
VariantTag::LiteralUnit,
|
|
VariantTag::LiteralFloat,
|
|
VariantTag::TypeCon,
|
|
VariantTag::TypeFn,
|
|
VariantTag::TypeVar,
|
|
VariantTag::TypeForall,
|
|
VariantTag::ParamModeImplicit,
|
|
VariantTag::ParamModeOwn,
|
|
VariantTag::ParamModeBorrow,
|
|
];
|
|
|
|
fn visit_def(def: &Def, observed: &mut HashSet<VariantTag>) {
|
|
match def {
|
|
Def::Fn(fd) => {
|
|
observed.insert(VariantTag::DefFn);
|
|
visit_type(&fd.ty, observed);
|
|
visit_term(&fd.body, observed);
|
|
}
|
|
Def::Const(cd) => {
|
|
observed.insert(VariantTag::DefConst);
|
|
visit_type(&cd.ty, observed);
|
|
visit_term(&cd.value, observed);
|
|
}
|
|
Def::Type(td) => {
|
|
observed.insert(VariantTag::DefType);
|
|
for ctor in &td.ctors {
|
|
for field_ty in &ctor.fields {
|
|
visit_type(field_ty, observed);
|
|
}
|
|
}
|
|
}
|
|
Def::Class(cd) => {
|
|
observed.insert(VariantTag::DefClass);
|
|
for m in &cd.methods {
|
|
visit_type(&m.ty, observed);
|
|
if let Some(body) = &m.default {
|
|
visit_term(body, observed);
|
|
}
|
|
}
|
|
}
|
|
Def::Instance(id) => {
|
|
observed.insert(VariantTag::DefInstance);
|
|
visit_type(&id.type_, observed);
|
|
for m in &id.methods {
|
|
visit_instance_method(m, observed);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn visit_instance_method(m: &InstanceMethod, observed: &mut HashSet<VariantTag>) {
|
|
visit_term(&m.body, observed);
|
|
}
|
|
|
|
fn visit_term(t: &Term, observed: &mut HashSet<VariantTag>) {
|
|
match t {
|
|
Term::Lit { lit } => {
|
|
observed.insert(VariantTag::TermLit);
|
|
visit_literal(lit, observed);
|
|
}
|
|
Term::Var { .. } => {
|
|
observed.insert(VariantTag::TermVar);
|
|
}
|
|
Term::App { callee, args, .. } => {
|
|
observed.insert(VariantTag::TermApp);
|
|
visit_term(callee, observed);
|
|
for a in args {
|
|
visit_term(a, observed);
|
|
}
|
|
}
|
|
Term::Let { value, body, .. } => {
|
|
observed.insert(VariantTag::TermLet);
|
|
visit_term(value, observed);
|
|
visit_term(body, observed);
|
|
}
|
|
Term::LetRec { ty, body, in_term, .. } => {
|
|
observed.insert(VariantTag::TermLetRec);
|
|
visit_type(ty, observed);
|
|
visit_term(body, observed);
|
|
visit_term(in_term, observed);
|
|
}
|
|
Term::If { cond, then, else_ } => {
|
|
observed.insert(VariantTag::TermIf);
|
|
visit_term(cond, observed);
|
|
visit_term(then, observed);
|
|
visit_term(else_, observed);
|
|
}
|
|
Term::Do { args, .. } => {
|
|
observed.insert(VariantTag::TermDo);
|
|
for a in args {
|
|
visit_term(a, observed);
|
|
}
|
|
}
|
|
Term::Ctor { args, .. } => {
|
|
observed.insert(VariantTag::TermCtor);
|
|
for a in args {
|
|
visit_term(a, observed);
|
|
}
|
|
}
|
|
Term::Match { scrutinee, arms } => {
|
|
observed.insert(VariantTag::TermMatch);
|
|
visit_term(scrutinee, observed);
|
|
for arm in arms {
|
|
visit_pattern(&arm.pat, observed);
|
|
visit_term(&arm.body, observed);
|
|
}
|
|
}
|
|
Term::Lam { param_tys, ret_ty, body, .. } => {
|
|
observed.insert(VariantTag::TermLam);
|
|
for ty in param_tys {
|
|
visit_type(ty, observed);
|
|
}
|
|
visit_type(ret_ty, observed);
|
|
visit_term(body, observed);
|
|
}
|
|
Term::Seq { lhs, rhs } => {
|
|
observed.insert(VariantTag::TermSeq);
|
|
visit_term(lhs, observed);
|
|
visit_term(rhs, observed);
|
|
}
|
|
Term::Clone { value } => {
|
|
observed.insert(VariantTag::TermClone);
|
|
visit_term(value, observed);
|
|
}
|
|
Term::ReuseAs { source, body } => {
|
|
observed.insert(VariantTag::TermReuseAs);
|
|
visit_term(source, observed);
|
|
visit_term(body, observed);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn visit_pattern(p: &Pattern, observed: &mut HashSet<VariantTag>) {
|
|
match p {
|
|
Pattern::Wild => {
|
|
observed.insert(VariantTag::PatternWild);
|
|
}
|
|
Pattern::Var { .. } => {
|
|
observed.insert(VariantTag::PatternVar);
|
|
}
|
|
Pattern::Lit { lit } => {
|
|
observed.insert(VariantTag::PatternLit);
|
|
visit_literal(lit, observed);
|
|
}
|
|
Pattern::Ctor { fields, .. } => {
|
|
observed.insert(VariantTag::PatternCtor);
|
|
for f in fields {
|
|
visit_pattern(f, observed);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn visit_literal(l: &Literal, observed: &mut HashSet<VariantTag>) {
|
|
match l {
|
|
Literal::Int { .. } => {
|
|
observed.insert(VariantTag::LiteralInt);
|
|
}
|
|
Literal::Bool { .. } => {
|
|
observed.insert(VariantTag::LiteralBool);
|
|
}
|
|
Literal::Str { .. } => {
|
|
observed.insert(VariantTag::LiteralStr);
|
|
}
|
|
Literal::Unit => {
|
|
observed.insert(VariantTag::LiteralUnit);
|
|
}
|
|
Literal::Float { .. } => {
|
|
observed.insert(VariantTag::LiteralFloat);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn visit_type(t: &Type, observed: &mut HashSet<VariantTag>) {
|
|
match t {
|
|
Type::Con { args, .. } => {
|
|
observed.insert(VariantTag::TypeCon);
|
|
for a in args {
|
|
visit_type(a, observed);
|
|
}
|
|
}
|
|
Type::Fn { params, param_modes, ret, ret_mode, .. } => {
|
|
observed.insert(VariantTag::TypeFn);
|
|
for p in params {
|
|
visit_type(p, observed);
|
|
}
|
|
for m in param_modes {
|
|
visit_param_mode(m, observed);
|
|
}
|
|
visit_type(ret, observed);
|
|
visit_param_mode(ret_mode, observed);
|
|
}
|
|
Type::Var { .. } => {
|
|
observed.insert(VariantTag::TypeVar);
|
|
}
|
|
Type::Forall { body, .. } => {
|
|
observed.insert(VariantTag::TypeForall);
|
|
visit_type(body, observed);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn visit_param_mode(m: &ParamMode, observed: &mut HashSet<VariantTag>) {
|
|
match m {
|
|
ParamMode::Implicit => {
|
|
observed.insert(VariantTag::ParamModeImplicit);
|
|
}
|
|
ParamMode::Own => {
|
|
observed.insert(VariantTag::ParamModeOwn);
|
|
}
|
|
ParamMode::Borrow => {
|
|
observed.insert(VariantTag::ParamModeBorrow);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn visit_module(m: &Module, observed: &mut HashSet<VariantTag>) {
|
|
for def in &m.defs {
|
|
visit_def(def, observed);
|
|
}
|
|
}
|
|
|
|
fn examples_dir() -> PathBuf {
|
|
let crate_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
|
crate_dir.parent().unwrap().parent().unwrap().join("examples")
|
|
}
|
|
|
|
fn list_ail_fixtures() -> Vec<PathBuf> {
|
|
let dir = examples_dir();
|
|
let mut paths: Vec<PathBuf> = std::fs::read_dir(&dir)
|
|
.unwrap_or_else(|e| panic!("read_dir({}): {e}", dir.display()))
|
|
.filter_map(|entry| entry.ok())
|
|
.map(|e| e.path())
|
|
.filter(|p| {
|
|
p.file_name()
|
|
.and_then(|n| n.to_str())
|
|
.map(|n| n.ends_with(".ail"))
|
|
.unwrap_or(false)
|
|
})
|
|
.collect();
|
|
paths.sort();
|
|
paths
|
|
}
|
|
|
|
#[test]
|
|
fn every_ast_variant_is_observed_in_the_fixture_corpus() {
|
|
let fixtures = list_ail_fixtures();
|
|
assert!(
|
|
!fixtures.is_empty(),
|
|
"no .ail fixtures found under {}",
|
|
examples_dir().display()
|
|
);
|
|
|
|
let mut observed: HashSet<VariantTag> = HashSet::new();
|
|
let mut load_failures = Vec::<String>::new();
|
|
|
|
for path in &fixtures {
|
|
match ailang_surface::load_module(path) {
|
|
Ok(m) => visit_module(&m, &mut observed),
|
|
Err(e) => load_failures.push(format!("{}: {e}", path.display())),
|
|
}
|
|
}
|
|
|
|
// Load failures fail the test on their own — a fixture that
|
|
// does not load is a corpus bug, surface it loud.
|
|
if !load_failures.is_empty() {
|
|
panic!(
|
|
"{} fixture(s) failed to load during coverage scan:\n{}",
|
|
load_failures.len(),
|
|
load_failures.join("\n")
|
|
);
|
|
}
|
|
|
|
let missing: Vec<VariantTag> = EXPECTED_VARIANTS
|
|
.iter()
|
|
.copied()
|
|
.filter(|v| !observed.contains(v))
|
|
.collect();
|
|
|
|
if !missing.is_empty() {
|
|
let names: Vec<String> = missing.iter().map(|v| format!("{v:?}")).collect();
|
|
panic!(
|
|
"{} AST variant(s) have NO fixture coverage in {}:\n {}\n\n\
|
|
every variant must be exercised by at least one fixture; \
|
|
add a fixture that uses each missing variant (do NOT \
|
|
weaken this test).",
|
|
missing.len(),
|
|
examples_dir().display(),
|
|
names.join("\n ")
|
|
);
|
|
}
|
|
|
|
eprintln!(
|
|
"schema coverage ok: {} variants observed across {} fixtures",
|
|
observed.len(),
|
|
fixtures.len()
|
|
);
|
|
}
|