ac4d545570
Follow-up to bcd4181: the remaining ~530 inline `//` and `///`
comments still carrying opaque shorthand are now reformulated to
their content phrases. The only surviving `iter-<code>` reference
in source is the literal filename
`docs/journals/2026-05-13-iter-mq.3.md` (a real journal file).
Sweep covered:
- `// Iter X.Y: <text>` prefixes (Iter 13a / 14a / 14e / 15g-aux /
16b.x / 16d / 16e / 18b / 18c.x / 18d.x / 18e / 18g.x / 19a /
19a.1 / 19b / 20a / 20f / 22-floats.x / 22b.x / 22c / 23.x /
24.1 / cli-diag-human / hs.x / str-concat / etc.) — fully
removed; the descriptive text that followed each prefix stays.
- `// (Decision N)` and `per Decision N` and `Decision N axis 3` —
replaced with the content phrase plus the relevant contract
file (`design/contracts/tail-calls.md` for Decision 8,
`design/contracts/memory-model.md` for Decision 10,
`design/contracts/typeclasses.md` and `design/models/typeclasses.md`
for Decision 11, `design/contracts/authoring-surface.md` for
Decision 6, "the transitional dual-allocator" for Decision 9,
"Effect prose" for Decision 3).
- `// mq.X / mq.X (Task N) / mq.X journal / mq.X invariant` ->
"the canonical-class-form rule / Class-class repurpose /
method-dispatch-refactor journal / canonical-class-form
invariant".
- `// ct.X / ct.X (canonical-type-names) / ct.1.5a + ctt.2 /
ct.2 Task N` -> "the canonical-form rule for type references /
the canonical-form normalisation step / canonical-type-lookup
refactor".
- `// eob.X` -> "heap-Str-ABI" / "the Str carve-out".
- `// rpe.X` -> "the per-type-print-op retirement".
- `// post-mq.X / Pre-ct.X / pre-mq.X` -> "post-canonical-class-form" /
"Pre-canonical-type-form" etc.
- `/// Iter X regression: / /// Iter X.Y: / /// Iter A arm-close /
/// Iter ct.4 (...): / /// Iter rpe.1 ...` -> descriptive
phrases.
The journal filename in `crates/ailang-core/src/workspace.rs:573`
stays verbatim because it points at an actual file under
`docs/journals/`.
Tests: full `cargo test --workspace` green (80/80 test-result blocks
clean, no FAILED line). design_index_pin 5/5 + docs_honesty_pin 5/5
gating tests pass.
111 lines
4.3 KiB
Rust
111 lines
4.3 KiB
Rust
//! End-to-end coverage of the post-`MethodNameCollision`-
|
|
//! retirement multi-candidate dispatch path. Three positive fixtures
|
|
//! exercise the three trajectories from the milestone spec
|
|
//! §"Data flow":
|
|
//!
|
|
//! - Trajectory C — ambiguous bare-method call with both candidate
|
|
//! classes shipping `Show Int`. Typecheck rejects with
|
|
//! `ambiguous-method-resolution`.
|
|
//! - Trajectory E — explicit qualifier `<module>.<Class>.<method>`
|
|
//! resolves cleanly to the named class.
|
|
//! - Class-fn shadow — bare-method call where both a class method and
|
|
//! a free fn of the same name exist. Fn wins per lookup precedence;
|
|
//! `class-method-shadowed-by-fn` warning fires so the LLM-author
|
|
//! sees the shadow.
|
|
//!
|
|
//! Each test invokes `ail check --json <entry>` and asserts on the
|
|
//! diagnostic stream's `code` field. Stdout / runtime behaviour is
|
|
//! out of scope here — the dispatch path is a check-time concern.
|
|
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
|
|
fn ail_bin() -> PathBuf {
|
|
PathBuf::from(env!("CARGO_BIN_EXE_ail"))
|
|
}
|
|
|
|
fn examples_dir() -> PathBuf {
|
|
PathBuf::from(env!("CARGO_MANIFEST_DIR"))
|
|
.join("..")
|
|
.join("..")
|
|
.join("examples")
|
|
}
|
|
|
|
fn run_ail_check_json(entry: &str) -> std::process::Output {
|
|
Command::new(ail_bin())
|
|
.args(["check", "--json", examples_dir().join(entry).to_str().unwrap()])
|
|
.output()
|
|
.expect("ail binary must launch")
|
|
}
|
|
|
|
/// Multi-class trajectory C: bare `show 42` in a workspace with two
|
|
/// `Show` classes (modA and modB) each shipping `Show Int` is
|
|
/// genuinely ambiguous. `ail check` rejects with
|
|
/// `ambiguous-method-resolution` and names both candidate classes.
|
|
#[test]
|
|
fn mq3_two_show_ambiguous_fires_ambiguous_method_resolution() {
|
|
let out = run_ail_check_json("mq3_two_show_ambiguous.ail");
|
|
assert!(
|
|
!out.status.success(),
|
|
"expected check to reject ambiguous dispatch; stdout={} stderr={}",
|
|
String::from_utf8_lossy(&out.stdout),
|
|
String::from_utf8_lossy(&out.stderr),
|
|
);
|
|
let stdout = String::from_utf8(out.stdout).expect("stdout is utf-8");
|
|
let diags: serde_json::Value =
|
|
serde_json::from_str(&stdout).expect("--json mode emits a JSON array on stdout");
|
|
let arr = diags.as_array().expect("diagnostics is a JSON array");
|
|
assert!(
|
|
arr.iter().any(|d| d["code"] == "ambiguous-method-resolution"),
|
|
"expected `ambiguous-method-resolution` diagnostic; got {stdout}",
|
|
);
|
|
// Both candidate classes named in the diagnostic so the author
|
|
// knows which qualifiers to choose from.
|
|
assert!(
|
|
stdout.contains("mq3_two_show_ambiguous_a.Show"),
|
|
"expected candidate A in diagnostic; got {stdout}",
|
|
);
|
|
assert!(
|
|
stdout.contains("mq3_two_show_ambiguous_b.Show"),
|
|
"expected candidate B in diagnostic; got {stdout}",
|
|
);
|
|
}
|
|
|
|
/// Multi-class trajectory E: explicit qualifier
|
|
/// `mq3_two_show_ambiguous_a.Show.show 42` disambiguates the same
|
|
/// workspace as the ambiguous fixture. Typecheck succeeds.
|
|
#[test]
|
|
fn mq3_two_show_qualified_resolves_clean() {
|
|
let out = run_ail_check_json("mq3_two_show_qualified.ail");
|
|
assert!(
|
|
out.status.success(),
|
|
"expected check to succeed with explicit qualifier; stdout={} stderr={}",
|
|
String::from_utf8_lossy(&out.stdout),
|
|
String::from_utf8_lossy(&out.stderr),
|
|
);
|
|
}
|
|
|
|
/// Class-fn shadow: bare `myeq 1 2` in a workspace with
|
|
/// `class MyEq { myeq }` in one module and `fn myeq` in another
|
|
/// resolves to the fn per lookup precedence. Typecheck succeeds AND
|
|
/// the structured warning `class-method-shadowed-by-fn` fires so the
|
|
/// LLM-author sees the shadow.
|
|
#[test]
|
|
fn mq3_class_eq_vs_fn_eq_fn_wins_with_warning() {
|
|
let out = run_ail_check_json("mq3_class_eq_vs_fn_eq.ail");
|
|
assert!(
|
|
out.status.success(),
|
|
"expected check to succeed (fn wins); stdout={} stderr={}",
|
|
String::from_utf8_lossy(&out.stdout),
|
|
String::from_utf8_lossy(&out.stderr),
|
|
);
|
|
let stdout = String::from_utf8(out.stdout).expect("stdout is utf-8");
|
|
let diags: serde_json::Value =
|
|
serde_json::from_str(&stdout).expect("--json mode emits a JSON array on stdout");
|
|
let arr = diags.as_array().expect("diagnostics is a JSON array");
|
|
assert!(
|
|
arr.iter().any(|d| d["code"] == "class-method-shadowed-by-fn"),
|
|
"expected `class-method-shadowed-by-fn` warning; got {stdout}",
|
|
);
|
|
}
|