Brummel
bcd41810f4
Reader-facing prose and rustdoc carried opaque shorthand like
"Decision 10", "clause-5", "mq.1", "ct.1", "eob.1", "rpe.1",
"post-mq.3", and "Iter 22b.1:" with no in-repo definition the reader
could follow. This commit replaces every such occurrence in the
durable tier the reader is most likely to land on (design/ ledger +
source //! module headers + the central /// public-item rustdoc) with
an inline content phrase plus, where applicable, a Markdown link to
the file that defines the referenced concept.
design/ ledger — 16 files:
Definition-site headings demoted from "Decision N: <title>" to
"<title>": authoring-surface, tail-calls, memory-model section in
rc-uniqueness.md, dual-allocator section, typeclass design,
effects "pure core + algebraic effects".
Cross-reference sites: "Decision 1" -> canonical-schema principle
(data-model); "Decision 3/4" -> effects + scope-boundaries; "Decision
6" -> authoring-surface; "Decision 8" -> tail-calls; "Decision 9" ->
rc-uniqueness (dual-allocator); "Decision 10" -> memory-model;
"Decision 11" -> typeclasses (model). "clause-5" -> body-link
durability gate. "clause-3" (in language-constraints) ->
bug-class-reintroduction discriminator. "mq.1/2/3", "ct.1/4",
"eob.1", "rpe.1" -> the canonical-form rule / the type-driven
dispatch / the Str carve-out / etc. "post-mq.3" -> "type-driven".
design/contracts/feature-acceptance.md: file-local "clauses 1/2/3"
-> "criteria 1/2/3" (sprachliche Kohärenz mit der File-Überschrift
"Feature-acceptance criterion"); "the clause-3 mechanism" -> "the
bug-class-reintroduction discriminator".
Source //! module headers — 24 files:
Stripped "Iter X.Y:" prefixes and "(Decision N)" / "(mq.X)" tags
from spec_drift, uniqueness, reuse_shape, migrate_canonical_types,
typeclass_22b{2,3,c}, suppress_filter, lift, mono, linearity,
diagnostic, method_dispatch_pin, method_collision_pin,
no_per_type_print_ops, mq3_multi_class_e2e, print_mono_body_shape,
print_no_leak_pin, cli_diag_human_workspace_load_error,
ct1_check_cli, prose snapshot, unbound_in_instance_method_pin,
mono_xmod_ctor_pattern, desugar.
Central /// public-item rustdoc:
ast.rs (full sweep — every "Iter X" + "Decision N" prefix
reformulated; mode/Type::Fn rustdoc now points at memory-model.md;
Constraint / SuperclassRef / InstanceDef / ClassDef rustdoc points
at typeclasses contract).
diagnostic.rs (all "(Iter X)" / "(mq.X)" tags on diagnostic codes
removed).
lib.rs (FORM_A_SPEC rustdoc points at authoring-surface.md
instead of "Decision 6").
canonical.rs (type_hash + Float-literal rustdoc).
Still outstanding (for a follow-up commit): ~500 inline `//`
code-body comments with `Iter X.Y` markers across the workspace, and
a handful of `///` rustdoc items in hash_pin / workspace_pin / lift /
mono / suppress_filter test-pin and internal-function bodies. Code
identifiers (test filenames like `mq3_multi_class_e2e.rs`, function
names like `iter18e_drop_iterative_default_preserves_hashes`) stay
verbatim per the user's "code identifiers stay verbatim" rule.
Tests: design_index_pin 5/5 + docs_honesty_pin 5/5; workspace builds
clean; full `cargo test --workspace` previously green (every
`test result: ok` line, no FAILED line).
77 lines
3.2 KiB
Rust
77 lines
3.2 KiB
Rust
//! Repurposed pin tests for the post-`MethodNameCollision`-retirement
|
|
//! workspace-load path. The two on-disk fixtures that fired
|
|
//! `WorkspaceLoadError::MethodNameCollision` before the type-driven
|
|
//! dispatch refactor now load cleanly;
|
|
//! the assertion migrates from "expect collision diagnostic" to "load
|
|
//! successful + `Env.method_to_candidate_classes` carries the
|
|
//! expected multi-entry set" (class-class case) or "load successful +
|
|
//! class-fn coexistence is legal" (class-fn case).
|
|
//!
|
|
//! The relocation from `crates/ailang-core/src/workspace.rs` to this
|
|
//! file is required because the post-retirement assertions read
|
|
//! `Env.method_to_candidate_classes`, which is built by `ailang-check`
|
|
//! (`build_check_env`) and not visible from `ailang-core`.
|
|
|
|
use ailang_check::build_check_env;
|
|
use ailang_surface::load_workspace;
|
|
use std::path::Path;
|
|
|
|
fn examples_dir() -> std::path::PathBuf {
|
|
let manifest = env!("CARGO_MANIFEST_DIR");
|
|
Path::new(manifest)
|
|
.parent().expect("CARGO_MANIFEST_DIR has a parent (crates/ailang-check)")
|
|
.parent().expect("CARGO_MANIFEST_DIR has a grandparent (crates/)")
|
|
.join("examples")
|
|
}
|
|
|
|
/// mq.3.5 (class-class repurpose): the fixture
|
|
/// `examples/test_22b2_method_name_collision_class_class.ail.json`
|
|
/// declares two classes `A` and `B` in the same module, each declaring
|
|
/// the method `foo`. Pre-mq.3 this fired
|
|
/// `WorkspaceLoadError::MethodNameCollision { kind: "class-class" }`.
|
|
/// Post-mq.3 the workspace loads cleanly and
|
|
/// `env.method_to_candidate_classes` carries both qualified classes as
|
|
/// candidates for the method name `foo`.
|
|
#[test]
|
|
fn mq3_class_class_collision_loads_clean_and_populates_candidates() {
|
|
let entry = examples_dir()
|
|
.join("test_22b2_method_name_collision_class_class.ail");
|
|
let ws = load_workspace(&entry)
|
|
.expect("post-mq.3: workspace loads without collision diagnostic");
|
|
|
|
let env = build_check_env(&ws);
|
|
let candidates = env
|
|
.method_to_candidate_classes
|
|
.get("foo")
|
|
.expect("`foo` must be in method_to_candidate_classes");
|
|
assert!(
|
|
candidates.contains("test_22b2_method_name_collision_class_class.A"),
|
|
"candidates must include class A: {candidates:?}",
|
|
);
|
|
assert!(
|
|
candidates.contains("test_22b2_method_name_collision_class_class.B"),
|
|
"candidates must include class B: {candidates:?}",
|
|
);
|
|
assert_eq!(
|
|
candidates.len(),
|
|
2,
|
|
"exactly two candidate classes for `foo`: {candidates:?}",
|
|
);
|
|
}
|
|
|
|
/// mq.3.5 (class-fn repurpose): the fixture
|
|
/// `examples/test_22b2_method_name_collision_class_fn.ail.json`
|
|
/// declares `class Greet { greet }` and `fn greet`. Pre-mq.3 this
|
|
/// fired `WorkspaceLoadError::MethodNameCollision { kind: "class-fn" }`.
|
|
/// Post-mq.3 the workspace loads cleanly — the method-vs-fn
|
|
/// coexistence is now legal at load time; the call-site emits a
|
|
/// `class-method-shadowed-by-fn` warning (covered by mq.3.6 E2E,
|
|
/// not this load-level pin).
|
|
#[test]
|
|
fn mq3_class_fn_collision_loads_clean() {
|
|
let entry = examples_dir()
|
|
.join("test_22b2_method_name_collision_class_fn.ail");
|
|
load_workspace(&entry)
|
|
.expect("post-mq.3: workspace loads — class-vs-fn name overlap is no longer a load error");
|
|
}
|