Brummel
76b21c00eb
Deletes `ParamMode::Implicit`. `ParamMode` is now `{Own, Borrow}`:
every fn-type slot on every signature carries an explicit `own` or
`borrow`, no defaulted position survives anywhere (model 0008 §2,
spec 0062). The parser rejects a bare fn-type slot; `borrow-return`
and `borrow-over-value` reject at the signature; the corpus is
migrated to minimal-ownership modes (consumed ⇒ own, read-only-heap
⇒ borrow, value ⇒ trivial-own). The documented `Implicit`-ret-mode
leak is fixed: an owned heap return now drops exactly once (live=0,
acceptance criterion 5).
This was the easy half. Removing the default ACTIVATED a family of
drop paths that `Implicit` had silently skipped — the pre-cutover
language was leaking (and in places mis-dropping) here rather than
crashing, because an Implicit scrutinee turned the drop off. Making
the modes explicit (Own) turned those paths on and exposed two
latent-bug clusters, all fixed RED-first as part of this cutover:
Drop-soundness family (four legs):
A. lit-sub-pattern double-free — the desugar re-matched the same
owned scrutinee in the lit fall-through; fixed by grouping
consecutive same-ctor arms into one match (bind fields once),
in ailang-core desugar.
B. Cons-husk leak on non-tail arm bodies — the lit-sub-pattern
desugar rebound the owned scrutinee via `Let $mp = xs`, which
bumped consume_count and suppressed the existing fn-return
partial_drop. Fixed by not rebinding a bare-Var scrutinee
(one husk-freeing mechanism, not two).
C. polymorphic `drop_<T>` rc_dec'd monomorphised value fields —
the per-ADT drop fn was emitted once from the polymorphic
TypeDef, defaulting type-var fields to ptr and rc_dec'ing
inline Ints (segfault). Fixed with per-monomorph drop
functions (new ailang-codegen::dropmono): the drop set is
collected from the lowered MIR, value-type fields are skipped,
heap fields still freed once; monomorphic-concrete ADTs keep
their byte-identical un-suffixed drop symbol.
D. static Str literal passed to an `(own Str)` param — the
literal lowers to a header-less rodata constant; the callee's
now-active rc_dec read its length field as a refcount and
freed a static address (segfault). Fixed with the missing
fourth StrRep::Static→Heap promotion in lower_to_mir's App arm,
gated on Own mode (borrow args stay static, no regression).
over-strict-mode lint over-fired: it suggested `(borrow V)` for
value-typed params (which `borrow-over-value` rejects — own is the
only legal mode there) and fired on `(intrinsic)` bodies (whose
consumption the linearity walk cannot observe). Tightened to skip
both; contract 0008 updated to the narrowed firing scope.
Irreversible step — canonical-form hash reset (model 0008 §6,
acceptance criterion 6). Every signature now carries explicit modes,
so the hashable canonical JSON changed for every module. RATIFY:
the corpus-wide hash-pin reset (hash_pin, prelude_module_hash_pin,
mono_hash_stability, eq_ord_e2e, embed_export_hash_stable, the
ct4/iter*/loop_recur schema-extension pins) and the list ir_snapshot
golden were regenerated once, deliberately, as the intended one-time
consequence of removing the mode elision from the canonical form —
not a regression. Each regenerated hash verified deterministic across
two runs.
Also fixes a pre-existing latent failure surfaced by the verification
gate, unrelated to this cutover: the `every_contract_names_a_resolvable_
ratifying_test` resolver (design_index_pin) could not resolve the
" + " dual-link ratifying-test form (`uniqueness.rs + linearity.rs`)
that the #57 audit-close (dfdc65f) introduced — it shipped red on that
commit. Resolver taught the dual-link form, mirroring its sibling.
Verification: cargo test --workspace = 731 passed, 0 failed (twice,
stable); e2e 102 passed, no binary exits non-zero (corpus crash-free);
grep-clean for Implicit/fn_implicit/mode_eq across crates; every drop
fix confirmed via emitted IR + AILANG_RC_STATS balance on the head==K,
head!=K, and Nil paths. Three BLOCKEDs en route (the unsound first
husk-dec attempt, the over-strict derivation premise, the leg-B fix
direction) were each treated as a real design/spec gap and rediagnosed,
not patched over.
Supersedes #54 (return-position-only leak patch). Precondition #57
(linearity hardening) was already met. Spec docs/specs/0062, plan
docs/plans/0121.
closes #55
77 lines
3.3 KiB
Plaintext
77 lines
3.3 KiB
Plaintext
; Fieldtest raw-buf comprehensive .4 (Axes 1+2+3 — Int buffer, an
|
|
; own->own fill helper across a function boundary, plus TWO distinct
|
|
; borrow-receiver helpers composed over the same buffer).
|
|
;
|
|
; Task an LLM author is naturally given: "fill a buffer of N slots with
|
|
; the Fibonacci sequence, then report both the total and the index of
|
|
; the largest element." The natural decomposition is three helpers:
|
|
; - `fill` : (own RawBuf, Int) -> own RawBuf (loop/recur, runtime N)
|
|
; - `total` : (borrow RawBuf) -> Int (read loop off .size)
|
|
; - `argmax`: (borrow RawBuf) -> Int (read loop, tracks idx)
|
|
; and a main that threads the owned buffer through `fill`, then borrows
|
|
; it TWICE in sequence (`total buf`, then `argmax buf`) — the natural
|
|
; "compute several summaries of one read-only buffer" shape.
|
|
;
|
|
; This stresses the #46 borrow-receiver fix under composition: two
|
|
; independent borrows of the same owned binder, each a helper that does
|
|
; multiple RawBuf.get / RawBuf.size calls on its borrow parameter. The
|
|
; prior rawbuf_1 had a single borrow helper; this has two, called back
|
|
; to back on the same buffer, with the buffer still owned (and dropped)
|
|
; by main afterwards.
|
|
;
|
|
; Fib(0..5) = 1,1,2,3,5,8 (seeding fib(0)=fib(1)=1).
|
|
; total = 1+1+2+3+5+8 = 20
|
|
; argmax = index 5 (value 8 is largest)
|
|
; Expected stdout: "20" then "5".
|
|
|
|
(module rbx_4_int_two_borrow_helpers
|
|
|
|
(fn fill
|
|
(doc "Fill slot i with fib(i) for i in 0..n. Linear own->own.")
|
|
(type (fn-type (params (own (con RawBuf (con Int))) (own (con Int))) (ret (own (con RawBuf (con Int))))))
|
|
(params buf n)
|
|
(body
|
|
; Seed slots 0 and 1 to 1, then each later slot = sum of prior two,
|
|
; read back from the buffer itself via RawBuf.get on the owned `b`.
|
|
(loop (b (con RawBuf (con Int)) buf) (i (con Int) 0)
|
|
(if (app ge i n)
|
|
b
|
|
(recur (app RawBuf.set b i
|
|
(if (app le i 1)
|
|
1
|
|
(app + (app RawBuf.get b (app - i 1))
|
|
(app RawBuf.get b (app - i 2)))))
|
|
(app + i 1))))))
|
|
|
|
(fn total
|
|
(doc "Sum every slot, borrow receiver.")
|
|
(type (fn-type (params (borrow (con RawBuf (con Int)))) (ret (own (con Int)))))
|
|
(params buf)
|
|
(body
|
|
(loop (acc (con Int) 0) (i (con Int) 0)
|
|
(if (app ge i (app RawBuf.size buf))
|
|
acc
|
|
(recur (app + acc (app RawBuf.get buf i))
|
|
(app + i 1))))))
|
|
|
|
(fn argmax
|
|
(doc "Index of the largest slot, borrow receiver. Tracks (best_i, best_v).")
|
|
(type (fn-type (params (borrow (con RawBuf (con Int)))) (ret (own (con Int)))))
|
|
(params buf)
|
|
(body
|
|
(loop (best_i (con Int) 0) (best_v (con Int) (app RawBuf.get buf 0)) (i (con Int) 0)
|
|
(if (app ge i (app RawBuf.size buf))
|
|
best_i
|
|
(if (app gt (app RawBuf.get buf i) best_v)
|
|
(recur i (app RawBuf.get buf i) (app + i 1))
|
|
(recur best_i best_v (app + i 1)))))))
|
|
|
|
(fn main
|
|
(type (fn-type (params) (ret (own (con Unit))) (effects IO)))
|
|
(params)
|
|
(body
|
|
(let buf (new RawBuf (con Int) 6)
|
|
(let buf (app fill buf 6)
|
|
(seq (seq (app print (app total buf)) (do io/print_str "\n"))
|
|
(seq (app print (app argmax buf)) (do io/print_str "\n"))))))))
|