Brummel
99d3968656
Closes the module-qualified-class-names milestone. Deletes the workspace-load workaround; the two-libraries case now resolves via type-driven dispatch at the call site with explicit qualifier as the LLM-author's disambiguation tool. Resolves both mq.2 known-debt items (active_declared_constraints plumbing, (class,method) re-key). New synth warnings channel emits class-method-shadowed-by-fn at all three fn-precedence branches per spec section Class-fn collisions. Three new E2E fixtures + integration tests cover the ambiguous, qualified, and class-fn-shadow trajectories. DESIGN.md class-names paragraph rewritten, new section Method dispatch added. Roadmap P2 marked done, milestone-24 unblocked for re-brainstorm. 9/9 tasks. 545 tests green. bench/compile_check.py + cross_lang.py exit 0; bench/check.py exit 1 (2 noise-class regressions, runtime uncoupled to typecheck iter).
111 lines
4.4 KiB
Rust
111 lines
4.4 KiB
Rust
//! mq.3.6: end-to-end coverage of the post-`MethodNameCollision`-
|
|
//! retirement multi-candidate dispatch path. Three positive fixtures
|
|
//! exercise the three trajectories from the milestone spec
|
|
//! §"Data flow":
|
|
//!
|
|
//! - Trajectory C — ambiguous bare-method call with both candidate
|
|
//! classes shipping `Show Int`. Typecheck rejects with
|
|
//! `ambiguous-method-resolution`.
|
|
//! - Trajectory E — explicit qualifier `<module>.<Class>.<method>`
|
|
//! resolves cleanly to the named class.
|
|
//! - Class-fn shadow — bare-method call where both a class method and
|
|
//! a free fn of the same name exist. Fn wins per lookup precedence;
|
|
//! `class-method-shadowed-by-fn` warning fires so the LLM-author
|
|
//! sees the shadow.
|
|
//!
|
|
//! Each test invokes `ail check --json <entry>` and asserts on the
|
|
//! diagnostic stream's `code` field. Stdout / runtime behaviour is
|
|
//! out of scope here — the dispatch path is a check-time concern.
|
|
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
|
|
fn ail_bin() -> PathBuf {
|
|
PathBuf::from(env!("CARGO_BIN_EXE_ail"))
|
|
}
|
|
|
|
fn examples_dir() -> PathBuf {
|
|
PathBuf::from(env!("CARGO_MANIFEST_DIR"))
|
|
.join("..")
|
|
.join("..")
|
|
.join("examples")
|
|
}
|
|
|
|
fn run_ail_check_json(entry: &str) -> std::process::Output {
|
|
Command::new(ail_bin())
|
|
.args(["check", "--json", examples_dir().join(entry).to_str().unwrap()])
|
|
.output()
|
|
.expect("ail binary must launch")
|
|
}
|
|
|
|
/// mq.3.6 (Trajectory C): bare `show 42` in a workspace with two
|
|
/// `Show` classes (modA and modB) each shipping `Show Int` is
|
|
/// genuinely ambiguous. `ail check` rejects with
|
|
/// `ambiguous-method-resolution` and names both candidate classes.
|
|
#[test]
|
|
fn mq3_two_show_ambiguous_fires_ambiguous_method_resolution() {
|
|
let out = run_ail_check_json("mq3_two_show_ambiguous.ail.json");
|
|
assert!(
|
|
!out.status.success(),
|
|
"expected check to reject ambiguous dispatch; stdout={} stderr={}",
|
|
String::from_utf8_lossy(&out.stdout),
|
|
String::from_utf8_lossy(&out.stderr),
|
|
);
|
|
let stdout = String::from_utf8(out.stdout).expect("stdout is utf-8");
|
|
let diags: serde_json::Value =
|
|
serde_json::from_str(&stdout).expect("--json mode emits a JSON array on stdout");
|
|
let arr = diags.as_array().expect("diagnostics is a JSON array");
|
|
assert!(
|
|
arr.iter().any(|d| d["code"] == "ambiguous-method-resolution"),
|
|
"expected `ambiguous-method-resolution` diagnostic; got {stdout}",
|
|
);
|
|
// Both candidate classes named in the diagnostic so the author
|
|
// knows which qualifiers to choose from.
|
|
assert!(
|
|
stdout.contains("mq3_two_show_ambiguous_a.Show"),
|
|
"expected candidate A in diagnostic; got {stdout}",
|
|
);
|
|
assert!(
|
|
stdout.contains("mq3_two_show_ambiguous_b.Show"),
|
|
"expected candidate B in diagnostic; got {stdout}",
|
|
);
|
|
}
|
|
|
|
/// mq.3.6 (Trajectory E): explicit qualifier
|
|
/// `mq3_two_show_ambiguous_a.Show.show 42` disambiguates the same
|
|
/// workspace as the ambiguous fixture. Typecheck succeeds.
|
|
#[test]
|
|
fn mq3_two_show_qualified_resolves_clean() {
|
|
let out = run_ail_check_json("mq3_two_show_qualified.ail.json");
|
|
assert!(
|
|
out.status.success(),
|
|
"expected check to succeed with explicit qualifier; stdout={} stderr={}",
|
|
String::from_utf8_lossy(&out.stdout),
|
|
String::from_utf8_lossy(&out.stderr),
|
|
);
|
|
}
|
|
|
|
/// mq.3.6 (class-fn shadow): bare `myeq 1 2` in a workspace with
|
|
/// `class MyEq { myeq }` in one module and `fn myeq` in another
|
|
/// resolves to the fn per lookup precedence. Typecheck succeeds AND
|
|
/// the structured warning `class-method-shadowed-by-fn` fires so the
|
|
/// LLM-author sees the shadow.
|
|
#[test]
|
|
fn mq3_class_eq_vs_fn_eq_fn_wins_with_warning() {
|
|
let out = run_ail_check_json("mq3_class_eq_vs_fn_eq.ail.json");
|
|
assert!(
|
|
out.status.success(),
|
|
"expected check to succeed (fn wins); stdout={} stderr={}",
|
|
String::from_utf8_lossy(&out.stdout),
|
|
String::from_utf8_lossy(&out.stderr),
|
|
);
|
|
let stdout = String::from_utf8(out.stdout).expect("stdout is utf-8");
|
|
let diags: serde_json::Value =
|
|
serde_json::from_str(&stdout).expect("--json mode emits a JSON array on stdout");
|
|
let arr = diags.as_array().expect("diagnostics is a JSON array");
|
|
assert!(
|
|
arr.iter().any(|d| d["code"] == "class-method-shadowed-by-fn"),
|
|
"expected `class-method-shadowed-by-fn` warning; got {stdout}",
|
|
);
|
|
}
|