76b21c00eb
Deletes `ParamMode::Implicit`. `ParamMode` is now `{Own, Borrow}`:
every fn-type slot on every signature carries an explicit `own` or
`borrow`, no defaulted position survives anywhere (model 0008 §2,
spec 0062). The parser rejects a bare fn-type slot; `borrow-return`
and `borrow-over-value` reject at the signature; the corpus is
migrated to minimal-ownership modes (consumed ⇒ own, read-only-heap
⇒ borrow, value ⇒ trivial-own). The documented `Implicit`-ret-mode
leak is fixed: an owned heap return now drops exactly once (live=0,
acceptance criterion 5).
This was the easy half. Removing the default ACTIVATED a family of
drop paths that `Implicit` had silently skipped — the pre-cutover
language was leaking (and in places mis-dropping) here rather than
crashing, because an Implicit scrutinee turned the drop off. Making
the modes explicit (Own) turned those paths on and exposed two
latent-bug clusters, all fixed RED-first as part of this cutover:
Drop-soundness family (four legs):
A. lit-sub-pattern double-free — the desugar re-matched the same
owned scrutinee in the lit fall-through; fixed by grouping
consecutive same-ctor arms into one match (bind fields once),
in ailang-core desugar.
B. Cons-husk leak on non-tail arm bodies — the lit-sub-pattern
desugar rebound the owned scrutinee via `Let $mp = xs`, which
bumped consume_count and suppressed the existing fn-return
partial_drop. Fixed by not rebinding a bare-Var scrutinee
(one husk-freeing mechanism, not two).
C. polymorphic `drop_<T>` rc_dec'd monomorphised value fields —
the per-ADT drop fn was emitted once from the polymorphic
TypeDef, defaulting type-var fields to ptr and rc_dec'ing
inline Ints (segfault). Fixed with per-monomorph drop
functions (new ailang-codegen::dropmono): the drop set is
collected from the lowered MIR, value-type fields are skipped,
heap fields still freed once; monomorphic-concrete ADTs keep
their byte-identical un-suffixed drop symbol.
D. static Str literal passed to an `(own Str)` param — the
literal lowers to a header-less rodata constant; the callee's
now-active rc_dec read its length field as a refcount and
freed a static address (segfault). Fixed with the missing
fourth StrRep::Static→Heap promotion in lower_to_mir's App arm,
gated on Own mode (borrow args stay static, no regression).
over-strict-mode lint over-fired: it suggested `(borrow V)` for
value-typed params (which `borrow-over-value` rejects — own is the
only legal mode there) and fired on `(intrinsic)` bodies (whose
consumption the linearity walk cannot observe). Tightened to skip
both; contract 0008 updated to the narrowed firing scope.
Irreversible step — canonical-form hash reset (model 0008 §6,
acceptance criterion 6). Every signature now carries explicit modes,
so the hashable canonical JSON changed for every module. RATIFY:
the corpus-wide hash-pin reset (hash_pin, prelude_module_hash_pin,
mono_hash_stability, eq_ord_e2e, embed_export_hash_stable, the
ct4/iter*/loop_recur schema-extension pins) and the list ir_snapshot
golden were regenerated once, deliberately, as the intended one-time
consequence of removing the mode elision from the canonical form —
not a regression. Each regenerated hash verified deterministic across
two runs.
Also fixes a pre-existing latent failure surfaced by the verification
gate, unrelated to this cutover: the `every_contract_names_a_resolvable_
ratifying_test` resolver (design_index_pin) could not resolve the
" + " dual-link ratifying-test form (`uniqueness.rs + linearity.rs`)
that the #57 audit-close (dfdc65f) introduced — it shipped red on that
commit. Resolver taught the dual-link form, mirroring its sibling.
Verification: cargo test --workspace = 731 passed, 0 failed (twice,
stable); e2e 102 passed, no binary exits non-zero (corpus crash-free);
grep-clean for Implicit/fn_implicit/mode_eq across crates; every drop
fix confirmed via emitted IR + AILANG_RC_STATS balance on the head==K,
head!=K, and Nil paths. Three BLOCKEDs en route (the unsound first
husk-dec attempt, the over-strict derivation premise, the leg-B fix
direction) were each treated as a real design/spec gap and rediagnosed,
not patched over.
Supersedes #54 (return-position-only leak patch). Precondition #57
(linearity hardening) was already met. Spec docs/specs/0062, plan
docs/plans/0121.
closes #55
123 lines
5.1 KiB
Rust
123 lines
5.1 KiB
Rust
//! RED-pin for leg (C) of the drop-soundness bug family the
|
|
//! Implicit-cutover (#55) surfaced: a polymorphic ctor's per-type
|
|
//! drop fn rc_dec's a type-parameter field even when the field is
|
|
//! monomorphised at a value type (Int/Bool/Float/Unit).
|
|
//!
|
|
//! Property protected: under `--alloc=rc`, dropping a value of a
|
|
//! polymorphic ADT whose ctor field is monomorphised at a value type
|
|
//! must NOT emit `ailang_rc_dec` on that field. The field is stored
|
|
//! inline as a raw scalar (an i64 `7`, not a heap pointer), so an
|
|
//! `rc_dec` dereferences the scalar-as-pointer and crashes. The
|
|
//! binary must run to completion, print the inner value, and the
|
|
//! runtime RC stats line must report `live == 0` (the single ADT
|
|
//! slab is freed exactly once, with no spurious dec of the inline
|
|
//! value field).
|
|
//!
|
|
//! Root cause: `crates/ailang-codegen/src/drop.rs`
|
|
//! `emit_drop_fn_for_type` (mirrored in `emit_iterative_drop_fn_for_type`
|
|
//! and `emit_partial_drop_fn_for_type`) emits the per-type drop fn ONCE
|
|
//! from the polymorphic `Def::Type` declaration — never per-monomorph.
|
|
//! For each ctor field it computes `llvm_type(fty)` where `fty` is the
|
|
//! declared field type. For a type-parameter field that type is a
|
|
//! `Type::Var`, which `llvm_type` rejects (synth.rs returns `Err`); the
|
|
//! `.unwrap_or_else(|_| "ptr".into())` at the field loop then silently
|
|
//! treats the var-typed field as a boxed pointer and emits `rc_dec`.
|
|
//! At the `Box Int` monomorph the field is an inline `i64`, so the
|
|
//! emitted `rc_dec` dereferences the integer value -> SIGSEGV.
|
|
//!
|
|
//! As of HEAD (the in-flight Implicit cutover) this test fails: the
|
|
//! binary exits 139 (SIGSEGV) before printing anything. Pre-cutover
|
|
//! the bug was latent — Implicit scrutinees skipped the drop path
|
|
//! entirely, so the mistyped drop never ran (it leaked instead of
|
|
//! crashing).
|
|
//!
|
|
//! A single-field `Box a` at `Int` is the minimal trigger. The fix
|
|
//! must still dec genuinely-heap fields (e.g. a `Box Str` field must
|
|
//! free its slab exactly once) and must hold for the partial-drop and
|
|
//! nested-monomorph variants — see the debugger handoff for the fix
|
|
//! locus and soundness reasoning.
|
|
|
|
use std::path::Path;
|
|
use std::process::Command;
|
|
|
|
fn ail_bin() -> &'static str {
|
|
env!("CARGO_BIN_EXE_ail")
|
|
}
|
|
|
|
#[test]
|
|
fn alloc_rc_value_type_field_is_not_rc_dec_dropped() {
|
|
let manifest_dir = env!("CARGO_MANIFEST_DIR");
|
|
let workspace = Path::new(manifest_dir).parent().unwrap().parent().unwrap();
|
|
let src = workspace
|
|
.join("examples")
|
|
.join("drop_value_field_no_segfault_pin.ail");
|
|
let tmp = std::env::temp_dir().join(format!(
|
|
"ailang_drop_value_field_no_segfault_pin_{}",
|
|
std::process::id()
|
|
));
|
|
std::fs::create_dir_all(&tmp).unwrap();
|
|
let out = tmp.join("bin");
|
|
let status = Command::new(ail_bin())
|
|
.args(["build", src.to_str().unwrap(), "--alloc=rc", "-o"])
|
|
.arg(&out)
|
|
.status()
|
|
.expect("ail build failed to run");
|
|
assert!(
|
|
status.success(),
|
|
"ail build --alloc=rc failed for drop_value_field_no_segfault_pin.ail"
|
|
);
|
|
let output = Command::new(&out)
|
|
.env("AILANG_RC_STATS", "1")
|
|
.output()
|
|
.expect("execute binary");
|
|
assert!(
|
|
output.status.success(),
|
|
"binary exited non-zero (status {:?}): the polymorphic drop fn \
|
|
drop_<m>_Box rc_dec's the type-parameter field, which at the \
|
|
Box Int monomorph is the inline i64 `7` (not a heap pointer), \
|
|
so rc_dec(7) dereferences the scalar-as-pointer and SIGSEGVs. \
|
|
Fix in crates/ailang-codegen/src/drop.rs: do not dec a field \
|
|
whose monomorphised type is a value type.",
|
|
output.status
|
|
);
|
|
let stdout = String::from_utf8(output.stdout).expect("stdout utf8");
|
|
assert_eq!(
|
|
stdout.trim_end(),
|
|
"7",
|
|
"unboxing MkBox 7 at Int must print 7; got {stdout:?}"
|
|
);
|
|
let stderr = String::from_utf8(output.stderr).expect("stderr utf8");
|
|
let stats_line = stderr
|
|
.lines()
|
|
.find(|l| l.starts_with("ailang_rc_stats:"))
|
|
.unwrap_or_else(|| {
|
|
panic!("missing ailang_rc_stats line in stderr; stderr was:\n{stderr}")
|
|
});
|
|
let mut allocs: Option<u64> = None;
|
|
let mut frees: Option<u64> = None;
|
|
let mut live: Option<i64> = None;
|
|
for tok in stats_line.split_whitespace() {
|
|
if let Some(v) = tok.strip_prefix("allocs=") {
|
|
allocs = v.parse().ok();
|
|
} else if let Some(v) = tok.strip_prefix("frees=") {
|
|
frees = v.parse().ok();
|
|
} else if let Some(v) = tok.strip_prefix("live=") {
|
|
live = v.parse().ok();
|
|
}
|
|
}
|
|
let allocs = allocs.expect("missing allocs= field");
|
|
let frees = frees.expect("missing frees= field");
|
|
let live = live.expect("missing live= field");
|
|
assert_eq!(
|
|
live, 0,
|
|
"RC imbalance after dropping a value-type-field ADT \
|
|
(allocs={allocs} frees={frees} live={live}); the Box slab \
|
|
must be freed exactly once and the inline Int field must \
|
|
never be dec'd."
|
|
);
|
|
assert_eq!(
|
|
allocs, frees,
|
|
"alloc/free mismatch (allocs={allocs} frees={frees} live={live})"
|
|
);
|
|
}
|