Brummel/Aura
1
0
Fork 0
Code Issues 31 Pull Requests Actions Packages Projects Releases Wiki Activity

stage1-r harness polish: dedicated broker label + avoid per-field col[i] leak #132

New Issue
Closed
opened 2026-06-24 12:34:33 +02:00 by Brummel · 0 comments
Brummel commented 2026-06-24 12:34:33 +02:00
Owner
Copy Link
Copy Source

Two cosmetic smells the cycle-0065 close audit flagged (neither a correctness issue):

  1. Broker label. run_stage1_r reuses sim_optimal_manifest, so the RunReport manifest records broker: "sim-optimal(pip_size=…)" for a harness that runs a RiskExecutor branch. A dedicated label (e.g. "risk-executor" or "sim-optimal+risk-executor") would read more honestly for the dual-tap harness.
  2. col[i] leak. stage1_r_blueprint does format!("col[{i}]").leak() per PositionManagement field (14 strings) to satisfy the &'static str port-name API — harmless for a CLI one-shot, but a leak-per-build smell if the harness is ever reused in a sweep / Monte-Carlo loop. Revisit when R-sweep families land.
Two cosmetic smells the cycle-0065 close audit flagged (neither a correctness issue): 1. **Broker label.** `run_stage1_r` reuses `sim_optimal_manifest`, so the RunReport manifest records `broker: "sim-optimal(pip_size=…)"` for a harness that runs a RiskExecutor branch. A dedicated label (e.g. `"risk-executor"` or `"sim-optimal+risk-executor"`) would read more honestly for the dual-tap harness. 2. **`col[i]` leak.** `stage1_r_blueprint` does `format!("col[{i}]").leak()` per PositionManagement field (14 strings) to satisfy the `&'static str` port-name API — harmless for a CLI one-shot, but a leak-per-build smell if the harness is ever reused in a sweep / Monte-Carlo loop. Revisit when R-sweep families land.
Brummel added the idea label 2026-06-24 12:34:33 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BLOCKER
Core functionality blocked; preempts other selection
 bug
Observable misbehaviour
 feature
Substantial extension; no full spec required
 idea
Droppable; no commitment
No Label idea
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude (Claude) Brummel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Brummel/Aura#132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?