Re-derive the stop regime from the member manifest in reproduce (currently hardcoded to the default) #233

New Issue

2026-07-10T17:15:06+02:00

Brummel commented

2026-07-10 17:15:06 +02:00

reproduce re-runs every family member under the default stop regime: both the param-space probe and the member re-run hardcode StopRule::Vol { length: R_SMA_STOP_LENGTH, k: R_SMA_STOP_K } (crates/aura-cli/src/main.rs:1096 and 1156). Member manifests do record the actual stop (stop_length/stop_k stamped at main.rs:1425-1428), but the reproduce path never reads them back — the stop knobs ride outside the wrapped param space (main.rs:806), so point_from_params cannot recover them either.

Claim (unverified, no covering test): a family minted under a non-default regime — a campaign risk-regime cell, or walkforward/mc/generalize with --stop-length/--stop-k (#217) — re-runs under Vol{3, 2.0} and reports DIVERGED. The existing regime e2e covers campaign-run stamping only, not reproduce.

Same defect shape as #229 (reproduce ignored the manifest's data source until it was re-derived from the member manifest): a manifest-recorded dimension not threaded through re-derivation.

RED reproduction: mint a family under a non-default stop regime, reproduce it
reproduce re-derives the stop rule from the member manifest

`reproduce` re-runs every family member under the default stop regime: both the param-space probe and the member re-run hardcode `StopRule::Vol { length: R_SMA_STOP_LENGTH, k: R_SMA_STOP_K }` (crates/aura-cli/src/main.rs:1096 and 1156). Member manifests do record the actual stop (`stop_length`/`stop_k` stamped at main.rs:1425-1428), but the reproduce path never reads them back — the stop knobs ride outside the wrapped param space (main.rs:806), so `point_from_params` cannot recover them either. Claim (unverified, no covering test): a family minted under a non-default regime — a campaign risk-regime cell, or walkforward/mc/generalize with --stop-length/--stop-k (#217) — re-runs under Vol{3, 2.0} and reports DIVERGED. The existing regime e2e covers campaign-run stamping only, not reproduce. Same defect shape as #229 (reproduce ignored the manifest's data source until it was re-derived from the member manifest): a manifest-recorded dimension not threaded through re-derivation. - [ ] RED reproduction: mint a family under a non-default stop regime, reproduce it - [ ] reproduce re-derives the stop rule from the member manifest

Brummel added this to the Real-project readiness — role-complete research loop (no freeze) milestone 2026-07-10 17:15:06 +02:00

Brummel added the bug label 2026-07-10 17:15:06 +02:00

Brummel referenced this issue

2026-07-10 17:16:35 +02:00

Bind strategy input roles to sources as authorable data — retire wrap_r's single-price weld (C20/C24) #231

Brummel commented

2026-07-10 18:53:14 +02:00

The unverified claim in the issue body is now verified: a member minted under StopRule::Vol { length: 8, k: 4.0 } re-runs under the default Vol{3, 2.0} and reports a spurious DIVERGED — pinned by the RED test reproduce_re_derives_the_member_stop_regime_not_the_default (a closed blueprint isolates the stop as the only dimension that can differ between mint and reproduce).

Landed as ab14eee (RED) + fb145f5 (GREEN): a new stop_rule_from_params re-derives the StopRule from the manifest's stamped stop_length/stop_k, computed once per member and used at both the param-space probe and the member re-run. When the manifest carries no stop keys (members persisted before the stamp existed), it falls back to the default regime — the same one-directional widening point_from_params already applies to missing manifest params, mirroring stop_rule_for_regime's no-regime arm in campaign_run.rs. Both acceptance boxes are met on the branch. Closes via commit on merge.

The unverified claim in the issue body is now verified: a member minted under `StopRule::Vol { length: 8, k: 4.0 }` re-runs under the default `Vol{3, 2.0}` and reports a spurious DIVERGED — pinned by the RED test `reproduce_re_derives_the_member_stop_regime_not_the_default` (a closed blueprint isolates the stop as the only dimension that can differ between mint and reproduce). Landed as ab14eee (RED) + fb145f5 (GREEN): a new `stop_rule_from_params` re-derives the `StopRule` from the manifest's stamped `stop_length`/`stop_k`, computed once per member and used at both the param-space probe and the member re-run. When the manifest carries no stop keys (members persisted before the stamp existed), it falls back to the default regime — the same one-directional widening `point_from_params` already applies to missing manifest params, mirroring `stop_rule_for_regime`'s no-regime arm in campaign_run.rs. Both acceptance boxes are met on the branch. Closes via commit on merge.

Brummel referenced this issue

2026-07-11 12:28:35 +02:00

Deliver net-R on the family/campaign path — the cost graph lost its last production caller in #221 #234

Brummel referenced this issue from a commit

2026-07-11 15:18:17 +02:00

test(cli): RED — reproduce re-runs members under the default stop regime

Brummel referenced this issue from a commit

2026-07-11 15:18:17 +02:00

fix(cli): reproduce re-derives the stop regime from the member manifest

Brummel closed this issue

2026-07-11 15:18:17 +02:00

Brummel referenced this issue from a commit