Resolve a relative paths.data against the project root, matching paths.runs and [nodes] pointers #254

New Issue

2026-07-13T15:22:49+02:00

claude commented

2026-07-13 15:22:49 +02:00

Env::data_path() hands paths.data to the data layer verbatim: it returns p.toml.paths.data.clone() as a String (crates/aura-cli/src/project.rs:187-192 at bd174d1), which flows into DataServer::new unchanged. The sibling path keys resolve against the project root: runs_root() is p.root.join(runs) (project.rs:167-175), and a [nodes].crates pointer is root.join(pointer) (project.rs:497, absolute pointers passing through).

Consequence: a relative data = "data" in Aura.toml resolves against the invoking process's cwd, not the project root — aura run from the project root and from a project subdirectory silently read different archive locations, while runs/ stays anchored correctly in both. An absolute paths.data is unaffected.

Found while wiring the per-test synthetic archive for #250 (the E2E helper works around it by always invoking with cwd = project root; see the note in crates/aura-cli/tests/common/mod.rs's write_project_files doc).

Claim (unverified): no current test or documented flow invokes aura from a project subdirectory with a relative paths.data, so the misresolution is latent rather than observed. A fix is one join at the single choke point: data_path() joining relative values onto p.root, mirroring runs_root().

`Env::data_path()` hands `paths.data` to the data layer verbatim: it returns `p.toml.paths.data.clone()` as a `String` (crates/aura-cli/src/project.rs:187-192 at `bd174d1`), which flows into `DataServer::new` unchanged. The sibling path keys resolve against the project root: `runs_root()` is `p.root.join(runs)` (project.rs:167-175), and a `[nodes].crates` pointer is `root.join(pointer)` (project.rs:497, absolute pointers passing through). Consequence: a **relative** `data = "data"` in `Aura.toml` resolves against the *invoking process's cwd*, not the project root — `aura run` from the project root and from a project subdirectory silently read different archive locations, while `runs/` stays anchored correctly in both. An absolute `paths.data` is unaffected. Found while wiring the per-test synthetic archive for #250 (the E2E helper works around it by always invoking with cwd = project root; see the note in `crates/aura-cli/tests/common/mod.rs`'s `write_project_files` doc). Claim (unverified): no current test or documented flow invokes `aura` from a project subdirectory with a relative `paths.data`, so the misresolution is latent rather than observed. A fix is one join at the single choke point: `data_path()` joining relative values onto `p.root`, mirroring `runs_root()`.

~~claude referenced this issue 2026-07-13 15:24:41 +02:00~~

Cut the E2E suite wall-clock: 247s -> 46s (cli_run 211s -> 25s) #255

claude referenced this issue

2026-07-13 15:25:43 +02:00

Cut the cli_run E2E wall-clock: unshare the serialized demo-project fixture store #250

Brummel referenced this issue from a commit

2026-07-13 16:35:21 +02:00

fix(cli): resolve a relative paths.data against the project root

claude referenced a pull request that will close this issue

2026-07-13 16:36:08 +02:00

Cut the E2E suite wall-clock: 247s -> 46s (cli_run 211s -> 25s) #255

claude referenced this issue