Centralize runnable GER40 examples through instrument_spec (deferred from #22) #98

Closed
opened 2026-06-18 18:57:27 +02:00 by Brummel · 0 comments
Owner

Deferred from #22 (per-instrument pip). The CLI aura run --real path now sources
pip from aura_ingest::instrument_spec(symbol) (a typed vetted lookup). The runnable
GER40 examples still bake a const PIP_SIZE = 1.0 literal.

This is a consistency cleanup, not a bug fix: GER40/FRA40 quote in index points,
so 1.0 is the correct pip — the examples are honest today, just not routed through
the central metadata channel.

Centralize them: give ger40_breakout_blueprint a pip_size parameter (it bakes
SimBroker::builder(PIP_SIZE) at breakout_real.rs:252), source build_harness and
ger40_breakout_compare pip from instrument_spec, drop const PIP_SIZE. The
blueprint signature change propagates to ~14 call sites across 6 files —
examples/{ger40_breakout_real,sweep,walkforward,compare}.rs and
tests/{ger40_breakout_blueprint,ger40_breakout_world}.rs (the last has a
broker: "sim-optimal(pip_size=1)" pin at :64). All GER40/FRA40 callers pass the
looked-up 1.0, so the change is value-identical and behaviour-preserving (gated
determinism + blueprint param-space tests stay green).

depends on: #22 (instrument_spec / InstrumentSpec land there)
context: split out so #22 ships the actual CLI-path bug fix without an example-wide
signature refactor; spec-skeptic round-2 flagged the examples as a separable scope.

Deferred from #22 (per-instrument pip). The CLI `aura run --real` path now sources pip from `aura_ingest::instrument_spec(symbol)` (a typed vetted lookup). The runnable GER40 examples still bake a `const PIP_SIZE = 1.0` literal. This is a **consistency cleanup, not a bug fix**: GER40/FRA40 quote in index points, so `1.0` is the *correct* pip — the examples are honest today, just not routed through the central metadata channel. Centralize them: give `ger40_breakout_blueprint` a `pip_size` parameter (it bakes `SimBroker::builder(PIP_SIZE)` at breakout_real.rs:252), source `build_harness` and `ger40_breakout_compare` pip from `instrument_spec`, drop `const PIP_SIZE`. The blueprint signature change propagates to ~14 call sites across 6 files — examples/{ger40_breakout_real,sweep,walkforward,compare}.rs and tests/{ger40_breakout_blueprint,ger40_breakout_world}.rs (the last has a `broker: "sim-optimal(pip_size=1)"` pin at :64). All GER40/FRA40 callers pass the looked-up `1.0`, so the change is value-identical and behaviour-preserving (gated determinism + blueprint param-space tests stay green). depends on: #22 (instrument_spec / InstrumentSpec land there) context: split out so #22 ships the actual CLI-path bug fix without an example-wide signature refactor; spec-skeptic round-2 flagged the examples as a separable scope.
Brummel added the idea label 2026-06-18 18:57:27 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Brummel/Aura#98