claude
dc5f1742f4
In-cycle fixes for the independent review of the #319 package, RED-first for both Importants. A repeated --override path now refuses at the shared lexer (exit 2, path named) instead of panicking exit 101 through reopen_all — which also un-misattributes the campaign leg's collision prose for duplicates. override_paths' refusal points at aura graph introspect --params (the retired --list-axes reference swept from every live comment, one explicitly-historical mention remains). exec classifies file targets through a Result-bearing peek: unparseable JSON refuses neutrally before any leg is chosen. RunPresentation (single-variant) removed; run_campaign_returning's contract note names its one deliberate usage-class exit; C14's routing sentence and C20's family-builder paragraph amended to current truth (superseded text to the history sidecars); bench error strings and deletion blank-line runs tidied. refs #319
aura-bench
Wall-clock benchmarks with committed baselines (issue #251, phase 1). Catches hot-path regressions the E2E suite structurally cannot see: every surface pins its inputs and asserts a determinism fingerprint, so a fast-but-wrong binary fails the bench instead of pinning a bogus baseline.
Running
cargo run --release -p aura-bench -- run # measure + compare, report-only
cargo run --release -p aura-bench -- run --surface engine_throughput
cargo run --release -p aura-bench -- pin # rewrite committed baselines
Debug builds refuse to measure (exit 2) — wall-clock numbers from a debug build measure the profile, not the code.
Surfaces
| surface | workload | metrics |
|---|---|---|
engine_throughput |
10M synthetic bars through an SMA-cross harness (library) | wall_s, bars_per_s |
ingest_throughput |
24 synthetic archive months x 20 fresh drains via the ingest window API (library) | wall_s, bars_per_s |
campaign_sweep |
8-cell sweep-only campaign, release aura binary on a scratch project |
wall_s, cpu_percent, peak_rss_mb |
campaign_heavy |
same cells; sweep → gate → walk-forward → 1000-resample bootstrap | wall_s, cpu_percent, peak_rss_mb |
cli_fixed_cost |
spawn floor (aura --help) + minimal data-only project run |
help_ms, run_ms |
Discipline
- Quiet box: the driver warns at 1-min loadavg > 2.0. Close heavy jobs first.
- 1 discarded warmup + 3 measured reps (median). Reps must agree on the fingerprint — cross-rep drift is reported as nondeterminism, not averaged.
- Baselines are per-host context (
hostblock inside each JSON): comparison on a different host prints an informational banner and stays report-only. - Timing drift NEVER fails the run (report-only phase, #251 cadence decision); a NOTICE line flags drift >= 10%. A fingerprint mismatch exits 1.
- Re-pin (
pin) deliberately, after an accepted behaviour or performance change; the baseline diff is reviewed like any other commit.
Deferred (follow-up on the tracker)
- Instruction-count backend (iai-callgrind) once valgrind is installed on the measuring host — slots in as a sibling backend without reshaping baselines.
- Native-crate project-load sub-cost (dylib SHA-256) — needs a build step in the scratch project.
- Thresholded failure, once recorded variance data justifies thresholds.