claude
1476990cfd
Architect review over 9cfe296..dc5f174 (drift_found -> all five items fixed in this close): C24's family-machinery sentence re-amended to current truth (synthetic walks are reproduce-only inputs since the builder retirement; superseded text to the sidecar); the ported generalize test's doc no longer promises the retired CrossInstrument family handle and its stale section header is gone; FamilyKind::CrossInstrument carries its C18 dead-machinery/read-back note in code; live comments in campaign_run, bench surfaces, and graph_construct name exec instead of the retired verbs; the five inlined topology_hash copies in the bin test module consolidated into one test helper. What holds, per the architect: C24<->code gated-intake lockstep exact, C12's single-hash claim true in code, exec dispatch matches C14's amended text. Bench (regression gate) exit 0, all five fingerprints OK: engine_throughput bars_per_s 14014049 (+0.1%), ingest_throughput 12935441 (-0.5%), campaign_sweep wall 1.407s (+0.9%), campaign_heavy wall 5.688s (+2.1%), cli_fixed_cost run_ms 3.6 (+6.6%, spawn-floor jitter under parallel-agent load, report-only). No baseline moved. Also rides: the reviewer re-check's two comment nits (classify-once wording, SIGPIPE example verb). refs #319
aura-bench
Wall-clock benchmarks with committed baselines (issue #251, phase 1). Catches hot-path regressions the E2E suite structurally cannot see: every surface pins its inputs and asserts a determinism fingerprint, so a fast-but-wrong binary fails the bench instead of pinning a bogus baseline.
Running
cargo run --release -p aura-bench -- run # measure + compare, report-only
cargo run --release -p aura-bench -- run --surface engine_throughput
cargo run --release -p aura-bench -- pin # rewrite committed baselines
Debug builds refuse to measure (exit 2) — wall-clock numbers from a debug build measure the profile, not the code.
Surfaces
| surface | workload | metrics |
|---|---|---|
engine_throughput |
10M synthetic bars through an SMA-cross harness (library) | wall_s, bars_per_s |
ingest_throughput |
24 synthetic archive months x 20 fresh drains via the ingest window API (library) | wall_s, bars_per_s |
campaign_sweep |
8-cell sweep-only campaign, release aura binary on a scratch project |
wall_s, cpu_percent, peak_rss_mb |
campaign_heavy |
same cells; sweep → gate → walk-forward → 1000-resample bootstrap | wall_s, cpu_percent, peak_rss_mb |
cli_fixed_cost |
spawn floor (aura --help) + minimal data-only project run |
help_ms, run_ms |
Discipline
- Quiet box: the driver warns at 1-min loadavg > 2.0. Close heavy jobs first.
- 1 discarded warmup + 3 measured reps (median). Reps must agree on the fingerprint — cross-rep drift is reported as nondeterminism, not averaged.
- Baselines are per-host context (
hostblock inside each JSON): comparison on a different host prints an informational banner and stays report-only. - Timing drift NEVER fails the run (report-only phase, #251 cadence decision); a NOTICE line flags drift >= 10%. A fingerprint mismatch exits 1.
- Re-pin (
pin) deliberately, after an accepted behaviour or performance change; the baseline diff is reviewed like any other commit.
Deferred (follow-up on the tracker)
- Instruction-count backend (iai-callgrind) once valgrind is installed on the measuring host — slots in as a sibling backend without reshaping baselines.
- Native-crate project-load sub-cost (dylib SHA-256) — needs a build step in the scratch project.
- Thresholded failure, once recorded variance data justifies thresholds.