diff --git a/Src/Myc.Core.Atomic.pas b/Src/Myc.Core.Atomic.pas index 348572c..7a02aa8 100644 --- a/Src/Myc.Core.Atomic.pas +++ b/Src/Myc.Core.Atomic.pas @@ -4,9 +4,9 @@ interface {$align on} uses - {$ifndef NO_FASTMM} +{$ifndef NO_FASTMM} FastMM5, - {$endif} +{$endif} Winapi.Windows; type @@ -33,15 +33,16 @@ type end; TMycAtomicStack = record - private type - PItem = ^TItem; - TItem = packed record - Next: TSListEntry; - Data: T; - end; + private + type + PItem = ^TItem; + TItem = packed record + Next: TSListEntry; + Data: T; + end; - var - FSList: PSList; + var + FSList: PSList; public // Initializes the atomic stack, creating the underlying SList. @@ -212,7 +213,7 @@ begin begin item.Data := Default(T); FreeMemAligned(item); // Global procedure - item := PopPtr; // Call instance method PopPtr via Dest + item := PopPtr; // Call instance method PopPtr via Dest end; end; diff --git a/Src/Myc.Core.Futures.pas b/Src/Myc.Core.Futures.pas index ad3f31c..59a88d3 100644 --- a/Src/Myc.Core.Futures.pas +++ b/Src/Myc.Core.Futures.pas @@ -4,22 +4,24 @@ interface uses System.SysUtils, - Myc.Signals, Myc.TaskManager, Myc.Futures; + Myc.Signals, + Myc.TaskManager, + Myc.Futures; type - TMycFuture = class abstract( TInterfacedObject, IMycFuture ) + TMycFuture = class abstract(TInterfacedObject, IMycFuture) protected function GetResult: T; virtual; abstract; function GetDone: TState; virtual; abstract; end; - TMycNullFuture = class( TMycFuture ) + TMycNullFuture = class(TMycFuture) protected function GetResult: T; override; function GetDone: TState; override; end; - TMycGateFuncFuture = class( TMycFuture ) + TMycGateFuncFuture = class(TMycFuture) private FInit: TState.TSubscription; FDone: IMycLatch; @@ -28,7 +30,7 @@ type function GetResult: T; override; function GetDone: TState; override; public - constructor Create( const ATaskManager: IMycTaskManager; const AGate: IMycState; AProc: TFunc ); + constructor Create(const ATaskManager: IMycTaskManager; const AGate: IMycState; AProc: TFunc); destructor Destroy; override; end; @@ -43,39 +45,41 @@ end; function TMycNullFuture.GetResult: T; begin - Result := Default ( T ); + Result := Default(T); end; { TMycGateFuncFuture } -constructor TMycGateFuncFuture.Create( const ATaskManager: IMycTaskManager; const AGate: IMycState; AProc: TFunc ); +constructor TMycGateFuncFuture.Create(const ATaskManager: IMycTaskManager; const AGate: IMycState; AProc: TFunc); begin inherited Create; - FDone := TLatch.Construct( 1 ); + FDone := TLatch.Construct(1); // Subscribe the job execution to AGate. // The job will run when AGate notifies the subscriber returned by Run. - FInit := ATaskManager.CreateTask( - AGate, - procedure - begin - try - try - Self.FResult := AProc( ); - except - Self.FResult := Default ( T ); // Set result to Default(T) on error - raise; // Re-raise for TaskFactory to handle - end; - finally - Self.FDone.Notify; // Signal that this future is done (successfully or with error) - end; - end ); + FInit := + ATaskManager.CreateTask( + AGate, + procedure + begin + try + try + Self.FResult := AProc(); + except + Self.FResult := Default(T); // Set result to Default(T) on error + raise; // Re-raise for TaskFactory to handle + end; + finally + Self.FDone.Notify; // Signal that this future is done (successfully or with error) + end; + end + ); end; destructor TMycGateFuncFuture.Destroy; begin - Assert( FDone.State.IsSet ); + Assert(FDone.State.IsSet); FInit.Unsubscribe; inherited Destroy; @@ -88,7 +92,7 @@ end; function TMycGateFuncFuture.GetResult: T; begin - Assert( FDone.State.IsSet, 'Result is not yet available.' ); + Assert(FDone.State.IsSet, 'Result is not yet available.'); Result := FResult; end; diff --git a/Src/Myc.Core.Lazy.pas b/Src/Myc.Core.Lazy.pas index b1d8504..cf35491 100644 --- a/Src/Myc.Core.Lazy.pas +++ b/Src/Myc.Core.Lazy.pas @@ -8,21 +8,21 @@ uses Myc.Lazy; type - TMycLazy = class abstract( TInterfacedObject, IMycLazy ) + TMycLazy = class abstract(TInterfacedObject, IMycLazy) protected function GetChanged: IMycState; virtual; abstract; public - function Pop( out Res: T ): Boolean; virtual; abstract; + function Pop(out Res: T): Boolean; virtual; abstract; end; - TMycNullLazy = class( TMycLazy ) + TMycNullLazy = class(TMycLazy) protected function GetChanged: IMycState; override; public - function Pop( out Res: T ): Boolean; override; + function Pop(out Res: T): Boolean; override; end; - TMycFuncLazy = class( TMycLazy ) + TMycFuncLazy = class(TMycLazy) private FChanged: IMycDirty; FChangeState: TState.TSubscription; @@ -32,7 +32,7 @@ type public constructor Create(const AChanged: TState; const AProc: TFunc); destructor Destroy; override; - function Pop( out Res: T ): Boolean; override; + function Pop(out Res: T): Boolean; override; end; implementation @@ -44,9 +44,9 @@ begin Result := TState.Null; end; -function TMycNullLazy.Pop( out Res: T ): Boolean; +function TMycNullLazy.Pop(out Res: T): Boolean; begin - Res := Default ( T ); + Res := Default(T); Result := true; end; @@ -57,7 +57,7 @@ begin inherited Create; FChanged := TDirty.Construct; FProc := AProc; - FChangeState := AChanged.Subscribe( FChanged ); + FChangeState := AChanged.Subscribe(FChanged); end; destructor TMycFuncLazy.Destroy; @@ -71,12 +71,12 @@ begin Result := FChanged.State; end; -function TMycFuncLazy.Pop( out Res: T ): Boolean; +function TMycFuncLazy.Pop(out Res: T): Boolean; begin Result := FChanged.State.IsSet; if Result then begin - if Assigned( FProc ) then + if Assigned(FProc) then Res := FProc; FChanged.Reset; end; diff --git a/Src/Myc.Core.Notifier.pas b/Src/Myc.Core.Notifier.pas index aacf31c..f82b5a9 100644 --- a/Src/Myc.Core.Notifier.pas +++ b/Src/Myc.Core.Notifier.pas @@ -3,7 +3,8 @@ unit Myc.Core.Notifier; interface uses - System.SysUtils, System.SyncObjs; + System.SysUtils, + System.SyncObjs; type // Low-level implementation for thread-safe multicast events. @@ -13,35 +14,37 @@ type // `UnadviseAll` removes all registered interfaces. // After `Finalize` is called, the list is cleared, and no new interfaces can be added (closed state). TMycNotifyList = record - type - TTag = Pointer; // Opaque tag used to identify a registered receiver for unsubscription. + type + TTag = Pointer; // Opaque tag used to identify a registered receiver for unsubscription. - PItem = ^TItem; // Pointer to an internal list item. - TItem = record // Internal structure for storing a receiver and list linkage. - Next, Prev: PItem; // Pointers to the next and previous items in the doubly linked list. - Receiver: T; // The registered interface instance (the event sink). - end; + PItem = ^TItem; // Pointer to an internal list item. + TItem = record // Internal structure for storing a receiver and list linkage. + Next, Prev: PItem; // Pointers to the next and previous items in the doubly linked list. + Receiver: T; // The registered interface instance (the event sink). + end; strict private FFirst: NativeUInt; // Stores the first receiver if no list is allocated, or acts as a combined lock and state field. - // Bit 0: Lock state (0 = locked, 1 = unlocked). - // Bit 1: Finalized state (0 = not finalized, 1 = finalized). - // Other bits (if not 0 and bit 0 is 1) can be a direct interface pointer if FList is nil. - FList: PItem; // Head of the linked list for additional receivers beyond the first one. + // Bit 0: Lock state (0 = locked, 1 = unlocked). + // Bit 1: Finalized state (0 = not finalized, 1 = finalized). + // Other bits (if not 0 and bit 0 is 1) can be a direct interface pointer if FList is nil. + FList: PItem; // Head of the linked list for additional receivers beyond the first one. - class function AllocItem: PItem; static; inline; // Allocates and initializes memory for a new TItem. - class procedure FreeItem( Item: PItem ); static; inline; // Frees memory previously allocated for a TItem. + class function AllocItem: PItem; static; inline; // Allocates and initializes memory for a new TItem. + class procedure FreeItem(Item: PItem); static; inline; // Frees memory previously allocated for a TItem. public - procedure Create; // Initializes the notification list, preparing it for use. - procedure Destroy; // Cleans up all resources, including unadvising all receivers. Assumes no concurrent access. + procedure Create; // Initializes the notification list, preparing it for use. + procedure Destroy; // Cleans up all resources, including unadvising all receivers. Assumes no concurrent access. function Advise(const Receiver: T): TTag; // Registers a receiver interface and returns an opaque tag for later unsubscription. procedure Unadvise(Tag: TTag); // Unregisters a specific receiver using the tag obtained from Advise. - procedure UnadviseAll; // Unregisters all currently advised receivers. - procedure Lock; inline; // Acquires an exclusive lock for thread-safe operations on the list. - procedure Release; inline;// Releases the previously acquired exclusive lock. + procedure UnadviseAll; // Unregisters all currently advised receivers. + procedure Lock; inline; // Acquires an exclusive lock for thread-safe operations on the list. + procedure Release; inline; // Releases the previously acquired exclusive lock. function IsLocked: Boolean; inline; // Checks if the list is currently locked by any thread. - procedure Notify(Func: TPredicate); // Iterates through registered receivers and invokes the predicate; removes receiver if predicate returns false. + procedure Notify( + Func: TPredicate + ); // Iterates through registered receivers and invokes the predicate; removes receiver if predicate returns false. end; implementation @@ -56,7 +59,7 @@ procedure TMycNotifyList.Destroy; begin // Because refcounting is thread-safe, this will always be entered once after all references // to Self are dropped. No locking needed! - Assert( not IsLocked ); + Assert(not IsLocked); FFirst := FFirst and not 3; UnadviseAll; end; @@ -65,24 +68,24 @@ function TMycNotifyList.Advise(const Receiver: T): TTag; var Item: PItem; begin - Assert( IsLocked ); + Assert(IsLocked); - if FFirst=0 then + if FFirst = 0 then begin - IInterface( FFirst ) := Receiver; - exit( PPointer(@Receiver)^ ); + IInterface(FFirst) := Receiver; + exit(PPointer(@Receiver)^); end; Item := AllocItem; Item.Receiver := Receiver; Item.Prev := nil; Item.Next := FList; - if Item.Next<>nil then + if Item.Next <> nil then Item.Next.Prev := Item; FList := Item; - exit( Item ); + exit(Item); end; procedure TMycNotifyList.Lock; @@ -93,19 +96,19 @@ begin YieldProcessor; continue; end; - until TInterlocked.BitTestAndClear( PNativeUint( @FFirst )^, 0 ); + until TInterlocked.BitTestAndClear(PNativeUint(@FFirst)^, 0); - Assert( IsLocked, 'Locking failed' ); + Assert(IsLocked, 'Locking failed'); end; class function TMycNotifyList.AllocItem: PItem; begin - Result := AllocMem( sizeof( TItem ) ); + Result := AllocMem(sizeof(TItem)); end; class procedure TMycNotifyList.FreeItem(Item: PItem); begin - FreeMem( Item, sizeof( TItem ) ); + FreeMem(Item, sizeof(TItem)); end; function TMycNotifyList.IsLocked: Boolean; @@ -117,65 +120,65 @@ procedure TMycNotifyList.Notify(Func: TPredicate); var Item, P: PItem; begin - Assert( IsLocked ); + Assert(IsLocked); - if FFirst<>0 then - if not Func( IInterface( FFirst ) ) then - IInterface( FFirst ) := nil; + if FFirst <> 0 then + if not Func(IInterface(FFirst)) then + IInterface(FFirst) := nil; Item := FList; - while Item<>nil do + while Item <> nil do begin P := Item.Next; - if not Func( Item.Receiver ) then - Unadvise( TTag( Item ) ); + if not Func(Item.Receiver) then + Unadvise(TTag(Item)); Item := P; end; end; procedure TMycNotifyList.Release; begin - Assert( IsLocked ); - TInterlocked.Exchange( Pointer( FFirst ), Pointer( FFirst or 1 ) ); + Assert(IsLocked); + TInterlocked.Exchange(Pointer(FFirst), Pointer(FFirst or 1)); end; procedure TMycNotifyList.Unadvise(Tag: TTag); var Item: PItem; begin - Assert( IsLocked ); + Assert(IsLocked); if NativeUInt(Tag) = FFirst then begin - IInterface( FFirst ) := nil; + IInterface(FFirst) := nil; exit; end; if FList = nil then exit; - Item := PItem( Tag ); + Item := PItem(Tag); if Item = FList then FList := Item.Next; - if Item.Prev<>nil then + if Item.Prev <> nil then Item.Prev.Next := Item.Next; - if Item.Next<>nil then + if Item.Next <> nil then Item.Next.Prev := Item.Prev; Item.Receiver := nil; - FreeItem( Item ); + FreeItem(Item); end; procedure TMycNotifyList.UnadviseAll; begin - Assert( IsLocked ); + Assert(IsLocked); - IInterface( FFirst ) := nil; - while FList<>nil do - Unadvise( TTag( FList ) ); + IInterface(FFirst) := nil; + while FList <> nil do + Unadvise(TTag(FList)); end; end. diff --git a/Src/Myc.Core.Signals.pas b/Src/Myc.Core.Signals.pas index 07d5cbf..d31afe6 100644 --- a/Src/Myc.Core.Signals.pas +++ b/Src/Myc.Core.Signals.pas @@ -8,7 +8,7 @@ uses Myc.Signals; type - TMycState = class abstract( TInterfacedObject, IMycState ) + TMycState = class abstract(TInterfacedObject, IMycState) protected function GetIsSet: Boolean; virtual; abstract; public @@ -37,10 +37,11 @@ type strict private FSubscribers: TMycNotifyList; // List of subscribers waiting for this latch to be set. private - [volatile] FCount: Integer; // The internal countdown value for the latch. + [volatile] + FCount: Integer; // The internal countdown value for the latch. function GetState: TState; // Implementation for IMycLatch.GetState and IMycFlag.GetState. protected - function GetIsSet: Boolean; override; final; // Implementation for IMycState.GetIsSet. + function GetIsSet: Boolean; override; final; // Implementation for IMycState.GetIsSet. public // Creates the latch with an initial count. // If ACount is 0 or less, the latch is effectively pre-set (delegates to FNull via CreateLatch factory). @@ -57,7 +58,7 @@ type function Notify: Boolean; end; - TMycNullLatch = class( TInterfacedObject, IMycLatch ) + TMycNullLatch = class(TInterfacedObject, IMycLatch) private function GetState: TState; function Notify: Boolean; @@ -70,10 +71,11 @@ type strict private FSubscribers: TMycNotifyList; // List of subscribers interested in state changes of this dirty flag. private - [volatile] FFlag: Boolean; // Internal state: true if dirty/set, false if clean/reset. + [volatile] + FFlag: Boolean; // Internal state: true if dirty/set, false if clean/reset. function GetState: TState; protected - function GetIsSet: Boolean; override; final; // Implementation for IMycState.GetIsSet (true if dirty). + function GetIsSet: Boolean; override; final; // Implementation for IMycState.GetIsSet (true if dirty). public // Creates a new dirty flag, initially set to dirty (true). constructor Create; @@ -93,7 +95,7 @@ type function Reset: Boolean; end; - TMycNullDirty = class( TInterfacedObject, IMycDirty ) + TMycNullDirty = class(TInterfacedObject, IMycDirty) private function GetState: TState; function Notify: Boolean; @@ -150,7 +152,7 @@ end; constructor TMycLatch.Create(ACount: Integer); begin inherited Create; - Assert( ACount >= 0 ); + Assert(ACount >= 0); FCount := ACount; FSubscribers.Create; end; @@ -177,11 +179,7 @@ begin if shouldNotifySubscribers then begin - FSubscribers.Notify( - function(Subscriber: IMycSubscriber): Boolean - begin - Result := Subscriber.Notify; - end); + FSubscribers.Notify(function(Subscriber: IMycSubscriber): Boolean begin Result := Subscriber.Notify; end); end; // Returns true if the latch has not yet been set by this Notify call (count > 0). @@ -315,11 +313,7 @@ begin if wasPreviouslyClean then // Only notify subscribers if state changed from clean to dirty. begin - FSubscribers.Notify( - function(Subscriber: IMycSubscriber): Boolean - begin - Result := Subscriber.Notify; - end); + FSubscribers.Notify(function(Subscriber: IMycSubscriber): Boolean begin Result := Subscriber.Notify; end); end; // The return value of this Notify (as an IMycSubscriber) indicates if this // TMycDirty instance itself would want more notifications if it were subscribed to something. diff --git a/Src/Myc.Core.Tasks.pas b/Src/Myc.Core.Tasks.pas index 546a33e..3ba6d38 100644 --- a/Src/Myc.Core.Tasks.pas +++ b/Src/Myc.Core.Tasks.pas @@ -3,11 +3,15 @@ unit Myc.Core.Tasks; interface uses - System.SysUtils, System.Classes, System.SyncObjs, - Myc.Core.Atomic, Myc.TaskManager, Myc.Signals; + System.SysUtils, + System.Classes, + System.SyncObjs, + Myc.Core.Atomic, + Myc.TaskManager, + Myc.Signals; type - IMycTaskFactory = interface( IMycTaskManager ) + IMycTaskFactory = interface(IMycTaskManager) {$region 'property access'} // Retrieves the number of worker threads. function GetThreadCount: Integer; @@ -46,8 +50,9 @@ type end; TMycTaskFactory = class(TInterfacedObject, IMycTaskManager, IMycTaskFactory) - type - ETaskException = class(Exception) end; + type + ETaskException = class(Exception) + end; private [volatile] FException: TObject; // Holds the first exception object from a worker thread @@ -60,8 +65,8 @@ type FWorkStack: TMycAtomicStack; // Stack of pending jobs FWorkThreads: TArray; // Array of worker threads procedure WorkerThread; - class var - FTaskManagerLock: Integer; + class var + FTaskManagerLock: Integer; protected procedure ExecuteJob; @@ -139,7 +144,7 @@ begin for var i := 0 to High(FWorkThreads) do FWorkThreads[i].Start; - FWaitSemaphores.Push( TSemaphore.Create(nil, 0, 1, '') ); + FWaitSemaphores.Push(TSemaphore.Create(nil, 0, 1, '')); end; destructor TMycTaskFactory.Destroy; @@ -159,14 +164,14 @@ end; class function TMycTaskFactory.CreateAnonymousThread(const DbgName: String; const Proc: TProc): TThread; {$IFDEF MSWINDOWS} -{$WARN SYMBOL_PLATFORM OFF} + {$WARN SYMBOL_PLATFORM OFF} var prio: TThreadPriority; {$ENDIF MSWINDOWS} begin Result := TThread.CreateAnonymousThread(Proc); - {$IFDEF MSWINDOWS} +{$IFDEF MSWINDOWS} // Set priority lower than MainThread priority if created from main thread if TThread.CurrentThread.ThreadID = MainThreadID then begin @@ -177,7 +182,7 @@ begin Result.Priority := prio; end; {$WARN SYMBOL_PLATFORM ON} - {$ENDIF MSWINDOWS} +{$ENDIF MSWINDOWS} if DbgName <> '' then Result.NameThreadForDebugging(DbgName); // Set thread name for debugging @@ -187,12 +192,12 @@ function TMycTaskFactory.CreateTask(const Gate: TState; const Proc: TProc): TSta begin if Gate.IsSet then begin - EnqueueJob( Proc ); + EnqueueJob(Proc); end else begin // The job will run when Gate notifies the subscriber returned by Run. - Result := Gate.Subscribe( Run( Proc ) ); + Result := Gate.Subscribe(Run(Proc)); end; end; @@ -205,16 +210,18 @@ begin res := TLatch.Construct(1); // Changed to use direct static call on TMycLatch capturedProc := Proc; // Capture Proc for the anonymous method - CreateAnonymousThread('Thread', - procedure - begin - try - capturedProc(); // Execute the provided procedure - finally - capturedProc := nil; // Clear the captured proc - res.Notify; // Signal completion via the latch's Notify method - end; - end).Start; + CreateAnonymousThread( + 'Thread', + procedure + begin + try + capturedProc(); // Execute the provided procedure + finally + capturedProc := nil; // Clear the captured proc + res.Notify; // Signal completion via the latch's Notify method + end; + end) + .Start; // Return the state interface of the latch exit(res.State); @@ -286,12 +293,12 @@ class procedure TMycTaskFactory.AquireTaskManager; begin if not Assigned(TaskManager) then TaskManager := TMycTaskFactory.Create; - inc( FTaskManagerLock ); + inc(FTaskManagerLock); end; class procedure TMycTaskFactory.ReleaseTaskManager; begin - dec( FTaskManagerLock ); + dec(FTaskManagerLock); if FTaskManagerLock = 0 then TaskManager := nil; end; @@ -322,11 +329,7 @@ begin for i := 0 to High(FWorkThreads) do FWorkGate.Release; - TSpinWait.SpinUntil( - function: Boolean - begin - Result := FThreadsRunning = 0; - end); + TSpinWait.SpinUntil(function: Boolean begin Result := FThreadsRunning = 0; end); Assert(FThreadsRunning = 0); @@ -357,7 +360,8 @@ begin if lock = nil then lock := TSemaphore.Create(nil, 0, 1, ''); try - {var subscription :=} State.Subscribe(TMycTaskWait.Create(lock)); + {var subscription :=} + State.Subscribe(TMycTaskWait.Create(lock)); lock.Acquire; finally FWaitSemaphores.Push(lock); @@ -386,8 +390,7 @@ end; { TMycPendingJob } -constructor TMycPendingJob.Create(OwnerTaskFactory: TMycTaskFactory; const - JobProc: TProc); +constructor TMycPendingJob.Create(OwnerTaskFactory: TMycTaskFactory; const JobProc: TProc); begin inherited Create; FOwner := OwnerTaskFactory; @@ -398,13 +401,13 @@ function TMycPendingJob.Notify: Boolean; var P: TProc; begin - PPointer(@P)^ := TInterlocked.Exchange( PPointer(@FJob)^, nil ); + PPointer(@P)^ := TInterlocked.Exchange(PPointer(@FJob)^, nil); Result := Assigned(P); if Result then begin if Assigned(FOwner) then FOwner.EnqueueJob(P); - P := nil; + P := nil; end; end; diff --git a/Src/Myc.Futures.pas b/Src/Myc.Futures.pas index 46410d2..e413212 100644 --- a/Src/Myc.Futures.pas +++ b/Src/Myc.Futures.pas @@ -4,7 +4,8 @@ interface uses System.SysUtils, - Myc.Signals, Myc.TaskManager; + Myc.Signals, + Myc.TaskManager; type // Represents the eventual result of an asynchronous operation. @@ -32,17 +33,17 @@ type class destructor DestroyClass; public - constructor Create( const AFuture: IMycFuture ); + constructor Create(const AFuture: IMycFuture); - class operator Implicit( const A: IMycFuture ): TFuture; overload; - class operator Implicit( const A: TFuture ): IMycFuture; overload; + class operator Implicit(const A: IMycFuture): TFuture; overload; + class operator Implicit(const A: TFuture): IMycFuture; overload; - class function Construct( const Proc: TFunc ): TFuture; overload; static; - class function Construct( const Gate: IMycState; const Proc: TFunc ): TFuture; overload; static; + class function Construct(const Proc: TFunc): TFuture; overload; static; + class function Construct(const Gate: IMycState; const Proc: TFunc): TFuture; overload; static; class property Null: IMycFuture read FNull; - function Chain( const Proc: TFunc ): TFuture; + function Chain(const Proc: TFunc): TFuture; function WaitFor: T; @@ -53,12 +54,13 @@ type implementation uses - Myc.Core.Futures, Myc.Core.Tasks; + Myc.Core.Futures, + Myc.Core.Tasks; -constructor TFuture.Create( const AFuture: IMycFuture ); +constructor TFuture.Create(const AFuture: IMycFuture); begin FFuture := AFuture; - if not Assigned( FFuture ) then + if not Assigned(FFuture) then FFuture := FNull; end; @@ -73,26 +75,21 @@ begin TMycTaskFactory.ReleaseTaskManager; end; -function TFuture.Chain( const Proc: TFunc ): TFuture; +function TFuture.Chain(const Proc: TFunc): TFuture; begin - var - Cap := FFuture; + var Cap := FFuture; - Result := TFuture.Construct( FFuture.Done, - function: S - begin - Result := Proc( Cap.Result ); - end ); + Result := TFuture.Construct(FFuture.Done, function: S begin Result := Proc(Cap.Result); end); end; -class function TFuture.Construct( const Proc: TFunc ): TFuture; +class function TFuture.Construct(const Proc: TFunc): TFuture; begin - Result := TMycGateFuncFuture.Create( TaskManager, nil, Proc ); + Result := TMycGateFuncFuture.Create(TaskManager, nil, Proc); end; -class function TFuture.Construct( const Gate: IMycState; const Proc: TFunc ): TFuture; +class function TFuture.Construct(const Gate: IMycState; const Proc: TFunc): TFuture; begin - Result := TMycGateFuncFuture.Create( TaskManager, Gate, Proc ); + Result := TMycGateFuncFuture.Create(TaskManager, Gate, Proc); end; function TFuture.GetDone: IMycState; @@ -107,16 +104,16 @@ end; function TFuture.WaitFor: T; begin - TaskManager.WaitFor( FFuture.Done ); + TaskManager.WaitFor(FFuture.Done); Result := FFuture.Result; end; -class operator TFuture.Implicit( const A: IMycFuture ): TFuture; +class operator TFuture.Implicit(const A: IMycFuture): TFuture; begin - Result.Create( A ); + Result.Create(A); end; -class operator TFuture.Implicit( const A: TFuture ): IMycFuture; +class operator TFuture.Implicit(const A: TFuture): IMycFuture; begin Result := A.FFuture; end; diff --git a/Src/Myc.Lazy.pas b/Src/Myc.Lazy.pas index 0fac61f..ca2bd08 100644 --- a/Src/Myc.Lazy.pas +++ b/Src/Myc.Lazy.pas @@ -11,7 +11,7 @@ type {$REGION 'property access'} function GetChanged: IMycState; {$ENDREGION} - function Pop( out Res: T ): Boolean; + function Pop(out Res: T): Boolean; property Changed: IMycState read GetChanged; end; @@ -24,14 +24,14 @@ type class constructor CreateClass; public - constructor Create( const ALazy: IMycLazy ); + constructor Create(const ALazy: IMycLazy); - class function Construct( const Changing: IMycState; const Proc: TFunc ): IMycLazy; static; + class function Construct(const Changing: IMycState; const Proc: TFunc): IMycLazy; static; - class operator Implicit( const A: IMycLazy ): TLazy; overload; - class operator Implicit( const A: TLazy ): IMycLazy; overload; + class operator Implicit(const A: IMycLazy): TLazy; overload; + class operator Implicit(const A: TLazy): IMycLazy; overload; - function Pop( out Res: T ): Boolean; inline; + function Pop(out Res: T): Boolean; inline; property Changed: IMycState read GetChanged; end; @@ -41,16 +41,16 @@ implementation uses Myc.Core.Lazy; -constructor TLazy.Create( const ALazy: IMycLazy ); +constructor TLazy.Create(const ALazy: IMycLazy); begin FLazy := ALazy; - if not Assigned( FLazy ) then + if not Assigned(FLazy) then FLazy := FNull; end; -class function TLazy.Construct( const Changing: IMycState; const Proc: TFunc ): IMycLazy; +class function TLazy.Construct(const Changing: IMycState; const Proc: TFunc): IMycLazy; begin - Result := TMycFuncLazy.Create( Changing, Proc ); + Result := TMycFuncLazy.Create(Changing, Proc); end; class constructor TLazy.CreateClass; @@ -63,17 +63,17 @@ begin Result := FLazy.Changed; end; -function TLazy.Pop( out Res: T ): Boolean; +function TLazy.Pop(out Res: T): Boolean; begin - Result := FLazy.Pop( Res ); + Result := FLazy.Pop(Res); end; -class operator TLazy.Implicit( const A: IMycLazy ): TLazy; +class operator TLazy.Implicit(const A: IMycLazy): TLazy; begin - Result.Create( A ); + Result.Create(A); end; -class operator TLazy.Implicit( const A: TLazy ): IMycLazy; +class operator TLazy.Implicit(const A: TLazy): IMycLazy; begin Result := A.FLazy; end; diff --git a/Src/Myc.Signals.pas b/Src/Myc.Signals.pas index ac14604..0dc9849 100644 --- a/Src/Myc.Signals.pas +++ b/Src/Myc.Signals.pas @@ -18,24 +18,24 @@ type function GetIsSet: Boolean; {$ENDREGION} // Subscribes a given subscriber to this TState. - function Subscribe( Subscriber: IMycSubscriber ): Pointer; - procedure Unsubscribe( Tag: Pointer ); + function Subscribe(Subscriber: IMycSubscriber): Pointer; + procedure Unsubscribe(Tag: Pointer); // IsSet is true if the TState has been reached or the condition is met. property IsSet: Boolean read GetIsSet; end; TState = record // helper for IMycState - type - TSubscription = record - private - FState: IMycState; - FTag: Pointer; // Tag identifying this subscription within the notifier list. - constructor Create( const AState: IMycState; ATag: Pointer ); - public - class operator Initialize( out Dest: TSubscription ); - // Unsubscribes from the associated TState. - procedure Unsubscribe; - end; + type + TSubscription = record + private + FState: IMycState; + FTag: Pointer; // Tag identifying this subscription within the notifier list. + constructor Create(const AState: IMycState; ATag: Pointer); + public + class operator Initialize(out Dest: TSubscription); + // Unsubscribes from the associated TState. + procedure Unsubscribe; + end; strict private class var @@ -45,25 +45,25 @@ type FState: IMycState; function GetIsSet: Boolean; inline; public - constructor Create( const AState: IMycState ); + constructor Create(const AState: IMycState); - class operator Implicit( const A: IMycState ): TState; overload; - class operator Implicit( const A: TState ): IMycState; overload; + class operator Implicit(const A: IMycState): TState; overload; + class operator Implicit(const A: TState): IMycState; overload; - class function All( const States: TArray ): TState; static; - class function Any( const States: TArray ): TState; static; + class function All(const States: TArray): TState; static; + class function Any(const States: TArray): TState; static; class property Null: IMycState read FNull; - function Subscribe( Subscriber: IMycSubscriber ): TSubscription; inline; - procedure Unsubscribe( Tag: Pointer ); inline; + function Subscribe(Subscriber: IMycSubscriber): TSubscription; inline; + procedure Unsubscribe(Tag: Pointer); inline; property IsSet: Boolean read GetIsSet; end; // IMycLatch is a specific type of flag that, once set, remains set (non-resettable). // It typically becomes set when an internal countdown reaches zero. - IMycLatch = interface( IMycSubscriber ) + IMycLatch = interface(IMycSubscriber) // Provides access to the IMycState interface of the flag. function GetState: TState; property State: TState read GetState; @@ -86,7 +86,7 @@ type class function Construct(Count: Integer): TLatch; static; - class function Enqueue(var Gate: TLatch; Count: Integer=1): TState; static; + class function Enqueue(var Gate: TLatch; Count: Integer = 1): TState; static; class property Null: IMycLatch read FNull; @@ -97,7 +97,7 @@ type // IMycDirty represents a resettable flag, typically indicating if a State is "dirty" (requiring attention) or "clean". // It inherits from IMycFlag, meaning it has a State, can be notified, and subscribed to. - IMycDirty = interface( IMycSubscriber ) + IMycDirty = interface(IMycSubscriber) // Provides access to the IMycState interface of the flag. function GetState: TState; // Resets the flag to its "clean" (not set / not dirty) State. @@ -119,26 +119,26 @@ type implementation uses - Myc.Core.Notifier, Myc.Core.Signals; + Myc.Core.Notifier, + Myc.Core.Signals; { TState.TSubscription } -constructor TState.TSubscription.Create( const AState: IMycState; ATag: - TMycNotifyList.TTag ); +constructor TState.TSubscription.Create(const AState: IMycState; ATag: TMycNotifyList.TTag); begin - Assert( Assigned( AState ) ); + Assert(Assigned(AState)); FState := AState; FTag := ATag; end; procedure TState.TSubscription.Unsubscribe; begin - FState.Unsubscribe( FTag ); + FState.Unsubscribe(FTag); FState := TState.Null; FTag := nil; end; -class operator TState.TSubscription.Initialize( out Dest: TSubscription ); +class operator TState.TSubscription.Initialize(out Dest: TSubscription); begin Dest.FState := TState.Null; Dest.FTag := nil; @@ -146,42 +146,42 @@ end; { TState } -constructor TState.Create( const AState: IMycState ); +constructor TState.Create(const AState: IMycState); begin FState := AState; - if not Assigned( FState ) then + if not Assigned(FState) then FState := FNull; end; class constructor TState.ClassCreate; begin // Create a singleton null latch instance that is initially (and always) set. - FNull := TMycNullState.Create( ); // Calls the instance constructor + FNull := TMycNullState.Create(); // Calls the instance constructor end; -class function TState.All( const States: TArray ): TState; +class function TState.All(const States: TArray): TState; var Latch: IMycLatch; begin - Latch := TLatch.Construct( Length( States ) ); - for var i := 0 to High( States ) do - States[i].Subscribe( Latch ); + Latch := TLatch.Construct(Length(States)); + for var i := 0 to High(States) do + States[i].Subscribe(Latch); Result := Latch.State; end; -class function TState.Any( const States: TArray ): TState; +class function TState.Any(const States: TArray): TState; var Latch: IMycLatch; begin - if Length( States ) = 0 then + if Length(States) = 0 then begin Result := TState.Null; end else begin - Latch := TLatch.Construct( 1 ); - for var i := 0 to High( States ) do - States[i].Subscribe( Latch ); + Latch := TLatch.Construct(1); + for var i := 0 to High(States) do + States[i].Subscribe(Latch); Result := Latch.State; end; end; @@ -191,24 +191,24 @@ begin Result := FState.IsSet; end; -function TState.Subscribe( Subscriber: IMycSubscriber ): TSubscription; +function TState.Subscribe(Subscriber: IMycSubscriber): TSubscription; begin - Result := TSubscription.Create( FState, FState.Subscribe( Subscriber ) ); + Result := TSubscription.Create(FState, FState.Subscribe(Subscriber)); end; -procedure TState.Unsubscribe( Tag: Pointer ); +procedure TState.Unsubscribe(Tag: Pointer); begin - FState.Unsubscribe( Tag ); + FState.Unsubscribe(Tag); end; -class operator TState.Implicit( const A: TState ): IMycState; +class operator TState.Implicit(const A: TState): IMycState; begin Result := A.FState; end; -class operator TState.Implicit( const A: IMycState ): TState; +class operator TState.Implicit(const A: IMycState): TState; begin - Result.Create( A ); + Result.Create(A); end; { TLatch } @@ -224,24 +224,24 @@ end; constructor TLatch.Create(const ALatch: IMycLatch); begin FLatch := ALatch; - if not Assigned( FLatch ) then + if not Assigned(FLatch) then FLatch := FNull; end; class function TLatch.Construct(Count: Integer): TLatch; begin if Count > 0 then - Result := TMycLatch.Create( Count ) + Result := TMycLatch.Create(Count) else Result := FNull; end; -class function TLatch.Enqueue(var Gate: TLatch; Count: Integer=1): TState; +class function TLatch.Enqueue(var Gate: TLatch; Count: Integer = 1): TState; begin var gateState := Gate.State; - Gate := TMycLatch.Create( Count ); - gateState.Subscribe( Gate ); - exit( Gate.State ); + Gate := TMycLatch.Create(Count); + gateState.Subscribe(Gate); + exit(Gate.State); end; function TLatch.GetState: TState; @@ -256,7 +256,7 @@ end; class operator TLatch.Implicit(const A: IMycLatch): TLatch; begin - Result.Create( A ); + Result.Create(A); end; class operator TLatch.Implicit(const A: TLatch): IMycLatch; diff --git a/Src/Myc.TaskManager.pas b/Src/Myc.TaskManager.pas index 7af11e4..d276f92 100644 --- a/Src/Myc.TaskManager.pas +++ b/Src/Myc.TaskManager.pas @@ -9,7 +9,7 @@ uses type IMycTaskManager = interface // TOD Dokumentation - function CreateTask( const Gate: TState; const Proc: TProc ): TState.TSubscription; + function CreateTask(const Gate: TState; const Proc: TProc): TState.TSubscription; // Waits for the operation associated with State to complete. // Must not be called from a worker thread of this factory. @@ -74,12 +74,12 @@ end; function TMycTaskManagerMock.CreateTask(const Gate: TState; const Proc: TProc): TState.TSubscription; begin - Result := Gate.Subscribe( TMycExecMock.Create( Proc ) ); + Result := Gate.Subscribe(TMycExecMock.Create(Proc)); end; procedure TMycTaskManagerMock.WaitFor(State: IMycState); begin - Assert( State.IsSet ); + Assert(State.IsSet); end; procedure SetupTaskManagerMock; diff --git a/Src/Myc.Test.Core.Atomic.pas b/Src/Myc.Test.Core.Atomic.pas index a71a5a7..4863736 100644 --- a/Src/Myc.Test.Core.Atomic.pas +++ b/Src/Myc.Test.Core.Atomic.pas @@ -18,7 +18,7 @@ type PTestSListEntryData = ^TTestSListEntryData; TTestSListEntryData = record Entry: TSListEntry; // The SList entry structure - ID: Integer; // Sample data associated with the entry + ID: Integer; // Sample data associated with the entry end; [TestFixture] @@ -109,7 +109,8 @@ type implementation -uses System.TypInfo; +uses + System.TypInfo; { TTestSList } @@ -147,14 +148,14 @@ begin // Popping to empty the list if not already empty end; tempList := FList; // Store to call Free - FList := nil; // Prevent using FList after Free - tempList.Free; // Free the TSList structure itself + FList := nil; // Prevent using FList after Free + tempList.Free; // Free the TSList structure itself end; // Free all allocated PTestSListEntryData for entryNode in FEntries do begin - var P:= entryNode; + var P := entryNode; FreeMemAligned(P); end; SetLength(FEntries, 0); @@ -277,10 +278,11 @@ begin // This test confirms that using an aligned entry from AllocEntryData works. entryData := AllocEntryData(123); // This should not raise an assertion error from TSList.Push. - Assert.WillNotRaise(procedure - begin - FList.Push(@entryData.Entry); - end, nil, 'Pushing an aligned entry should not raise an exception/assertion.'); + Assert.WillNotRaise( + procedure begin FList.Push(@entryData.Entry); end, + nil, + 'Pushing an aligned entry should not raise an exception/assertion.' + ); Assert.AreEqual(1, FList.QueryDepth, 'QueryDepth should be 1 after pushing an aligned entry.'); end; @@ -391,10 +393,7 @@ end; procedure TTestMycAtomicStack_Integer.TestClear_OnEmptyStack; begin // Clearing an already empty stack should not cause issues - Assert.WillNotRaise(procedure - begin - FStack.Clear; - end, nil, 'Clear on an empty stack should not raise an exception.'); + Assert.WillNotRaise(procedure begin FStack.Clear; end, nil, 'Clear on an empty stack should not raise an exception.'); Assert.AreEqual(Default(Integer), FStack.Pop, 'Stack should remain empty after Clear on empty stack.'); end; diff --git a/Src/Myc.Test.Core.Lazy.pas b/Src/Myc.Test.Core.Lazy.pas index 6908e63..f41cf38 100644 --- a/Src/Myc.Test.Core.Lazy.pas +++ b/Src/Myc.Test.Core.Lazy.pas @@ -5,9 +5,9 @@ interface uses System.SysUtils, DUnitX.TestFramework, - Myc.Signals, // For IMycState, TState, IMycDirty - Myc.Lazy, // For IMycLazy - Myc.Core.Lazy; // Unit to be tested + Myc.Signals, // For IMycState, TState, IMycDirty + Myc.Lazy, // For IMycLazy + Myc.Core.Lazy; // Unit to be tested type [TestFixture] @@ -186,12 +186,15 @@ begin sourceDirty.Reset; procExecuted := False; expectedValue := 50; - funcLazy := TMycFuncLazy.Create(sourceDirty.State, - function: Integer - begin - procExecuted := True; - Result := expectedValue; - end); + funcLazy := + TMycFuncLazy.Create( + sourceDirty.State, + function: Integer + begin + procExecuted := True; + Result := expectedValue; + end + ); Assert.IsNotNull(funcLazy, 'TMycFuncLazy instance should not be nil'); Assert.IsTrue(funcLazy.GetChanged.IsSet, 'Changed.IsSet should be true before the first Pop by design'); value := 0; @@ -219,7 +222,11 @@ begin value := preCallValue; result := funcLazy.Pop(value); Assert.IsTrue(result, 'First Pop should return true by design, even if FProc is nil'); - Assert.AreEqual(preCallValue, value, 'Value should be unchanged as FProc was nil and current Pop implementation does not assign Default(T)'); + Assert.AreEqual( + preCallValue, + value, + 'Value should be unchanged as FProc was nil and current Pop implementation does not assign Default(T)' + ); Assert.IsFalse(funcLazy.GetChanged.IsSet, 'Changed state should be false after Pop'); end; @@ -252,12 +259,15 @@ begin sourceDirty.Reset; initialProcValue := 44; procExecutedCount := 0; - funcLazy := TMycFuncLazy.Create(sourceDirty.State, - function: Integer - begin - Inc(procExecutedCount); - Result := initialProcValue; - end); + funcLazy := + TMycFuncLazy.Create( + sourceDirty.State, + function: Integer + begin + Inc(procExecutedCount); + Result := initialProcValue; + end + ); Helper_ConsumeInitialPop(funcLazy, initialProcValue); Assert.AreEqual(1, procExecutedCount, 'Proc should have executed once for initial pop'); result := funcLazy.Pop(value); @@ -294,13 +304,18 @@ begin sourceDirty := TDirty.Construct; sourceDirty.Reset; procCallCount := 0; - funcLazy := TMycFuncLazy.Create(sourceDirty.State, - function: Integer - begin - Inc(procCallCount); - if procCallCount = 1 then Result := 30 - else Result := 300 + procCallCount; - end); + funcLazy := + TMycFuncLazy.Create( + sourceDirty.State, + function: Integer + begin + Inc(procCallCount); + if procCallCount = 1 then + Result := 30 + else + Result := 300 + procCallCount; + end + ); currentExpectedValue := 30; Helper_ConsumeInitialPop(funcLazy, currentExpectedValue); Assert.AreEqual(1, procCallCount, 'Proc executed for initial Pop'); @@ -326,12 +341,15 @@ begin sourceDirty := TDirty.Construct; sourceDirty.Reset; procCallCount := 0; - funcLazy := TMycFuncLazy.Create(sourceDirty.State, - function: Integer - begin - Inc(procCallCount); - Result := 40; - end); + funcLazy := + TMycFuncLazy.Create( + sourceDirty.State, + function: Integer + begin + Inc(procCallCount); + Result := 40; + end + ); resultPop1 := funcLazy.Pop(value); Assert.IsTrue(resultPop1, 'First Pop should return true by design'); Assert.AreEqual(40, value, 'Value from first Pop'); @@ -359,14 +377,20 @@ begin initialValue := 51; firstSourceChangeValue := 52; - funcLazy := TMycFuncLazy.Create(sourceDirty.State, - function: Integer - begin - Inc(procCallCount); - if procCallCount = 1 then Result := initialValue // For initial pop - else if procCallCount = 2 then Result := firstSourceChangeValue // For pop after first effective source change - else Result := 999; // Should not be reached in this specific test logic - end); + funcLazy := + TMycFuncLazy.Create( + sourceDirty.State, + function: Integer + begin + Inc(procCallCount); + if procCallCount = 1 then + Result := initialValue // For initial pop + else if procCallCount = 2 then + Result := firstSourceChangeValue // For pop after first effective source change + else + Result := 999; // Should not be reached in this specific test logic + end + ); // 1. Initial Pop (consumes "by design" changed state) Assert.IsTrue(funcLazy.GetChanged.IsSet, 'Changed state should be true before first Pop (by design)'); @@ -389,7 +413,7 @@ begin // 3. Notify sourceDirty again (sourceDirty is already TRUE) Assert.IsTrue(sourceDirty.State.IsSet, 'sourceDirty is still set before second Notify attempt'); sourceDirty.Notify; // Since sourceDirty is already set, this does NOT notify funcLazy.FChanged. - // funcLazy.GetChanged.IsSet remains FALSE. + // funcLazy.GetChanged.IsSet remains FALSE. Assert.IsFalse(funcLazy.GetChanged.IsSet, 'Changed state should REMAIN false after Notify on an already-set source'); @@ -412,12 +436,10 @@ begin Assert.IsTrue(funcLazyObj.Pop(tempVal), 'Initial Pop should succeed'); funcLazyObj.Destroy; Assert.WillNotRaise( - procedure - begin - sourceDirty.Notify; - end, - nil, - 'Destroy test assumes TMycSubscription.Unsubscribe works. Verified by no crash on source notify post-destroy.'); + procedure begin sourceDirty.Notify; end, + nil, + 'Destroy test assumes TMycSubscription.Unsubscribe works. Verified by no crash on source notify post-destroy.' + ); sourceDirty := nil; end; @@ -434,12 +456,15 @@ begin Assert.IsTrue(sourceDirty.State.IsSet, 'SourceDirty should be initially set for this test scenario'); expectedValue := 70; procExecuted := False; - funcLazy := TMycFuncLazy.Create(sourceDirty.State, - function: Integer - begin - procExecuted := True; - Result := expectedValue; - end); + funcLazy := + TMycFuncLazy.Create( + sourceDirty.State, + function: Integer + begin + procExecuted := True; + Result := expectedValue; + end + ); Assert.IsNotNull(funcLazy, 'TMycFuncLazy instance should not be nil'); Assert.IsTrue(funcLazy.GetChanged.IsSet, 'funcLazy.GetChanged.IsSet should be true after creation (by design)'); value := 0; diff --git a/Src/Myc.Test.Lazy.pas b/Src/Myc.Test.Lazy.pas index bbeab5b..40ed255 100644 --- a/Src/Myc.Test.Lazy.pas +++ b/Src/Myc.Test.Lazy.pas @@ -5,8 +5,8 @@ interface uses System.SysUtils, DUnitX.TestFramework, - Myc.Signals, // For IMycState, TState, IMycDirty - Myc.Lazy; // The unit under test + Myc.Signals, // For IMycState, TState, IMycDirty + Myc.Lazy; // The unit under test type [TestFixture] @@ -145,12 +145,15 @@ var begin procExecuted := False; // FChangingSignal is reset in Setup - lazyIntf := TLazy.Construct(FChangingSignal.State, - function: Integer - begin - procExecuted := True; - Result := 10; - end); + lazyIntf := + TLazy.Construct( + FChangingSignal.State, + function: Integer + begin + procExecuted := True; + Result := 10; + end + ); Assert.IsNotNull(lazyIntf, 'TLazy.Construct should return a valid interface'); lazyRec := lazyIntf; // Implicit conversion @@ -167,12 +170,15 @@ var begin procExecuted := False; expectedValue := 20; - lazyIntf := TLazy.Construct(FChangingSignal.State, - function: Integer - begin - procExecuted := True; - Result := expectedValue; - end); + lazyIntf := + TLazy.Construct( + FChangingSignal.State, + function: Integer + begin + procExecuted := True; + Result := expectedValue; + end + ); lazyRec := lazyIntf; ConsumeInitialPop(lazyRec, expectedValue, 'TestConstruct_FirstPop'); @@ -229,12 +235,15 @@ var procCallCount: Integer; begin procCallCount := 0; - lazyIntf := TLazy.Construct(FChangingSignal.State, - function: Integer - begin - Inc(procCallCount); - Result := 100 + procCallCount; // Value changes per call - end); + lazyIntf := + TLazy.Construct( + FChangingSignal.State, + function: Integer + begin + Inc(procCallCount); + Result := 100 + procCallCount; // Value changes per call + end + ); lazyRec := lazyIntf; ConsumeInitialPop(lazyRec, 101, 'TestConstruct_StateInteraction_PopResetsChangedAfterSignal (Initial)'); // procCallCount = 1 @@ -257,12 +266,15 @@ var procCallCount: Integer; begin procCallCount := 0; - lazyIntf := TLazy.Construct(FChangingSignal.State, - function: Integer - begin - Inc(procCallCount); - Result := 200 + procCallCount; - end); + lazyIntf := + TLazy.Construct( + FChangingSignal.State, + function: Integer + begin + Inc(procCallCount); + Result := 200 + procCallCount; + end + ); lazyRec := lazyIntf; // 1. Initial Pop @@ -307,20 +319,20 @@ begin ConsumeInitialPop(lazyRec, 1, 'TestConstruct_Destruction (Initial)'); lazyIntf := nil; // Release the IMycLazy interface. ARC should destroy the TMycFuncLazy object. - // This should trigger its destructor, which should unsubscribe from localChangingSignal. + // This should trigger its destructor, which should unsubscribe from localChangingSignal. Assert.WillNotRaise( - procedure - begin - localChangingSignal.Notify; // Notify the source AFTER the lazy object is supposed to be gone. - end, - nil, // Default: any exception is a failure - 'Notifying source after lazy object is freed should not crash, indicating unsubscription.'); + procedure + begin + localChangingSignal.Notify; // Notify the source AFTER the lazy object is supposed to be gone. + end, + nil, // Default: any exception is a failure + 'Notifying source after lazy object is freed should not crash, indicating unsubscription.' + ); localChangingSignal := nil; // Clean up the local signal itself. end; - // == Tests for TLazy.Create with a pre-existing (non-nil) IMycLazy == procedure TTestMyLazy.TestCreateWithExistingLazy_DelegatesChangedCorrectly; @@ -355,12 +367,15 @@ var procCallCount: Integer; begin procCallCount := 0; - originalLazyIntf := TLazy.Construct(FChangingSignal.State, - function: Integer - begin - Inc(procCallCount); - Result := 70 + procCallCount; - end); + originalLazyIntf := + TLazy.Construct( + FChangingSignal.State, + function: Integer + begin + Inc(procCallCount); + Result := 70 + procCallCount; + end + ); wrappedLazyRec := TLazy.Create(originalLazyIntf); // First Pop via wrapper (initial pop) @@ -434,12 +449,15 @@ var procExecuted: Boolean; begin procExecuted := False; - lazyIntf := TLazy.Construct(FChangingSignal.State, - function: Integer - begin - procExecuted := True; - Result := 100; - end); + lazyIntf := + TLazy.Construct( + FChangingSignal.State, + function: Integer + begin + procExecuted := True; + Result := 100; + end + ); lazyRec := lazyIntf; ConsumeInitialPop(lazyRec, 100, 'TestPop_AfterInitialAndNoSignal (Initial)'); diff --git a/Test/MycTests.dpr b/Test/MycTests.dpr index cb820d2..9ce5baf 100644 --- a/Test/MycTests.dpr +++ b/Test/MycTests.dpr @@ -1,87 +1,87 @@ program MycTests; {$IFNDEF TESTINSIGHT} -{$APPTYPE CONSOLE} + {$APPTYPE CONSOLE} {$ENDIF} {$STRONGLINKTYPES ON} uses - FastMM5, - DUnitX.MemoryLeakMonitor.FastMM5, - System.SysUtils, - {$IFDEF TESTINSIGHT} - TestInsight.DUnitX, - {$ELSE} - DUnitX.Loggers.Console, - {$ENDIF } - DUnitX.TestFramework, - TestNotifier in 'TestNotifier.pas', - TestNotifier_Threading in 'TestNotifier_Threading.pas' {/TestNotifier_ChaosStress in 'TestNotifier_ChaosStress.pas',}, - TestNotifier_ChaosStress in 'TestNotifier_ChaosStress.pas', - TestSignals_Latch in 'TestSignals_Latch.pas', - Myc.Core.Tasks in '..\Src\Myc.Core.Tasks.pas', - TestTasks in 'TestTasks.pas', - TestSignals_Dirty in 'TestSignals_Dirty.pas', - Myc.Futures in '..\Src\Myc.Futures.pas', - TestCoreFutures in 'TestCoreFutures.pas', - Myc.TaskManager in '..\Src\Myc.TaskManager.pas', - Myc.Core.Futures in '..\Src\Myc.Core.Futures.pas', - Myc.Core.Signals in '..\Src\Myc.Core.Signals.pas', - TestFutures in 'TestFutures.pas', - Myc.Lazy in '..\Src\Myc.Lazy.pas', - Myc.Core.Lazy in '..\Src\Myc.Core.Lazy.pas', - Myc.Test.Core.Lazy in '..\Src\Myc.Test.Core.Lazy.pas', - Myc.Test.Lazy in '..\Src\Myc.Test.Lazy.pas', - Myc.Test.Core.Atomic in '..\Src\Myc.Test.Core.Atomic.pas'; + FastMM5, + DUnitX.MemoryLeakMonitor.FastMM5, + System.SysUtils, +{$IFDEF TESTINSIGHT} + TestInsight.DUnitX, +{$ELSE} + DUnitX.Loggers.Console, +{$ENDIF } + DUnitX.TestFramework, + TestNotifier in 'TestNotifier.pas', + TestNotifier_Threading in 'TestNotifier_Threading.pas' {/TestNotifier_ChaosStress in 'TestNotifier_ChaosStress.pas',}, + TestNotifier_ChaosStress in 'TestNotifier_ChaosStress.pas', + TestSignals_Latch in 'TestSignals_Latch.pas', + Myc.Core.Tasks in '..\Src\Myc.Core.Tasks.pas', + TestTasks in 'TestTasks.pas', + TestSignals_Dirty in 'TestSignals_Dirty.pas', + Myc.Futures in '..\Src\Myc.Futures.pas', + TestCoreFutures in 'TestCoreFutures.pas', + Myc.TaskManager in '..\Src\Myc.TaskManager.pas', + Myc.Core.Futures in '..\Src\Myc.Core.Futures.pas', + Myc.Core.Signals in '..\Src\Myc.Core.Signals.pas', + TestFutures in 'TestFutures.pas', + Myc.Lazy in '..\Src\Myc.Lazy.pas', + Myc.Core.Lazy in '..\Src\Myc.Core.Lazy.pas', + Myc.Test.Core.Lazy in '..\Src\Myc.Test.Core.Lazy.pas', + Myc.Test.Lazy in '..\Src\Myc.Test.Lazy.pas', + Myc.Test.Core.Atomic in '..\Src\Myc.Test.Core.Atomic.pas'; { keep comment here to protect the following conditional from being removed by the IDE when adding a unit } {$IFNDEF TESTINSIGHT} var - runner: ITestRunner; - results: IRunResults; - logger: ITestLogger; - nunitLogger : ITestLogger; + runner: ITestRunner; + results: IRunResults; + logger: ITestLogger; + nunitLogger: ITestLogger; {$ENDIF} begin {$IFDEF TESTINSIGHT} - TestInsight.DUnitX.RunRegisteredTests; + TestInsight.DUnitX.RunRegisteredTests; {$ELSE} - try - //Check command line options, will exit if invalid - TDUnitX.CheckCommandLine; - //Create the test runner - runner := TDUnitX.CreateRunner; - //Tell the runner to use RTTI to find Fixtures - runner.UseRTTI := True; - //When true, Assertions must be made during tests; - runner.FailsOnNoAsserts := False; + try + //Check command line options, will exit if invalid + TDUnitX.CheckCommandLine; + //Create the test runner + runner := TDUnitX.CreateRunner; + //Tell the runner to use RTTI to find Fixtures + runner.UseRTTI := True; + //When true, Assertions must be made during tests; + runner.FailsOnNoAsserts := False; - //tell the runner how we will log things - //Log to the console window if desired - if TDUnitX.Options.ConsoleMode <> TDunitXConsoleMode.Off then - begin - logger := TDUnitXConsoleLogger.Create(TDUnitX.Options.ConsoleMode = TDunitXConsoleMode.Quiet); - runner.AddLogger(logger); - end; - //Generate an NUnit compatible XML File - nunitLogger := TDUnitXXMLNUnitFileLogger.Create(TDUnitX.Options.XMLOutputFile); - runner.AddLogger(nunitLogger); + //tell the runner how we will log things + //Log to the console window if desired + if TDUnitX.Options.ConsoleMode <> TDunitXConsoleMode.Off then + begin + logger := TDUnitXConsoleLogger.Create(TDUnitX.Options.ConsoleMode = TDunitXConsoleMode.Quiet); + runner.AddLogger(logger); + end; + //Generate an NUnit compatible XML File + nunitLogger := TDUnitXXMLNUnitFileLogger.Create(TDUnitX.Options.XMLOutputFile); + runner.AddLogger(nunitLogger); - //Run tests - results := runner.Execute; - if not results.AllPassed then - System.ExitCode := EXIT_ERRORS; + //Run tests + results := runner.Execute; + if not results.AllPassed then + System.ExitCode := EXIT_ERRORS; {$IFNDEF CI} - //We don't want this happening when running under CI. - if TDUnitX.Options.ExitBehavior = TDUnitXExitBehavior.Pause then - begin - System.Write('Done.. press key to quit.'); - System.Readln; - end; + //We don't want this happening when running under CI. + if TDUnitX.Options.ExitBehavior = TDUnitXExitBehavior.Pause then + begin + System.Write('Done.. press key to quit.'); + System.Readln; + end; {$ENDIF} - except - on E: Exception do - System.Writeln(E.ClassName, ': ', E.Message); - end; + except + on E: Exception do + System.Writeln(E.ClassName, ': ', E.Message); + end; {$ENDIF} end. diff --git a/Test/TestCoreFutures.pas b/Test/TestCoreFutures.pas index 9ee5800..052b391 100644 --- a/Test/TestCoreFutures.pas +++ b/Test/TestCoreFutures.pas @@ -3,50 +3,52 @@ unit TestCoreFutures; interface uses - DUnitX.TestFramework, - System.SysUtils, System.Generics.Collections, // Added for TObjectList if needed, not strictly for this - System.SyncObjs, - Myc.Signals, // For IMycLatch, TMycLatch, IMycState, IMycSubscriber [cite: 62, 68, 53, 45] - Myc.Core.Tasks, // For IMycTaskFactory, TMycTaskFactory [cite: 97, 113] - Myc.Futures, Myc.Core.Futures; // For IMycFuture, TMycInitStateFuncFuture + DUnitX.TestFramework, + System.SysUtils, + System.Generics.Collections, // Added for TObjectList if needed, not strictly for this + System.SyncObjs, + Myc.Signals, // For IMycLatch, TMycLatch, IMycState, IMycSubscriber [cite: 62, 68, 53, 45] + Myc.Core.Tasks, // For IMycTaskFactory, TMycTaskFactory [cite: 97, 113] + Myc.Futures, + Myc.Core.Futures; // For IMycFuture, TMycInitStateFuncFuture type - // Helper class to notify a latch when its Notify method is called. - TLatchNotifierSubscriber = class(TInterfacedObject, IMycSubscriber) - private - FGateLatch: IMycLatch; - public - constructor Create(AGateLatch: IMycLatch); - // IMycSubscriber - function Notify: Boolean; // Implements IMycSubscriber.Notify [cite: 46, 181, 299] - end; + // Helper class to notify a latch when its Notify method is called. + TLatchNotifierSubscriber = class(TInterfacedObject, IMycSubscriber) + private + FGateLatch: IMycLatch; + public + constructor Create(AGateLatch: IMycLatch); + // IMycSubscriber + function Notify: Boolean; // Implements IMycSubscriber.Notify [cite: 46, 181, 299] + end; - [TestFixture] - [IgnoreMemoryLeaks(true)] - TTestMycGateFuncFuture = class(TObject) - private - FTaskFactory: IMycTaskFactory; - FProcExecutionCount: Integer; // Counter for side effects of AProc - FSharedCounter: Integer; // For Fan-Out test side effects - public - [Setup] - procedure Setup; - [TearDown] - procedure TearDown; + [TestFixture] + [IgnoreMemoryLeaks(true)] + TTestMycGateFuncFuture = class(TObject) + private + FTaskFactory: IMycTaskFactory; + FProcExecutionCount: Integer; // Counter for side effects of AProc + FSharedCounter: Integer; // For Fan-Out test side effects + public + [Setup] + procedure Setup; + [TearDown] + procedure TearDown; - [Test] - procedure Test_BasicSuccess_WithImmediateInitState; - [Test] - procedure Test_ChainedExecution_WithDelayedInitState; - [Test] - procedure Test_ExceptionInProc_HandledAsPlanned; - [Test] - procedure Test_GetResult_BeforeDone_RaisesException; - [Test] - procedure Test_FanIn_OneFutureWaitsForMultipleOthers; - [Test] - procedure Test_FanOut_MultipleFuturesWaitForOneTrigger; - end; + [Test] + procedure Test_BasicSuccess_WithImmediateInitState; + [Test] + procedure Test_ChainedExecution_WithDelayedInitState; + [Test] + procedure Test_ExceptionInProc_HandledAsPlanned; + [Test] + procedure Test_GetResult_BeforeDone_RaisesException; + [Test] + procedure Test_FanIn_OneFutureWaitsForMultipleOthers; + [Test] + procedure Test_FanOut_MultipleFuturesWaitForOneTrigger; + end; implementation @@ -54,315 +56,342 @@ implementation constructor TLatchNotifierSubscriber.Create(AGateLatch: IMycLatch); begin - inherited Create; - FGateLatch := AGateLatch; + inherited Create; + FGateLatch := AGateLatch; end; function TLatchNotifierSubscriber.Notify: Boolean; begin - if Assigned(FGateLatch) then - begin - FGateLatch.Notify; // Notify the provided gate latch [cite: 80, 215, 333] - end; - Result := False; // This subscriber is typically one-shot for this purpose. + if Assigned(FGateLatch) then + begin + FGateLatch.Notify; // Notify the provided gate latch [cite: 80, 215, 333] + end; + Result := False; // This subscriber is typically one-shot for this purpose. end; { TTestMycGateFuncFuture } procedure TTestMycGateFuncFuture.Setup; begin - FTaskFactory := TMycTaskFactory.Create; // Create a new task factory instance for each test [cite: 113, 235, 353] - FProcExecutionCount := 0; - FSharedCounter := 0; + FTaskFactory := TMycTaskFactory.Create; // Create a new task factory instance for each test [cite: 113, 235, 353] + FProcExecutionCount := 0; + FSharedCounter := 0; end; procedure TTestMycGateFuncFuture.TearDown; begin - if Assigned(FTaskFactory) then - begin - FTaskFactory.Teardown; // Teardown the factory, this may re-raise exceptions [cite: 107, 234, 352] - FTaskFactory := nil; - end; + if Assigned(FTaskFactory) then + begin + FTaskFactory.Teardown; // Teardown the factory, this may re-raise exceptions [cite: 107, 234, 352] + FTaskFactory := nil; + end; end; procedure TTestMycGateFuncFuture.Test_BasicSuccess_WithImmediateInitState; var - LFuture: IMycFuture; - LInitStateAsState: IMycState; // Parameter for Create - LResultValue: Integer; + LFuture: IMycFuture; + LInitStateAsState: IMycState; // Parameter for Create + LResultValue: Integer; const - CExpectedResult = 42; + CExpectedResult = 42; begin - // Use TMycLatch.Null for an already set init state [cite: 71, 81, 206, 216, 324, 334] - LInitStateAsState := TState.Null; + // Use TMycLatch.Null for an already set init state [cite: 71, 81, 206, 216, 324, 334] + LInitStateAsState := TState.Null; - LFuture := TMycGateFuncFuture.Create(FTaskFactory, LInitStateAsState, - function: Integer - begin - Inc(Self.FProcExecutionCount); - Result := CExpectedResult; - end); + LFuture := + TMycGateFuncFuture.Create( + FTaskFactory, + LInitStateAsState, + function: Integer + begin + Inc(Self.FProcExecutionCount); + Result := CExpectedResult; + end + ); - FTaskFactory.WaitFor(LFuture.Done); // Accesses IMycFuture.GetDone [cite: 110, 234, 352] + FTaskFactory.WaitFor(LFuture.Done); // Accesses IMycFuture.GetDone [cite: 110, 234, 352] - Assert.IsTrue(LFuture.Done.IsSet, 'Future should be marked as done.'); // Accesses IMycState.IsSet [cite: 57, 194, 312] - Assert.AreEqual(1, FProcExecutionCount, 'AProc should have been executed once.'); + Assert.IsTrue(LFuture.Done.IsSet, 'Future should be marked as done.'); // Accesses IMycState.IsSet [cite: 57, 194, 312] + Assert.AreEqual(1, FProcExecutionCount, 'AProc should have been executed once.'); - LResultValue := LFuture.GetResult; // Accesses IMycFuture.GetResult - Assert.AreEqual(CExpectedResult, LResultValue, 'GetResult returned an unexpected value.'); + LResultValue := LFuture.GetResult; // Accesses IMycFuture.GetResult + Assert.AreEqual(CExpectedResult, LResultValue, 'GetResult returned an unexpected value.'); end; procedure TTestMycGateFuncFuture.Test_ChainedExecution_WithDelayedInitState; var - LFuture: IMycFuture; - LInitLatch: IMycLatch; - LResultValue: string; + LFuture: IMycFuture; + LInitLatch: IMycLatch; + LResultValue: string; const - CExpectedResult = 'ChainCompleted'; + CExpectedResult = 'ChainCompleted'; begin - LInitLatch := TLatch.Construct(1); // Create an init state that is not yet set [cite: 77, 212, 330] + LInitLatch := TLatch.Construct(1); // Create an init state that is not yet set [cite: 77, 212, 330] - LFuture := TMycGateFuncFuture.Create(FTaskFactory, LInitLatch.State, - function: string - begin - Inc(Self.FProcExecutionCount); - Result := CExpectedResult; - end); + LFuture := + TMycGateFuncFuture.Create( + FTaskFactory, + LInitLatch.State, + function: string + begin + Inc(Self.FProcExecutionCount); + Result := CExpectedResult; + end + ); - Assert.AreEqual(0, FProcExecutionCount, 'AProc should not have executed yet.'); - Assert.IsFalse(LFuture.Done.IsSet, 'Future should not be done yet.'); + Assert.AreEqual(0, FProcExecutionCount, 'AProc should not have executed yet.'); + Assert.IsFalse(LFuture.Done.IsSet, 'Future should not be done yet.'); - LInitLatch.Notify; // Trigger the initial state [cite: 80, 215, 333] + LInitLatch.Notify; // Trigger the initial state [cite: 80, 215, 333] - FTaskFactory.WaitFor(LFuture.Done); + FTaskFactory.WaitFor(LFuture.Done); - Assert.IsTrue(LFuture.Done.IsSet, 'Future should be marked as done after init state trigger.'); - Assert.AreEqual(1, FProcExecutionCount, 'AProc should have been executed once after init state.'); + Assert.IsTrue(LFuture.Done.IsSet, 'Future should be marked as done after init state trigger.'); + Assert.AreEqual(1, FProcExecutionCount, 'AProc should have been executed once after init state.'); - LResultValue := LFuture.GetResult; - Assert.AreEqual(CExpectedResult, LResultValue, 'GetResult returned an unexpected value after delayed init.'); + LResultValue := LFuture.GetResult; + Assert.AreEqual(CExpectedResult, LResultValue, 'GetResult returned an unexpected value after delayed init.'); end; procedure TTestMycGateFuncFuture.Test_ExceptionInProc_HandledAsPlanned; var - LFuture: IMycFuture; - LLocalTaskFactory: IMycTaskFactory; - LInitStateAsState: IMycState; - LResultValue: Integer; - LExpectedExceptionRaisedByFactory: Boolean; + LFuture: IMycFuture; + LLocalTaskFactory: IMycTaskFactory; + LInitStateAsState: IMycState; + LResultValue: Integer; + LExpectedExceptionRaisedByFactory: Boolean; const - CExceptionMessage = 'Test exception from AProc'; + CExceptionMessage = 'Test exception from AProc'; begin - LExpectedExceptionRaisedByFactory := False; - LLocalTaskFactory := TMycTaskFactory.Create; - LInitStateAsState := TState.Null; // Immediate execution + LExpectedExceptionRaisedByFactory := False; + LLocalTaskFactory := TMycTaskFactory.Create; + LInitStateAsState := TState.Null; // Immediate execution - LFuture := TMycGateFuncFuture.Create(LLocalTaskFactory, LInitStateAsState, - function: Integer - begin - Inc(Self.FProcExecutionCount); - raise Exception.Create(CExceptionMessage); - end); + LFuture := + TMycGateFuncFuture.Create( + LLocalTaskFactory, + LInitStateAsState, + function: Integer + begin + Inc(Self.FProcExecutionCount); + raise Exception.Create(CExceptionMessage); + end + ); - try - LLocalTaskFactory.WaitFor(LFuture.Done); - except - on E: Exception do - begin - if E.Message = CExceptionMessage then - LExpectedExceptionRaisedByFactory := True; - end; - end; - - Assert.IsTrue(LFuture.Done.IsSet, 'Future should be done even if AProc raised an exception.'); - Assert.AreEqual(1, FProcExecutionCount, 'AProc (which raised) should have been executed once.'); - - LResultValue := LFuture.GetResult; - Assert.AreEqual(Default(Integer), LResultValue, 'GetResult should return Default(T) when AProc raises an exception.'); - - if not LExpectedExceptionRaisedByFactory then - begin try - LLocalTaskFactory.Teardown; // This should re-raise the exception [cite: 108, 234, 352] + LLocalTaskFactory.WaitFor(LFuture.Done); except - on E: Exception do - begin - Assert.AreEqual(CExceptionMessage, E.Message, 'TaskFactory did not re-raise the correct exception message on Teardown.'); - LExpectedExceptionRaisedByFactory := True; - end; + on E: Exception do + begin + if E.Message = CExceptionMessage then + LExpectedExceptionRaisedByFactory := True; + end; end; - Assert.IsTrue(LExpectedExceptionRaisedByFactory, 'TaskFactory Teardown did not raise any exception as expected.'); - end; - if LExpectedExceptionRaisedByFactory then // Factory was torn down (implicitly or explicitly) and did its job - LLocalTaskFactory := nil - else if Assigned(LLocalTaskFactory) then // Teardown didn't raise as expected, or wasn't called due to earlier exception path - begin - LLocalTaskFactory.Teardown; // Ensure it's torn down if test logic failed to confirm exception - LLocalTaskFactory := nil; - end; + Assert.IsTrue(LFuture.Done.IsSet, 'Future should be done even if AProc raised an exception.'); + Assert.AreEqual(1, FProcExecutionCount, 'AProc (which raised) should have been executed once.'); + + LResultValue := LFuture.GetResult; + Assert.AreEqual(Default(Integer), LResultValue, 'GetResult should return Default(T) when AProc raises an exception.'); + + if not LExpectedExceptionRaisedByFactory then + begin + try + LLocalTaskFactory.Teardown; // This should re-raise the exception [cite: 108, 234, 352] + except + on E: Exception do + begin + Assert.AreEqual(CExceptionMessage, E.Message, 'TaskFactory did not re-raise the correct exception message on Teardown.'); + LExpectedExceptionRaisedByFactory := True; + end; + end; + Assert.IsTrue(LExpectedExceptionRaisedByFactory, 'TaskFactory Teardown did not raise any exception as expected.'); + end; + + if LExpectedExceptionRaisedByFactory then // Factory was torn down (implicitly or explicitly) and did its job + LLocalTaskFactory := nil + else if Assigned(LLocalTaskFactory) then // Teardown didn't raise as expected, or wasn't called due to earlier exception path + begin + LLocalTaskFactory.Teardown; // Ensure it's torn down if test logic failed to confirm exception + LLocalTaskFactory := nil; + end; end; procedure TTestMycGateFuncFuture.Test_GetResult_BeforeDone_RaisesException; var - LFuture: IMycFuture; - LInitLatch: IMycLatch; + LFuture: IMycFuture; + LInitLatch: IMycLatch; begin - LInitLatch := TLatch.Construct(1); + LInitLatch := TLatch.Construct(1); - LFuture := TMycGateFuncFuture.Create(FTaskFactory, LInitLatch.State, - function: Integer - begin - Inc(Self.FProcExecutionCount); - Result := 123; - end); + LFuture := + TMycGateFuncFuture.Create( + FTaskFactory, + LInitLatch.State, + function: Integer + begin + Inc(Self.FProcExecutionCount); + Result := 123; + end + ); - Assert.IsFalse(LFuture.Done.IsSet, 'Future should not be marked as done initially.'); + Assert.IsFalse(LFuture.Done.IsSet, 'Future should not be marked as done initially.'); - Assert.WillRaise( - procedure - begin - LFuture.GetResult; - end ); + Assert.WillRaise(procedure begin LFuture.GetResult; end); - LInitLatch.Notify; + LInitLatch.Notify; - FTaskFactory.WaitFor(LFuture.Done); + FTaskFactory.WaitFor(LFuture.Done); - Assert.WillNotRaise( - procedure - begin - LFuture.GetResult; - end ); + Assert.WillNotRaise(procedure begin LFuture.GetResult; end); end; procedure TTestMycGateFuncFuture.Test_FanIn_OneFutureWaitsForMultipleOthers; var - LPrerequisiteFuture1, LPrerequisiteFuture2: IMycFuture; - LMainFuture: IMycFuture; - LGateLatch: IMycLatch; - LSub1, LSub2: IMycSubscriber; // To hold the TLatchNotifierSubscriber instances - LInitStateP1, LInitStateP2: IMycLatch; - Subscriptions: array[1..2] of TState.TSubscription; // To manage subscriptions + LPrerequisiteFuture1, LPrerequisiteFuture2: IMycFuture; + LMainFuture: IMycFuture; + LGateLatch: IMycLatch; + LSub1, LSub2: IMycSubscriber; // To hold the TLatchNotifierSubscriber instances + LInitStateP1, LInitStateP2: IMycLatch; + Subscriptions: array[1..2] of TState.TSubscription; // To manage subscriptions const - CMainFutureResult = 'AllPrerequisitesCompleted'; + CMainFutureResult = 'AllPrerequisitesCompleted'; begin - FProcExecutionCount := 0; // Reset for this test + FProcExecutionCount := 0; // Reset for this test - // Gate Latch: MainFuture waits for this latch, which needs 2 notifications. - LGateLatch := TLatch.Construct(2); // [cite: 77, 212, 330] + // Gate Latch: MainFuture waits for this latch, which needs 2 notifications. + LGateLatch := TLatch.Construct(2); // [cite: 77, 212, 330] - // Create MainFuture, AInitState is the GateLatch's state. - LMainFuture := TMycGateFuncFuture.Create(FTaskFactory, LGateLatch.State, - function: string - begin - Inc(Self.FProcExecutionCount, 10); // Indicate MainFuture's proc ran - Result := CMainFutureResult; - end); + // Create MainFuture, AInitState is the GateLatch's state. + LMainFuture := + TMycGateFuncFuture.Create( + FTaskFactory, + LGateLatch.State, + function: string + begin + Inc(Self.FProcExecutionCount, 10); // Indicate MainFuture's proc ran + Result := CMainFutureResult; + end + ); - // Setup Prerequisite Futures - // PrerequisiteFuture1 - LInitStateP1 := TLatch.Construct(1); // Controllable init state for PF1 - LPrerequisiteFuture1 := TMycGateFuncFuture.Create(FTaskFactory, LInitStateP1.State, - function: Integer - begin - Inc(Self.FProcExecutionCount, 1); // PF1 ran - Result := 1; - end); - LSub1 := TLatchNotifierSubscriber.Create(LGateLatch); - Subscriptions[1] := LPrerequisiteFuture1.Done.Subscribe(LSub1); // Subscribe to PF1's completion [cite: 56, 188, 306] + // Setup Prerequisite Futures + // PrerequisiteFuture1 + LInitStateP1 := TLatch.Construct(1); // Controllable init state for PF1 + LPrerequisiteFuture1 := + TMycGateFuncFuture.Create( + FTaskFactory, + LInitStateP1.State, + function: Integer + begin + Inc(Self.FProcExecutionCount, 1); // PF1 ran + Result := 1; + end + ); + LSub1 := TLatchNotifierSubscriber.Create(LGateLatch); + Subscriptions[1] := LPrerequisiteFuture1.Done.Subscribe(LSub1); // Subscribe to PF1's completion [cite: 56, 188, 306] - // PrerequisiteFuture2 - LInitStateP2 := TLatch.Construct(1); // Controllable init state for PF2 - LPrerequisiteFuture2 := TMycGateFuncFuture.Create(FTaskFactory, LInitStateP2.State, - function: Integer - begin - Inc(Self.FProcExecutionCount, 1); // PF2 ran - Result := 2; - end); - LSub2 := TLatchNotifierSubscriber.Create(LGateLatch); - Subscriptions[2] := LPrerequisiteFuture2.Done.Subscribe(LSub2); // Subscribe to PF2's completion + // PrerequisiteFuture2 + LInitStateP2 := TLatch.Construct(1); // Controllable init state for PF2 + LPrerequisiteFuture2 := + TMycGateFuncFuture.Create( + FTaskFactory, + LInitStateP2.State, + function: Integer + begin + Inc(Self.FProcExecutionCount, 1); // PF2 ran + Result := 2; + end + ); + LSub2 := TLatchNotifierSubscriber.Create(LGateLatch); + Subscriptions[2] := LPrerequisiteFuture2.Done.Subscribe(LSub2); // Subscribe to PF2's completion - // --- Execution & Verification --- - Assert.IsFalse(LMainFuture.Done.IsSet, 'MainFuture should not be done yet.'); - Assert.AreEqual(0, FProcExecutionCount, 'No AProc should have executed yet.'); + // --- Execution & Verification --- + Assert.IsFalse(LMainFuture.Done.IsSet, 'MainFuture should not be done yet.'); + Assert.AreEqual(0, FProcExecutionCount, 'No AProc should have executed yet.'); - // Trigger PrerequisiteFuture1 - LInitStateP1.Notify; // - FTaskFactory.WaitFor(LPrerequisiteFuture1.Done); // Ensure PF1 completes and notifies GateLatch - Assert.IsFalse(LGateLatch.State.IsSet, 'GateLatch should not be set after only one prerequisite.'); - Assert.IsFalse(LMainFuture.Done.IsSet, 'MainFuture should still not be done.'); - Assert.AreEqual(1, FProcExecutionCount mod 10, 'Only PF1 AProc should have run.'); + // Trigger PrerequisiteFuture1 + LInitStateP1.Notify; // + FTaskFactory.WaitFor(LPrerequisiteFuture1.Done); // Ensure PF1 completes and notifies GateLatch + Assert.IsFalse(LGateLatch.State.IsSet, 'GateLatch should not be set after only one prerequisite.'); + Assert.IsFalse(LMainFuture.Done.IsSet, 'MainFuture should still not be done.'); + Assert.AreEqual(1, FProcExecutionCount mod 10, 'Only PF1 AProc should have run.'); + // Trigger PrerequisiteFuture2 + LInitStateP2.Notify; // + FTaskFactory.WaitFor(LPrerequisiteFuture2.Done); // Ensure PF2 completes and notifies GateLatch - // Trigger PrerequisiteFuture2 - LInitStateP2.Notify; // - FTaskFactory.WaitFor(LPrerequisiteFuture2.Done); // Ensure PF2 completes and notifies GateLatch + // Now GateLatch should be set, and MainFuture should execute + FTaskFactory.WaitFor(LMainFuture.Done); - // Now GateLatch should be set, and MainFuture should execute - FTaskFactory.WaitFor(LMainFuture.Done); + Assert.IsTrue(LGateLatch.State.IsSet, 'GateLatch should be set after both prerequisites.'); + Assert.IsTrue(LMainFuture.Done.IsSet, 'MainFuture should be done now.'); + Assert.AreEqual(12, FProcExecutionCount, 'All AProcs (PF1, PF2, Main) should have run.'); // 1+1+10 + Assert.AreEqual(CMainFutureResult, LMainFuture.GetResult, 'MainFuture returned an unexpected result.'); - Assert.IsTrue(LGateLatch.State.IsSet, 'GateLatch should be set after both prerequisites.'); - Assert.IsTrue(LMainFuture.Done.IsSet, 'MainFuture should be done now.'); - Assert.AreEqual(12, FProcExecutionCount, 'All AProcs (PF1, PF2, Main) should have run.'); // 1+1+10 - Assert.AreEqual(CMainFutureResult, LMainFuture.GetResult, 'MainFuture returned an unexpected result.'); - - // Clean up subscriptions explicitly, though ARC + managed records handle much - Subscriptions[1].Unsubscribe; // [cite: 52, 186, 304] - Subscriptions[2].Unsubscribe; // + // Clean up subscriptions explicitly, though ARC + managed records handle much + Subscriptions[1].Unsubscribe; // [cite: 52, 186, 304] + Subscriptions[2].Unsubscribe; // end; procedure TTestMycGateFuncFuture.Test_FanOut_MultipleFuturesWaitForOneTrigger; var - LTriggerLatch: IMycLatch; - LFutureA, LFutureB: IMycFuture; - LFlagFutureARan, LFlagFutureBRan: Boolean; + LTriggerLatch: IMycLatch; + LFutureA, LFutureB: IMycFuture; + LFlagFutureARan, LFlagFutureBRan: Boolean; begin - LFlagFutureARan := False; - LFlagFutureBRan := False; - Self.FSharedCounter := 0; // Reset shared counter for this test + LFlagFutureARan := False; + LFlagFutureBRan := False; + Self.FSharedCounter := 0; // Reset shared counter for this test - LTriggerLatch := TLatch.Construct(1); // Single trigger [cite: 77, 212, 330] + LTriggerLatch := TLatch.Construct(1); // Single trigger [cite: 77, 212, 330] - // Future A - LFutureA := TMycGateFuncFuture.Create(FTaskFactory, LTriggerLatch.State, - function: Integer - begin - LFlagFutureARan := True; - System.SyncObjs.TInterlocked.Increment(Self.FSharedCounter); // Thread-safe increment - Result := 100; - end); + // Future A + LFutureA := + TMycGateFuncFuture.Create( + FTaskFactory, + LTriggerLatch.State, + function: Integer + begin + LFlagFutureARan := True; + System.SyncObjs.TInterlocked.Increment(Self.FSharedCounter); // Thread-safe increment + Result := 100; + end + ); - // Future B - LFutureB := TMycGateFuncFuture.Create(FTaskFactory, LTriggerLatch.State, - function: Integer - begin - LFlagFutureBRan := True; - System.SyncObjs.TInterlocked.Increment(Self.FSharedCounter); // Thread-safe increment - Result := 200; - end); + // Future B + LFutureB := + TMycGateFuncFuture.Create( + FTaskFactory, + LTriggerLatch.State, + function: Integer + begin + LFlagFutureBRan := True; + System.SyncObjs.TInterlocked.Increment(Self.FSharedCounter); // Thread-safe increment + Result := 200; + end + ); - Assert.IsFalse(LFutureA.Done.IsSet, 'FutureA should not be done yet.'); - Assert.IsFalse(LFutureB.Done.IsSet, 'FutureB should not be done yet.'); - Assert.AreEqual(0, Self.FSharedCounter, 'No future AProcs should have executed yet.'); + Assert.IsFalse(LFutureA.Done.IsSet, 'FutureA should not be done yet.'); + Assert.IsFalse(LFutureB.Done.IsSet, 'FutureB should not be done yet.'); + Assert.AreEqual(0, Self.FSharedCounter, 'No future AProcs should have executed yet.'); - // Trigger the common latch - LTriggerLatch.Notify; // [cite: 80, 215, 333] + // Trigger the common latch + LTriggerLatch.Notify; // [cite: 80, 215, 333] - // Wait for both futures to complete - FTaskFactory.WaitFor(LFutureA.Done); - FTaskFactory.WaitFor(LFutureB.Done); + // Wait for both futures to complete + FTaskFactory.WaitFor(LFutureA.Done); + FTaskFactory.WaitFor(LFutureB.Done); - Assert.IsTrue(LFutureA.Done.IsSet, 'FutureA should be done.'); - Assert.IsTrue(LFutureB.Done.IsSet, 'FutureB should be done.'); - Assert.IsTrue(LFlagFutureARan, 'FutureA AProc should have run.'); - Assert.IsTrue(LFlagFutureBRan, 'FutureB AProc should have run.'); - Assert.AreEqual(2, Self.FSharedCounter, 'Both future AProcs should have incremented the counter.'); - Assert.AreEqual(100, LFutureA.GetResult, 'FutureA GetResult value mismatch.'); - Assert.AreEqual(200, LFutureB.GetResult, 'FutureB GetResult value mismatch.'); + Assert.IsTrue(LFutureA.Done.IsSet, 'FutureA should be done.'); + Assert.IsTrue(LFutureB.Done.IsSet, 'FutureB should be done.'); + Assert.IsTrue(LFlagFutureARan, 'FutureA AProc should have run.'); + Assert.IsTrue(LFlagFutureBRan, 'FutureB AProc should have run.'); + Assert.AreEqual(2, Self.FSharedCounter, 'Both future AProcs should have incremented the counter.'); + Assert.AreEqual(100, LFutureA.GetResult, 'FutureA GetResult value mismatch.'); + Assert.AreEqual(200, LFutureB.GetResult, 'FutureB GetResult value mismatch.'); end; initialization - // For DUnitX, attributes typically handle registration. - // If needed for older DUnit: RegisterTest(TTestMycGateFuncFuture.Suite); + // For DUnitX, attributes typically handle registration. + // If needed for older DUnit: RegisterTest(TTestMycGateFuncFuture.Suite); end. diff --git a/Test/TestFutures.pas b/Test/TestFutures.pas index 1a2d1eb..528379a 100644 --- a/Test/TestFutures.pas +++ b/Test/TestFutures.pas @@ -16,7 +16,7 @@ uses type [TestFixture] - TTestFuture = class( TObject ) + TTestFuture = class(TObject) public [Setup] procedure Setup; @@ -38,9 +38,9 @@ type [Test] procedure TestMultipleChains; [Test] - [TestCase( 'StringFutureTest', 'Test String' )] - [TestCase( 'IntegerFutureTestForParam', '12345' )] - procedure TestConstructSimple_Parametric( const ParamValue: string ); + [TestCase('StringFutureTest', 'Test String')] + [TestCase('IntegerFutureTestForParam', '12345')] + procedure TestConstructSimple_Parametric(const ParamValue: string); [Test] procedure TestStress_StateAll; @@ -59,7 +59,7 @@ implementation procedure TTestFuture.Setup; begin -// SetupTaskManagerMock; + // SetupTaskManagerMock; end; procedure TTestFuture.TearDown; @@ -74,20 +74,21 @@ var resultValue: Integer; begin // Test construction with a simple function that returns an Integer - fut := TFuture.Construct( // [cite: 146] - function: Integer - begin - TThread.Sleep( 20 ); // Simulate some background work - Result := 42; - end - ); + fut := + TFuture.Construct( // [cite: 146] + function: Integer + begin + TThread.Sleep(20); // Simulate some background work + Result := 42; + end + ); - Assert.IsNotNull( fut.Done, 'Future.Done property should not be nil after construction.' ); // Static string [cite: 148] - fut.WaitFor( ); // Wait for the future to complete its execution [cite: 148] + Assert.IsNotNull(fut.Done, 'Future.Done property should not be nil after construction.'); // Static string [cite: 148] + fut.WaitFor(); // Wait for the future to complete its execution [cite: 148] - Assert.IsTrue( fut.Done.IsSet, 'Future.Done.IsSet should be true after completion.' ); // Static string [cite: 148] + Assert.IsTrue(fut.Done.IsSet, 'Future.Done.IsSet should be true after completion.'); // Static string [cite: 148] resultValue := fut.Result; // Retrieve the result of the future [cite: 148] - Assert.AreEqual( 42, resultValue, 'The result of the future is not the expected value.' ); // Static string + Assert.AreEqual(42, resultValue, 'The result of the future is not the expected value.'); // Static string end; [Test] @@ -97,20 +98,22 @@ var resultValue: Integer; begin // Test construction with a nil gate, which should execute the task immediately - fut := TFuture.Construct( nil, // Explicitly providing a nil gate [cite: 147] - function: Integer - begin - TThread.Sleep( 20 ); // Simulate work - Result := 43; - end - ); + fut := + TFuture.Construct( + nil, // Explicitly providing a nil gate [cite: 147] + function: Integer + begin + TThread.Sleep(20); // Simulate work + Result := 43; + end + ); - Assert.IsNotNull( fut.Done, 'Future.Done should not be nil when constructed with a nil gate.' ); // Static string [cite: 148] - fut.WaitFor( ); // [cite: 148] + Assert.IsNotNull(fut.Done, 'Future.Done should not be nil when constructed with a nil gate.'); // Static string [cite: 148] + fut.WaitFor(); // [cite: 148] - Assert.IsTrue( fut.Done.IsSet, 'Future.Done.IsSet should be true for nil gate construct.' ); // Static string [cite: 148] + Assert.IsTrue(fut.Done.IsSet, 'Future.Done.IsSet should be true for nil gate construct.'); // Static string [cite: 148] resultValue := fut.Result; // [cite: 148] - Assert.AreEqual( 43, resultValue, 'Future result is incorrect for nil gate construct.' ); // Static string + Assert.AreEqual(43, resultValue, 'Future result is incorrect for nil gate construct.'); // Static string end; [Test] @@ -121,22 +124,24 @@ var resultValue: Integer; begin presetGate := TState.Null; // State.Null is an IMycState that is always set [cite: 68] - Assert.IsTrue( presetGate.IsSet, 'The preset gate (State.Null) should be initially set.' ); // Static string [cite: 55] + Assert.IsTrue(presetGate.IsSet, 'The preset gate (State.Null) should be initially set.'); // Static string [cite: 55] // Construct a future with a gate that is already set - fut := TFuture.Construct( presetGate, // [cite: 147] - function: Integer - begin - Result := 44; // This should execute quickly - end - ); + fut := + TFuture.Construct( + presetGate, // [cite: 147] + function: Integer + begin + Result := 44; // This should execute quickly + end + ); - Assert.IsNotNull( fut.Done, 'Future.Done should not be nil for preset gate construct.' ); // Static string [cite: 148] - fut.WaitFor( ); // [cite: 148] + Assert.IsNotNull(fut.Done, 'Future.Done should not be nil for preset gate construct.'); // Static string [cite: 148] + fut.WaitFor(); // [cite: 148] - Assert.IsTrue( fut.Done.IsSet, 'Future.Done.IsSet should be true for preset gate construct.' ); // Static string [cite: 148] + Assert.IsTrue(fut.Done.IsSet, 'Future.Done.IsSet should be true for preset gate construct.'); // Static string [cite: 148] resultValue := fut.Result; // [cite: 148] - Assert.AreEqual( 44, resultValue, 'Future result is incorrect for preset gate construct.' ); // Static string + Assert.AreEqual(44, resultValue, 'Future result is incorrect for preset gate construct.'); // Static string end; [Test] @@ -146,34 +151,33 @@ var delayedGate: IMycLatch; // IMycLatch implements IMycState [cite: 58] resultValue: Integer; begin - delayedGate := TLatch.Construct( 1 ); // Create a latch that requires one notification to be set [cite: 66] - Assert.IsNotNull( delayedGate, 'The delayed gate (IMycLatch) should not be nil.' ); // Static string - Assert.IsFalse( delayedGate.State.IsSet, 'The delayed gate should not be initially set.' ); // Static string [cite: 59, 55] + delayedGate := TLatch.Construct(1); // Create a latch that requires one notification to be set [cite: 66] + Assert.IsNotNull(delayedGate, 'The delayed gate (IMycLatch) should not be nil.'); // Static string + Assert.IsFalse(delayedGate.State.IsSet, 'The delayed gate should not be initially set.'); // Static string [cite: 59, 55] // Construct a future with a gate that is not yet set - fut := TFuture.Construct( delayedGate.State, // Get the IMycState interface from the latch [cite: 147, 59] - function: Integer - begin - Result := 45; - end - ); + fut := + TFuture.Construct( + delayedGate.State, // Get the IMycState interface from the latch [cite: 147, 59] + function: Integer begin Result := 45; end + ); - Assert.IsNotNull( fut.Done, 'Future.Done should not be nil for delayed gate construct.' ); // Static string [cite: 148] + Assert.IsNotNull(fut.Done, 'Future.Done should not be nil for delayed gate construct.'); // Static string [cite: 148] // Verify the future is not yet done as the gate is not set - TThread.Sleep( 50 ); // Allow some time for task scheduling - Assert.IsFalse( fut.Done.IsSet, 'Future.Done.IsSet should be false before the delayed gate is triggered.' ); + TThread.Sleep(50); // Allow some time for task scheduling + Assert.IsFalse(fut.Done.IsSet, 'Future.Done.IsSet should be false before the delayed gate is triggered.'); // Static string [cite: 148, 55] delayedGate.Notify; // Trigger the latch [cite: 46, 94] (IMycSubscriber.Notify) - fut.WaitFor( ); // Wait for the future to complete now that the gate is set [cite: 148] + fut.WaitFor(); // Wait for the future to complete now that the gate is set [cite: 148] - Assert.IsTrue( delayedGate.State.IsSet, 'The delayed gate should be set after Notify.' ); // Static string [cite: 59, 55] - Assert.IsTrue( fut.Done.IsSet, 'Future.Done.IsSet should be true after the delayed gate is triggered.' ); + Assert.IsTrue(delayedGate.State.IsSet, 'The delayed gate should be set after Notify.'); // Static string [cite: 59, 55] + Assert.IsTrue(fut.Done.IsSet, 'Future.Done.IsSet should be true after the delayed gate is triggered.'); // Static string [cite: 148, 55] resultValue := fut.Result; // [cite: 148] - Assert.AreEqual( 45, resultValue, 'Future result is incorrect for delayed gate construct.' ); // Static string + Assert.AreEqual(45, resultValue, 'Future result is incorrect for delayed gate construct.'); // Static string end; [Test] @@ -184,29 +188,31 @@ var resultValue: string; begin // Create an initial future - fut1 := TFuture.Construct( // [cite: 146] - function: Integer - begin - TThread.Sleep( 20 ); // Simulate work - Result := 100; - end - ); + fut1 := + TFuture.Construct( // [cite: 146] + function: Integer + begin + TThread.Sleep(20); // Simulate work + Result := 100; + end + ); // Chain a second future that depends on the result of the first - fut2 := fut1.Chain( // [cite: 147] - function( Input: Integer ): string // This function receives the result of fut1 - begin - TThread.Sleep( 20 ); // Simulate further work - Result := 'Value: ' + Input.ToString; // Use ToString for converting Integer to String - end - ); + fut2 := + fut1.Chain( // [cite: 147] + function(Input: Integer): string // This function receives the result of fut1 + begin + TThread.Sleep(20); // Simulate further work + Result := 'Value: ' + Input.ToString; // Use ToString for converting Integer to String + end + ); - Assert.IsNotNull( fut2.Done, 'Chained Future.Done should not be nil.' ); // Static string [cite: 148] - fut2.WaitFor( ); // Wait for the chained future to complete [cite: 148] + Assert.IsNotNull(fut2.Done, 'Chained Future.Done should not be nil.'); // Static string [cite: 148] + fut2.WaitFor(); // Wait for the chained future to complete [cite: 148] - Assert.IsTrue( fut2.Done.IsSet, 'Chained Future.Done.IsSet should be true after completion.' ); // Static string [cite: 148, 55] + Assert.IsTrue(fut2.Done.IsSet, 'Chained Future.Done.IsSet should be true after completion.'); // Static string [cite: 148, 55] resultValue := fut2.Result; // [cite: 148] - Assert.AreEqual( 'Value: 100', resultValue, 'Chained Future result is incorrect.' ); // Static string + Assert.AreEqual('Value: 100', resultValue, 'Chained Future result is incorrect.'); // Static string end; [Test] @@ -217,42 +223,39 @@ var delayedGate: IMycLatch; resultValue: string; begin - delayedGate := TLatch.Construct( 1 ); // [cite: 66] - Assert.IsFalse( delayedGate.State.IsSet, 'The delayed gate for chain test should not be initially set.' ); + delayedGate := TLatch.Construct(1); // [cite: 66] + Assert.IsFalse(delayedGate.State.IsSet, 'The delayed gate for chain test should not be initially set.'); // Static string [cite: 59, 55] // First future depends on the delayedGate - fut1 := TFuture.Construct( delayedGate.State, // [cite: 147, 59] - function: Integer - begin - Result := 200; - end - ); + fut1 := + TFuture.Construct( + delayedGate.State, // [cite: 147, 59] + function: Integer begin Result := 200; end + ); // Second future is chained to the first - fut2 := fut1.Chain( // [cite: 147] - function( Input: Integer ): string - begin - Result := 'ChainVal: ' + Input.ToString; - end - ); + fut2 := + fut1.Chain( // [cite: 147] + function(Input: Integer): string begin Result := 'ChainVal: ' + Input.ToString; end + ); - Assert.IsNotNull( fut2.Done, 'Chained (with gate) Future.Done should not be nil.' ); // Static string [cite: 148] + Assert.IsNotNull(fut2.Done, 'Chained (with gate) Future.Done should not be nil.'); // Static string [cite: 148] // Verify futures are not done yet - TThread.Sleep( 50 ); - Assert.IsFalse( fut1.Done.IsSet, 'Initial future (gated) should not be done before gate is set.' ); // Static string [cite: 148, 55] - Assert.IsFalse( fut2.Done.IsSet, 'Chained future (gated) should not be done before gate is set.' ); // Static string [cite: 148, 55] + TThread.Sleep(50); + Assert.IsFalse(fut1.Done.IsSet, 'Initial future (gated) should not be done before gate is set.'); // Static string [cite: 148, 55] + Assert.IsFalse(fut2.Done.IsSet, 'Chained future (gated) should not be done before gate is set.'); // Static string [cite: 148, 55] delayedGate.Notify; // Trigger the gate [cite: 46, 94] - fut2.WaitFor( ); // Wait for the final chained future to complete [cite: 148] + fut2.WaitFor(); // Wait for the final chained future to complete [cite: 148] - Assert.IsTrue( fut1.Done.IsSet, 'Initial future (gated) should be done after gate is set.' ); // Static string [cite: 148, 55] - Assert.IsTrue( fut2.Done.IsSet, 'Chained future (gated) should be done after gate is set.' ); // Static string [cite: 148, 55] + Assert.IsTrue(fut1.Done.IsSet, 'Initial future (gated) should be done after gate is set.'); // Static string [cite: 148, 55] + Assert.IsTrue(fut2.Done.IsSet, 'Chained future (gated) should be done after gate is set.'); // Static string [cite: 148, 55] resultValue := fut2.Result; // [cite: 148] - Assert.AreEqual( 'ChainVal: 200', resultValue, 'Chained future (gated) result is incorrect.' ); // Static string + Assert.AreEqual('ChainVal: 200', resultValue, 'Chained future (gated) result is incorrect.'); // Static string end; [Test] @@ -264,67 +267,71 @@ var finalResult: string; begin // Initial future A - futA := TFuture.Construct( // [cite: 146] - function: Integer - begin - TThread.Sleep( 10 ); - Result := 10; - end - ); + futA := + TFuture.Construct( // [cite: 146] + function: Integer + begin + TThread.Sleep(10); + Result := 10; + end + ); // Future B, chained from A - futB := futA.Chain( // [cite: 147] - function( InputA: Integer ): Real - begin - TThread.Sleep( 10 ); - Result := InputA * 2.5; // Calculation: 10 * 2.5 = 25.0 - end - ); + futB := + futA.Chain( // [cite: 147] + function(InputA: Integer): Real + begin + TThread.Sleep(10); + Result := InputA * 2.5; // Calculation: 10 * 2.5 = 25.0 + end + ); // Future C, chained from B - futC := futB.Chain( // [cite: 147] - function( InputB: Real ): string - begin - TThread.Sleep( 10 ); - Result := 'Final: ' + FloatToStr( InputB ); // Convert Real to String - end - ); + futC := + futB.Chain( // [cite: 147] + function(InputB: Real): string + begin + TThread.Sleep(10); + Result := 'Final: ' + FloatToStr(InputB); // Convert Real to String + end + ); - Assert.IsNotNull( futC.Done, 'Multi-chained Future.Done should not be nil.' ); // Static string [cite: 148] - futC.WaitFor( ); // Wait for the last future in the chain [cite: 148] + Assert.IsNotNull(futC.Done, 'Multi-chained Future.Done should not be nil.'); // Static string [cite: 148] + futC.WaitFor(); // Wait for the last future in the chain [cite: 148] - Assert.IsTrue( futA.Done.IsSet, 'Future A in chain should be done.' ); // Static string [cite: 148, 55] - Assert.IsTrue( futB.Done.IsSet, 'Future B in chain should be done.' ); // Static string [cite: 148, 55] - Assert.IsTrue( futC.Done.IsSet, 'Future C (multi-chained) should be done.' ); // Static string [cite: 148, 55] + Assert.IsTrue(futA.Done.IsSet, 'Future A in chain should be done.'); // Static string [cite: 148, 55] + Assert.IsTrue(futB.Done.IsSet, 'Future B in chain should be done.'); // Static string [cite: 148, 55] + Assert.IsTrue(futC.Done.IsSet, 'Future C (multi-chained) should be done.'); // Static string [cite: 148, 55] finalResult := futC.Result; // [cite: 148] // Ensure FloatToStr conversion is consistent for comparison - Assert.AreEqual( 'Final: ' + FloatToStr( 25.0 ), finalResult, 'Multi-chained Future result is incorrect.' ); // Static string + Assert.AreEqual('Final: ' + FloatToStr(25.0), finalResult, 'Multi-chained Future result is incorrect.'); // Static string end; [Test] -[TestCase( 'StringFutureTest', 'Test String' )] -[TestCase( 'IntegerFutureTestForParam', '12345' )] -procedure TTestFuture.TestConstructSimple_Parametric( const ParamValue: string ); +[TestCase('StringFutureTest', 'Test String')] +[TestCase('IntegerFutureTestForParam', '12345')] +procedure TTestFuture.TestConstructSimple_Parametric(const ParamValue: string); var fut: TFuture; resultValue: string; begin // Parametric test for Future - fut := TFuture.Construct( // [cite: 146] - function: string - begin - TThread.Sleep( 10 ); - Result := ParamValue; // Use the parameter in the future's function - end - ); + fut := + TFuture.Construct( // [cite: 146] + function: string + begin + TThread.Sleep(10); + Result := ParamValue; // Use the parameter in the future's function + end + ); - Assert.IsNotNull( fut.Done, 'Parametric Future.Done should not be nil.' ); // Static string [cite: 148] - fut.WaitFor( ); // [cite: 148] + Assert.IsNotNull(fut.Done, 'Parametric Future.Done should not be nil.'); // Static string [cite: 148] + fut.WaitFor(); // [cite: 148] - Assert.IsTrue( fut.Done.IsSet, 'Parametric Future.Done.IsSet should be true.' ); // Static string [cite: 148, 55] + Assert.IsTrue(fut.Done.IsSet, 'Parametric Future.Done.IsSet should be true.'); // Static string [cite: 148, 55] resultValue := fut.Result; // [cite: 148] - Assert.AreEqual( ParamValue, resultValue, 'Parametric Future result does not match input parameter.' ); // Static string + Assert.AreEqual(ParamValue, resultValue, 'Parametric Future result does not match input parameter.'); // Static string end; [Test] @@ -338,53 +345,58 @@ var masterFuture: TFuture; i: Integer; begin - SetLength( Futures, StressTestFutureCount ); - SetLength( doneStates, StressTestFutureCount ); + SetLength(Futures, StressTestFutureCount); + SetLength(doneStates, StressTestFutureCount); Randomize; // Initialize random number generator for varied delays // Create multiple futures, each with a small random delay - for i := 0 to High( Futures ) do + for i := 0 to High(Futures) do begin // Capture loop variable for use in anonymous method - Futures[i] := TFuture.Construct( // [cite: 146] - ( - function( captureIndex: Integer ): TFunc - begin - Result := function: Integer - var - delay: Integer; - begin - delay := 10 + Random( 40 ); // Random delay between 10ms and 49ms - TThread.Sleep( delay ); - Result := captureIndex; // Return the captured index - end; - end )( i ) - ); + Futures[i] := + TFuture.Construct( // [cite: 146] + ( + function(captureIndex: Integer): TFunc + begin + Result := + function: Integer + var + delay: Integer; + begin + delay := 10 + Random(40); // Random delay between 10ms and 49ms + TThread.Sleep(delay); + Result := captureIndex; // Return the captured index + end; + end + )(i) + ); doneStates[i] := Futures[i].Done; // [cite: 148] end; - combinedStateAll := TState.All( doneStates ); // [cite: 67] - Assert.IsNotNull( combinedStateAll, 'State.All should return a valid IMycState.' ); // Static string + combinedStateAll := TState.All(doneStates); // [cite: 67] + Assert.IsNotNull(combinedStateAll, 'State.All should return a valid IMycState.'); // Static string // Create a master future that waits on the combined State.All state - masterFuture := TFuture.Construct( combinedStateAll, // [cite: 147] - function: Boolean - begin - Result := True; // This function executes when combinedStateAll is set - end - ); - masterFuture.WaitFor( ); // Wait for all futures to complete via the master future [cite: 148] + masterFuture := + TFuture.Construct( + combinedStateAll, // [cite: 147] + function: Boolean + begin + Result := True; // This function executes when combinedStateAll is set + end + ); + masterFuture.WaitFor(); // Wait for all futures to complete via the master future [cite: 148] - Assert.IsTrue( combinedStateAll.IsSet, 'Combined State.All should be set after masterFuture.WaitFor().' ); // Static string [cite: 55] + Assert.IsTrue(combinedStateAll.IsSet, 'Combined State.All should be set after masterFuture.WaitFor().'); // Static string [cite: 55] // Verify all individual futures are done and their results are correct - for i := 0 to High( Futures ) do + for i := 0 to High(Futures) do begin - Assert.IsTrue( Futures[i].Done.IsSet, 'An individual future was not set after State.All completed.' ); + Assert.IsTrue(Futures[i].Done.IsSet, 'An individual future was not set after State.All completed.'); // Static string [cite: 148, 55] if Futures[i].Done.IsSet then // Additional check to safely access Result begin - Assert.AreEqual( i, Futures[i].Result, 'A future''s result was incorrect in State.All stress test.' ); + Assert.AreEqual(i, Futures[i].Result, 'A future''s result was incorrect in State.All stress test.'); // Static string [cite: 148] end; end; @@ -403,65 +415,70 @@ var i: Integer; isAtLeastOneSet: Boolean; begin - SetLength( Futures, StressTestFutureCount ); - SetLength( doneStates, StressTestFutureCount ); + SetLength(Futures, StressTestFutureCount); + SetLength(doneStates, StressTestFutureCount); Randomize; // Initialize random number generator // Create multiple futures, one of which is designed to finish quickly - for i := 0 to High( Futures ) do + for i := 0 to High(Futures) do begin // Capture loop variable - Futures[i] := TFuture.Construct( // [cite: 146] - ( - function( captureIndex: Integer ): TFunc - begin - Result := function: Integer - var - delay: Integer; - begin - if captureIndex = QuickFutureIndex then - delay := 5 // Short delay for the 'quick' future - else - delay := 50 + Random( 100 ); // Longer random delay (50-149ms) for others - TThread.Sleep( delay ); - Result := captureIndex; - end; - end )( i ) - ); + Futures[i] := + TFuture.Construct( // [cite: 146] + ( + function(captureIndex: Integer): TFunc + begin + Result := + function: Integer + var + delay: Integer; + begin + if captureIndex = QuickFutureIndex then + delay := 5 // Short delay for the 'quick' future + else + delay := 50 + Random(100); // Longer random delay (50-149ms) for others + TThread.Sleep(delay); + Result := captureIndex; + end; + end + )(i) + ); doneStates[i] := Futures[i].Done; // [cite: 148] end; - combinedStateAny := TState.Any( doneStates ); // [cite: 68] - Assert.IsNotNull( combinedStateAny, 'State.Any should return a valid IMycState.' ); // Static string + combinedStateAny := TState.Any(doneStates); // [cite: 68] + Assert.IsNotNull(combinedStateAny, 'State.Any should return a valid IMycState.'); // Static string // Create a master future that waits on the combined State.Any state - masterFuture := TFuture.Construct( combinedStateAny, // [cite: 147] - function: Boolean - begin - Result := True; // This function executes when combinedStateAny is set - end - ); - masterFuture.WaitFor( ); // Wait for at least one future to complete [cite: 148] + masterFuture := + TFuture.Construct( + combinedStateAny, // [cite: 147] + function: Boolean + begin + Result := True; // This function executes when combinedStateAny is set + end + ); + masterFuture.WaitFor(); // Wait for at least one future to complete [cite: 148] - Assert.IsTrue( combinedStateAny.IsSet, 'Combined State.Any should be set after masterFuture.WaitFor().' ); // Static string [cite: 55] + Assert.IsTrue(combinedStateAny.IsSet, 'Combined State.Any should be set after masterFuture.WaitFor().'); // Static string [cite: 55] // Verify that at least one of the original futures is now set isAtLeastOneSet := False; - for i := 0 to High( Futures ) do + for i := 0 to High(Futures) do begin if Futures[i].Done.IsSet then // [cite: 148, 55] begin isAtLeastOneSet := True; end; end; - Assert.IsTrue( isAtLeastOneSet, 'At least one underlying future should be set after State.Any completed.' ); // Static string + Assert.IsTrue(isAtLeastOneSet, 'At least one underlying future should be set after State.Any completed.'); // Static string // It's good practice to ensure all futures complete - for i := 0 to High( Futures ) do + for i := 0 to High(Futures) do begin if not Futures[i].Done.IsSet then // [cite: 148, 55] begin - Futures[i].WaitFor( ); // Wait for any remaining futures [cite: 148] + Futures[i].WaitFor(); // Wait for any remaining futures [cite: 148] end; end; end; @@ -474,32 +491,34 @@ var finalResult: Integer; begin // Create an outer future that, when resolved, produces another (inner) future. - outerFuture := TFuture < TFuture < Integer >>.Construct( // [cite: 146] - function: TFuture // This lambda returns a Future - begin - TThread.Sleep( 10 ); // Simulate work for the outer future to produce the inner one - Result := TFuture.Construct( // [cite: 146] - function: Integer - begin - TThread.Sleep( 10 ); // Simulate work for the inner future - Result := 123; // The final value - end - ); - end - ); + outerFuture := + TFuture>.Construct( // [cite: 146] + function: TFuture // This lambda returns a Future + begin + TThread.Sleep(10); // Simulate work for the outer future to produce the inner one + Result := + TFuture.Construct( // [cite: 146] + function: Integer + begin + TThread.Sleep(10); // Simulate work for the inner future + Result := 123; // The final value + end + ); + end + ); - Assert.IsNotNull( outerFuture.Done, 'Outer future''s Done state should not be nil.' ); // Static string [cite: 148] - outerFuture.WaitFor( ); // Wait for the outer future to complete and yield the inner future [cite: 148] - Assert.IsTrue( outerFuture.Done.IsSet, 'Outer future should be done after WaitFor.' ); // Static string [cite: 148, 55] + Assert.IsNotNull(outerFuture.Done, 'Outer future''s Done state should not be nil.'); // Static string [cite: 148] + outerFuture.WaitFor(); // Wait for the outer future to complete and yield the inner future [cite: 148] + Assert.IsTrue(outerFuture.Done.IsSet, 'Outer future should be done after WaitFor.'); // Static string [cite: 148, 55] innerFuture := outerFuture.Result; // Retrieve the inner future [cite: 148] - Assert.IsNotNull( innerFuture.Done, 'Inner future (from outer.Result) should have a non-nil Done state.' ); // Static string [cite: 148] + Assert.IsNotNull(innerFuture.Done, 'Inner future (from outer.Result) should have a non-nil Done state.'); // Static string [cite: 148] - innerFuture.WaitFor( ); // Wait for the inner future to complete and yield the final result [cite: 148] - Assert.IsTrue( innerFuture.Done.IsSet, 'Inner future should be done after its WaitFor.' ); // Static string [cite: 148, 55] + innerFuture.WaitFor(); // Wait for the inner future to complete and yield the final result [cite: 148] + Assert.IsTrue(innerFuture.Done.IsSet, 'Inner future should be done after its WaitFor.'); // Static string [cite: 148, 55] finalResult := innerFuture.Result; // Retrieve the final integer result [cite: 148] - Assert.AreEqual( 123, finalResult, 'Nested future final result from Construct is incorrect.' ); // Static string + Assert.AreEqual(123, finalResult, 'Nested future final result from Construct is incorrect.'); // Static string end; [Test] @@ -511,43 +530,46 @@ var finalResult: string; begin // Create an initial future - initialFuture := TFuture.Construct( // [cite: 146] - function: Integer - begin - TThread.Sleep( 10 ); - Result := 77; - end - ); + initialFuture := + TFuture.Construct( // [cite: 146] + function: Integer + begin + TThread.Sleep(10); + Result := 77; + end + ); // Chain it with a function that itself returns a new Future - outerChainedFuture := initialFuture.Chain < TFuture < string >> ( // [cite: 147] - function( Input: Integer ): TFuture // This lambda returns a Future - begin - TThread.Sleep( 10 ); // Simulate work in the chain function - // Input is the result of initialFuture (77) - Result := TFuture.Construct( // [cite: 146] - function: string - begin - TThread.Sleep( 10 ); // Simulate work for the inner-most future - Result := 'Value: ' + Input.ToString; // Input is captured (77) - end - ); - end - ); + outerChainedFuture := + initialFuture.Chain>( // [cite: 147] + function(Input: Integer): TFuture // This lambda returns a Future + begin + TThread.Sleep(10); // Simulate work in the chain function + // Input is the result of initialFuture (77) + Result := + TFuture.Construct( // [cite: 146] + function: string + begin + TThread.Sleep(10); // Simulate work for the inner-most future + Result := 'Value: ' + Input.ToString; // Input is captured (77) + end + ); + end + ); - Assert.IsNotNull( outerChainedFuture.Done, 'Outer chained future''s Done state should not be nil.' ); // Static string [cite: 148] - outerChainedFuture.WaitFor( ); // Wait for initialFuture to complete AND the chain function to execute [cite: 148] - Assert.IsTrue( outerChainedFuture.Done.IsSet, 'Outer chained future should be done after WaitFor.' ); // Static string [cite: 148, 55] + Assert.IsNotNull(outerChainedFuture.Done, 'Outer chained future''s Done state should not be nil.'); // Static string [cite: 148] + outerChainedFuture.WaitFor(); // Wait for initialFuture to complete AND the chain function to execute [cite: 148] + Assert.IsTrue(outerChainedFuture.Done.IsSet, 'Outer chained future should be done after WaitFor.'); // Static string [cite: 148, 55] innerStringFuture := outerChainedFuture.Result; // Get the Future produced by the chain function [cite: 148] - Assert.IsNotNull( innerStringFuture.Done, 'Inner string future (from chain) should have a non-nil Done state.' ); + Assert.IsNotNull(innerStringFuture.Done, 'Inner string future (from chain) should have a non-nil Done state.'); // Static string [cite: 148] - innerStringFuture.WaitFor( ); // Wait for the inner Future to complete [cite: 148] - Assert.IsTrue( innerStringFuture.Done.IsSet, 'Inner string future should be done after its WaitFor.' ); // Static string [cite: 148, 55] + innerStringFuture.WaitFor(); // Wait for the inner Future to complete [cite: 148] + Assert.IsTrue(innerStringFuture.Done.IsSet, 'Inner string future should be done after its WaitFor.'); // Static string [cite: 148, 55] finalResult := innerStringFuture.Result; // Get the final string result [cite: 148] - Assert.AreEqual( 'Value: 77', finalResult, 'Nested future (via Chain) final result is incorrect.' ); // Static string + Assert.AreEqual('Value: 77', finalResult, 'Nested future (via Chain) final result is incorrect.'); // Static string end; end. diff --git a/Test/TestNotifier.pas b/Test/TestNotifier.pas index c808486..8d307b9 100644 --- a/Test/TestNotifier.pas +++ b/Test/TestNotifier.pas @@ -9,19 +9,19 @@ uses type // Dummy interface and class for testing - IMyTestInterface = interface( IInterface ) + IMyTestInterface = interface(IInterface) ['{7A8C1A01-1C6B-4A7A-B9D8-28E6A8D02A0F}'] // Unique GUID procedure Foo; function GetValue: Integer; end; - TMyTestReceiver = class( TInterfacedObject, IMyTestInterface ) + TMyTestReceiver = class(TInterfacedObject, IMyTestInterface) private FValue: Integer; FCallCount: Integer; public - constructor Create( AValue: Integer ); + constructor Create(AValue: Integer); procedure Foo; function GetValue: Integer; property CallCount: Integer read FCallCount write FCallCount; @@ -53,7 +53,7 @@ implementation { TMyTestReceiver } -constructor TMyTestReceiver.Create( AValue: Integer ); +constructor TMyTestReceiver.Create(AValue: Integer); begin inherited Create; FValue := AValue; @@ -62,7 +62,7 @@ end; procedure TMyTestReceiver.Foo; begin - Inc( FCallCount ); + Inc(FCallCount); end; function TMyTestReceiver.GetValue: Integer; @@ -93,7 +93,7 @@ begin // This call is expected to succeed without raising EAssertionFailed or other exceptions // if TMycNotifyList.Destroy is implemented correctly. FNotifier.Destroy; - Assert.IsTrue( True, 'FNotifier.Destroy completed without raising an exception.' ); + Assert.IsTrue(True, 'FNotifier.Destroy completed without raising an exception.'); end; // Test for: Correct execution of Notify on an empty, locked, and finalized list. @@ -105,22 +105,23 @@ var dummyPredicate: TPredicate; begin predicateCallCount := 0; - dummyPredicate := function( Item: IMyTestInterface ): Boolean - begin - Inc( predicateCallCount ); - Result := True; - end; + dummyPredicate := + function(Item: IMyTestInterface): Boolean + begin + Inc(predicateCallCount); + Result := True; + end; FNotifier.Lock; - Assert.IsTrue( FNotifier.IsLocked, 'Notifier should be locked.' ); + Assert.IsTrue(FNotifier.IsLocked, 'Notifier should be locked.'); -// FNotifier.Finalize; // Internally, FFirst becomes 2 (locked & finalized state bits) if it was 0 after Lock -// Assert.IsTrue( FNotifier.IsFinalized, 'Notifier should be finalized.' ); + // FNotifier.Finalize; // Internally, FFirst becomes 2 (locked & finalized state bits) if it was 0 after Lock + // Assert.IsTrue( FNotifier.IsFinalized, 'Notifier should be finalized.' ); // In a corrected Notifier, this call should not cause an AV and not call the predicate. - FNotifier.Notify( dummyPredicate ); - Assert.AreEqual( 0, predicateCallCount, 'Notify predicate should not have been called for an empty, finalized list.' ); - Assert.IsTrue( True, 'FNotifier.Notify on finalized locked empty list completed without AV.' ); + FNotifier.Notify(dummyPredicate); + Assert.AreEqual(0, predicateCallCount, 'Notify predicate should not have been called for an empty, finalized list.'); + Assert.IsTrue(True, 'FNotifier.Notify on finalized locked empty list completed without AV.'); if FNotifier.IsLocked then // Release lock for subsequent operations or cleanup begin @@ -134,14 +135,14 @@ end; procedure TMycTestNotifierTests.Test03_UnadviseAllOnFinalizedLockedEmptyListExecutesWithoutErrors; begin FNotifier.Lock; - Assert.IsTrue( FNotifier.IsLocked, 'Notifier should be locked.' ); + Assert.IsTrue(FNotifier.IsLocked, 'Notifier should be locked.'); -// FNotifier.Finalize; // FFirst becomes 2 internally -// Assert.IsTrue( FNotifier.IsFinalized, 'Notifier should be finalized.' ); + // FNotifier.Finalize; // FFirst becomes 2 internally + // Assert.IsTrue( FNotifier.IsFinalized, 'Notifier should be finalized.' ); // In a corrected Notifier, this call should not cause an AV. FNotifier.UnadviseAll; - Assert.IsTrue( True, 'FNotifier.UnadviseAll on finalized locked empty list completed without AV.' ); + Assert.IsTrue(True, 'FNotifier.UnadviseAll on finalized locked empty list completed without AV.'); if FNotifier.IsLocked then // Release lock begin @@ -156,37 +157,37 @@ var tag1, tag2: TMycNotifyList.TTag; receiver1, receiver2: IMyTestInterface; begin - receiver1 := TMyTestReceiver.Create( 1 ); - receiver2 := TMyTestReceiver.Create( 2 ); + receiver1 := TMyTestReceiver.Create(1); + receiver2 := TMyTestReceiver.Create(2); FNotifier.Lock; try - tag1 := FNotifier.Advise( receiver1 ); - Assert.AreNotEqual( TMycNotifyList.TTag( nil ), tag1, 'Tag1 should not be nil.' ); - FNotifier.Unadvise( tag1 ); + tag1 := FNotifier.Advise(receiver1); + Assert.AreNotEqual(TMycNotifyList.TTag(nil), tag1, 'Tag1 should not be nil.'); + FNotifier.Unadvise(tag1); - tag1 := FNotifier.Advise( receiver1 ); - Assert.AreNotEqual( TMycNotifyList.TTag( nil ), tag1, 'Tag1 should not be nil.' ); + tag1 := FNotifier.Advise(receiver1); + Assert.AreNotEqual(TMycNotifyList.TTag(nil), tag1, 'Tag1 should not be nil.'); - tag2 := FNotifier.Advise( receiver2 ); - Assert.AreNotEqual( TMycNotifyList.TTag( nil ), tag2, 'Tag2 should not be nil.' ); - Assert.AreNotEqual( tag1, tag2, 'Tag1 and Tag2 should be different.' ); + tag2 := FNotifier.Advise(receiver2); + Assert.AreNotEqual(TMycNotifyList.TTag(nil), tag2, 'Tag2 should not be nil.'); + Assert.AreNotEqual(tag1, tag2, 'Tag1 and Tag2 should be different.'); - FNotifier.Unadvise( tag1 ); - FNotifier.Unadvise( tag2 ); + FNotifier.Unadvise(tag1); + FNotifier.Unadvise(tag2); // Re-add and unadvise in different order - tag1 := FNotifier.Advise( receiver1 ); - tag2 := FNotifier.Advise( receiver2 ); - Assert.AreNotEqual( TMycNotifyList.TTag( nil ), tag1 ); - Assert.AreNotEqual( TMycNotifyList.TTag( nil ), tag2 ); - FNotifier.Unadvise( tag2 ); - FNotifier.Unadvise( tag1 ); + tag1 := FNotifier.Advise(receiver1); + tag2 := FNotifier.Advise(receiver2); + Assert.AreNotEqual(TMycNotifyList.TTag(nil), tag1); + Assert.AreNotEqual(TMycNotifyList.TTag(nil), tag2); + FNotifier.Unadvise(tag2); + FNotifier.Unadvise(tag1); finally FNotifier.Release; end; - Assert.IsFalse( FNotifier.IsLocked, 'Notifier should be unlocked.' ); + Assert.IsFalse(FNotifier.IsLocked, 'Notifier should be unlocked.'); end; // Test for: Notify calls advised items and can remove items based on the predicate. @@ -196,30 +197,30 @@ var rcv1, rcv2, rcv3: TMyTestReceiver; itemsProcessedCount: Integer; begin - rcv1 := TMyTestReceiver.Create( 10 ); // Keep - rcv2 := TMyTestReceiver.Create( 20 ); // Remove - rcv3 := TMyTestReceiver.Create( 30 ); // Keep + rcv1 := TMyTestReceiver.Create(10); // Keep + rcv2 := TMyTestReceiver.Create(20); // Remove + rcv3 := TMyTestReceiver.Create(30); // Keep FNotifier.Lock; try - FNotifier.Advise( rcv1 ); - FNotifier.Advise( rcv2 ); - FNotifier.Advise( rcv3 ); + FNotifier.Advise(rcv1); + FNotifier.Advise(rcv2); + FNotifier.Advise(rcv3); itemsProcessedCount := 0; FNotifier.Notify( - function( Item: IMyTestInterface ): Boolean - begin - Inc( itemsProcessedCount ); - TMyTestReceiver( Item ).Foo; - Result := Item.GetValue <> 20; // Remove item with value 20 - end - ); + function(Item: IMyTestInterface): Boolean + begin + Inc(itemsProcessedCount); + TMyTestReceiver(Item).Foo; + Result := Item.GetValue <> 20; // Remove item with value 20 + end + ); - Assert.AreEqual( 3, itemsProcessedCount, 'Notify predicate called for all 3 items.' ); - Assert.AreEqual( 1, rcv1.CallCount, 'Receiver1 called once.' ); - Assert.AreEqual( 1, rcv2.CallCount, 'Receiver2 called once (before removal).' ); - Assert.AreEqual( 1, rcv3.CallCount, 'Receiver3 called once.' ); + Assert.AreEqual(3, itemsProcessedCount, 'Notify predicate called for all 3 items.'); + Assert.AreEqual(1, rcv1.CallCount, 'Receiver1 called once.'); + Assert.AreEqual(1, rcv2.CallCount, 'Receiver2 called once (before removal).'); + Assert.AreEqual(1, rcv3.CallCount, 'Receiver3 called once.'); // Reset counts and check again rcv1.CallCount := 0; @@ -228,17 +229,17 @@ begin itemsProcessedCount := 0; FNotifier.Notify( - function( Item: IMyTestInterface ): Boolean - begin - Inc( itemsProcessedCount ); - TMyTestReceiver( Item ).Foo; - Result := True; // Keep remaining - end - ); - Assert.AreEqual( 2, itemsProcessedCount, 'Notify predicate called for 2 remaining items.' ); - Assert.AreEqual( 1, rcv1.CallCount, 'Receiver1 called again.' ); - Assert.AreEqual( 0, rcv2.CallCount, 'Receiver2 (removed) not called again.' ); - Assert.AreEqual( 1, rcv3.CallCount, 'Receiver3 called again.' ); + function(Item: IMyTestInterface): Boolean + begin + Inc(itemsProcessedCount); + TMyTestReceiver(Item).Foo; + Result := True; // Keep remaining + end + ); + Assert.AreEqual(2, itemsProcessedCount, 'Notify predicate called for 2 remaining items.'); + Assert.AreEqual(1, rcv1.CallCount, 'Receiver1 called again.'); + Assert.AreEqual(0, rcv2.CallCount, 'Receiver2 (removed) not called again.'); + Assert.AreEqual(1, rcv3.CallCount, 'Receiver3 called again.'); finally FNotifier.Release; @@ -257,6 +258,6 @@ end; initialization -TDUnitX.RegisterTestFixture( TMycTestNotifierTests ); + TDUnitX.RegisterTestFixture(TMycTestNotifierTests); end. diff --git a/Test/TestNotifier_ChaosStress.pas b/Test/TestNotifier_ChaosStress.pas index af4e7f3..0b0155c 100644 --- a/Test/TestNotifier_ChaosStress.pas +++ b/Test/TestNotifier_ChaosStress.pas @@ -20,8 +20,7 @@ type function GetInstanceID: Integer; function GetExpectedToBeAdvised: Boolean; procedure SetExpectedToBeAdvised(const Value: Boolean); - property ExpectedToBeAdvised: Boolean read GetExpectedToBeAdvised write - SetExpectedToBeAdvised; + property ExpectedToBeAdvised: Boolean read GetExpectedToBeAdvised write SetExpectedToBeAdvised; end; TMyStressReceiver = class(TInterfacedObject, IMyStressTestInterface) @@ -39,8 +38,7 @@ type function GetValue: Integer; function GetNotificationCount: Integer; function GetInstanceID: Integer; - property ExpectedToBeAdvised: Boolean read GetExpectedToBeAdvised write - SetExpectedToBeAdvised; + property ExpectedToBeAdvised: Boolean read GetExpectedToBeAdvised write SetExpectedToBeAdvised; end; // Record type to store an advised receiver and its tag @@ -66,7 +64,7 @@ type destructor Destroy; override; property Error: Exception read FError; function GetAdvisedReceiverCountByThread: Integer; - // procedure GetMyExpectedLiveReceivers(AList: TList); // Not strictly needed with current verification + // procedure GetMyExpectedLiveReceivers(AList: TList); // Not strictly needed with current verification end; [TestFixture] @@ -165,7 +163,8 @@ begin try for i := 1 to FIterations do begin - if Terminated then Break; // Respond to termination request + if Terminated then + Break; // Respond to termination request op := Random(100); @@ -211,21 +210,23 @@ begin begin FOwnerFixture.FNotifier.Lock; try -// if not FOwnerFixture.FNotifier.IsFinalized then // Don't notify if finalized + // if not FOwnerFixture.FNotifier.IsFinalized then // Don't notify if finalized begin FOwnerFixture.FNotifier.Notify( - function(Item: IMyStressTestInterface): Boolean - begin - Item.Foo(FThreadID); // Pass ThreadID as notification type for context - Result := True; // Keep item - end); + function(Item: IMyStressTestInterface): Boolean + begin + Item.Foo(FThreadID); // Pass ThreadID as notification type for context + Result := True; // Keep item + end + ); end; finally FOwnerFixture.FNotifier.Release; end; end; - if (i mod 75 = 0) then Sleep(0); // Yield occasionally to encourage context switching + if (i mod 75 = 0) then + Sleep(0); // Yield occasionally to encourage context switching end; except on E: Exception do @@ -250,7 +251,6 @@ end; // end; // end; - { TMycNotifierChaosStressTests } procedure TMycNotifierChaosStressTests.Setup; begin @@ -263,8 +263,8 @@ end; procedure TMycNotifierChaosStressTests.TearDown; var - // receiver: TMyStressReceiver; // Not used directly in this simplified TearDown - i: Integer; + // receiver: TMyStressReceiver; // Not used directly in this simplified TearDown + i: Integer; begin // Attempt to shut down the Notifier cleanly. try @@ -272,7 +272,7 @@ begin try // UnadviseAll should be safe if the IsFinalized guard is present // and the FFirst state is not pathological. -// if not FNotifier.IsFinalized then + // if not FNotifier.IsFinalized then begin FNotifier.UnadviseAll; end; @@ -294,7 +294,7 @@ begin // as long as no other strong references exist. // Setting list items to nil is good practice if the list itself isn't immediately freed. for i := 0 to FAllReceiversCreated.Count - 1 do - FAllReceiversCreated[i] := nil; // Break reference cycles if any, allow ARC + FAllReceiversCreated[i] := nil; // Break reference cycles if any, allow ARC FAllReceiversCreated.Free; FAllReceiversCreated := nil; end; @@ -307,7 +307,7 @@ end; procedure TMycNotifierChaosStressTests.Test_MixedOperations_Stress; const - NumThreads = 24; // Number of concurrent worker threads + NumThreads = 24; // Number of concurrent worker threads IterationsPerThread = 2000; // Number of random operations per thread var threads: array of TStressWorkerThread; @@ -337,8 +337,7 @@ begin begin // If an error occurred, Assert.IsNull would fail. // The message can safely use LThreadError.Message here. - Assert.IsNull(LThreadError, - 'Thread ' + threads[i].FThreadID.ToString + ' reported an error: ' + LThreadError.Message); + Assert.IsNull(LThreadError, 'Thread ' + threads[i].FThreadID.ToString + ' reported an error: ' + LThreadError.Message); end else begin @@ -357,14 +356,15 @@ begin try FNotifier.Lock; try -// if not FNotifier.IsFinalized then + // if not FNotifier.IsFinalized then begin FNotifier.Notify( - function(Item: IMyStressTestInterface): Boolean - begin - actualLiveReceiversInNotifier.Add(Item); - Result := True; - end); + function(Item: IMyStressTestInterface): Boolean + begin + actualLiveReceiversInNotifier.Add(Item); + Result := True; + end + ); end; finally FNotifier.Release; @@ -372,8 +372,14 @@ begin actualLiveInNotifierAtEnd := actualLiveReceiversInNotifier.Count; // 2. Compare overall counts - Assert.AreEqual(totalExpectedLiveByThreadsAtEnd, actualLiveInNotifierAtEnd, - Format('Mismatch in live item count at end. Threads expected %d, Notifier has %d.', [totalExpectedLiveByThreadsAtEnd, actualLiveInNotifierAtEnd])); + Assert.AreEqual( + totalExpectedLiveByThreadsAtEnd, + actualLiveInNotifierAtEnd, + Format( + 'Mismatch in live item count at end. Threads expected %d, Notifier has %d.', + [totalExpectedLiveByThreadsAtEnd, actualLiveInNotifierAtEnd] + ) + ); // 3. Detailed check: Iterate all receivers ever created. // Their 'ExpectedToBeAdvised' flag (last known state from its managing thread) @@ -393,14 +399,29 @@ begin end; end; - Assert.AreEqual(receiver.ExpectedToBeAdvised, found, - Format('Receiver ID %d: Thread expected it to be advised=%d, but its presence in Notifier is %d. NotificationCount=%d', - [receiver.GetInstanceID, Integer(receiver.ExpectedToBeAdvised), Integer(found), receiver.GetNotificationCount])); + Assert.AreEqual( + receiver.ExpectedToBeAdvised, + found, + Format( + 'Receiver ID %d: Thread expected it to be advised=%d, but its presence in Notifier is %d. NotificationCount=%d', + [ + receiver.GetInstanceID, + Integer(receiver.ExpectedToBeAdvised), + Integer(found), + receiver.GetNotificationCount + ] + ) + ); // Further checks on NotificationCount could be added if specific notification patterns were expected. // For this chaos test, ensuring count is non-negative and consistent with advised state is a good start. - Assert.IsTrue(receiver.GetNotificationCount >= 0, - Format('Receiver ID %d has non-positive notification count: %d', [receiver.GetInstanceID, receiver.GetNotificationCount])); + Assert.IsTrue( + receiver.GetNotificationCount >= 0, + Format( + 'Receiver ID %d has non-positive notification count: %d', + [receiver.GetInstanceID, receiver.GetNotificationCount] + ) + ); if found and (receiver.GetNotificationCount = 0) then begin // This might be okay if Notify calls were very sparse or the item was just added and not yet notified. diff --git a/Test/TestNotifier_Threading.pas b/Test/TestNotifier_Threading.pas index 796e081..2fc3dd7 100644 --- a/Test/TestNotifier_Threading.pas +++ b/Test/TestNotifier_Threading.pas @@ -127,7 +127,8 @@ begin // Acquire lock before calling Advise FOwnerFixture.FNotifier.Lock; try - {var tag :=} FOwnerFixture.FNotifier.Advise(FReceiversToAdd[i]); + {var tag :=} + FOwnerFixture.FNotifier.Advise(FReceiversToAdd[i]); // The 'tag' could be used here if necessary for other test scenarios finally // Definitely release lock in the finally block @@ -168,7 +169,7 @@ begin try // UnadviseAll should be safe if the IsFinalized guard is present // and the FFirst state is not pathological. -// if not FNotifier.IsFinalized then + // if not FNotifier.IsFinalized then begin FNotifier.UnadviseAll; end; @@ -206,7 +207,7 @@ var currentNotifyCount: Integer; receiver: IMyTestInterface; LThreadError: Exception; // For safe error message handling - LMessage: string; // For safe error message handling + LMessage: string; // For safe error message handling begin totalAdvisedExpected := NumThreads * ItemsPerThread; SetLength(threads, NumThreads); @@ -255,18 +256,24 @@ begin FNotifier.Lock; try FNotifier.Notify( - function(Item: IMyTestInterface): Boolean - begin - Inc(currentNotifyCount); - Result := True; // Keep item in the Notifier - end + function(Item: IMyTestInterface): Boolean + begin + Inc(currentNotifyCount); + Result := True; // Keep item in the Notifier + end ); finally FNotifier.Release; end; - Assert.AreEqual(totalAdvisedExpected, currentNotifyCount, - 'The number of items in the Notifier after all Advise operations (' + currentNotifyCount.ToString + - ') does not match the expected number (' + totalAdvisedExpected.ToString + ').'); + Assert.AreEqual( + totalAdvisedExpected, + currentNotifyCount, + 'The number of items in the Notifier after all Advise operations (' + + currentNotifyCount.ToString + + ') does not match the expected number (' + + totalAdvisedExpected.ToString + + ').' + ); // 2. Execute UnadviseAll FNotifier.Lock; @@ -281,21 +288,24 @@ begin FNotifier.Lock; try FNotifier.Notify( - function(Item: IMyTestInterface): Boolean - begin - Inc(currentNotifyCount); - Result := True; - end + function(Item: IMyTestInterface): Boolean + begin + Inc(currentNotifyCount); + Result := True; + end ); finally FNotifier.Release; end; - Assert.AreEqual(0, currentNotifyCount, - 'The Notifier should be empty after UnadviseAll, but still contains ' + currentNotifyCount.ToString + ' items.'); + Assert.AreEqual( + 0, + currentNotifyCount, + 'The Notifier should be empty after UnadviseAll, but still contains ' + currentNotifyCount.ToString + ' items.' + ); end; initialization -TDUnitX.RegisterTestFixture(TMycNotifierThreadingTests); + TDUnitX.RegisterTestFixture(TMycNotifierThreadingTests); end. diff --git a/Test/TestSignals_Dirty.pas b/Test/TestSignals_Dirty.pas index dc7f890..34d33f8 100644 --- a/Test/TestSignals_Dirty.pas +++ b/Test/TestSignals_Dirty.pas @@ -3,81 +3,81 @@ unit TestSignals_Dirty; interface uses - DUnitX.TestFramework, - System.SysUtils, - Myc.Signals; // Unit under test + DUnitX.TestFramework, + System.SysUtils, + Myc.Signals; // Unit under test type - // Helper class to mock a subscriber (reuse or redefine if not in common unit) - TMockSubscriber = class(TInterfacedObject, IMycSubscriber) - public - NotifyCount: Integer; - NotifyShouldReturn: Boolean; - WasCalled: Boolean; - LastReturnedValueFromSource: Boolean; // To store what the source's Notify returned + // Helper class to mock a subscriber (reuse or redefine if not in common unit) + TMockSubscriber = class(TInterfacedObject, IMycSubscriber) + public + NotifyCount: Integer; + NotifyShouldReturn: Boolean; + WasCalled: Boolean; + LastReturnedValueFromSource: Boolean; // To store what the source's Notify returned - constructor Create(AShouldReturn: Boolean = True); - function Notify: Boolean; // IMycSubscriber implementation. - end; + constructor Create(AShouldReturn: Boolean = True); + function Notify: Boolean; // IMycSubscriber implementation. + end; - [TestFixture] - TTestMycDirtyFlag = class(TObject) - private - // Helper to create a dirty flag and optionally reset it for a clean initial state - function CreateAndPrepareDirtyFlag(StartDirty: Boolean = True): IMycDirty; - public - [Setup] - procedure Setup; - [TearDown] - procedure TearDown; + [TestFixture] + TTestMycDirtyFlag = class(TObject) + private + // Helper to create a dirty flag and optionally reset it for a clean initial state + function CreateAndPrepareDirtyFlag(StartDirty: Boolean = True): IMycDirty; + public + [Setup] + procedure Setup; + [TearDown] + procedure TearDown; - // Category 1: Basic State, Notify (as Subscriber method), and Reset - [Test] - procedure TestCreate_InitialStateIsDirty; - [Test] - procedure TestReset_FromDirtyState_BecomesCleanAndReturnsTrue; - [Test] - procedure TestReset_FromCleanState_StaysCleanAndReturnsFalse; - [Test] - procedure TestNotify_OnCleanFlag_SetsDirtyAndReturnsTrue; - [Test] - procedure TestNotify_OnDirtyFlag_StaysDirtyAndReturnsFalse; + // Category 1: Basic State, Notify (as Subscriber method), and Reset + [Test] + procedure TestCreate_InitialStateIsDirty; + [Test] + procedure TestReset_FromDirtyState_BecomesCleanAndReturnsTrue; + [Test] + procedure TestReset_FromCleanState_StaysCleanAndReturnsFalse; + [Test] + procedure TestNotify_OnCleanFlag_SetsDirtyAndReturnsTrue; + [Test] + procedure TestNotify_OnDirtyFlag_StaysDirtyAndReturnsFalse; - // Category 2: Subscriber Notifications - [Test] - procedure TestSubscribe_ToAlreadyDirtyFlag_NotifiesSubscriberImmediately; - [Test] - procedure TestSubscribe_ToCleanFlag_DoesNotNotifySubscriberImmediately; - [Test] - procedure TestSubscriber_Notified_WhenFlagTransitionsToDirty; - [Test] - procedure TestSubscriber_NotNotified_WhenSettingAlreadyDirtyFlagViaNotify; - [Test] - procedure TestSubscriber_NotNotified_ByResetAction; - [Test] - procedure TestMultipleSubscribers_Notified_WhenFlagTransitionsToDirty; - [Test] - procedure TestUnsubscribe_SubscriberNotNotified; + // Category 2: Subscriber Notifications + [Test] + procedure TestSubscribe_ToAlreadyDirtyFlag_NotifiesSubscriberImmediately; + [Test] + procedure TestSubscribe_ToCleanFlag_DoesNotNotifySubscriberImmediately; + [Test] + procedure TestSubscriber_Notified_WhenFlagTransitionsToDirty; + [Test] + procedure TestSubscriber_NotNotified_WhenSettingAlreadyDirtyFlagViaNotify; + [Test] + procedure TestSubscriber_NotNotified_ByResetAction; + [Test] + procedure TestMultipleSubscribers_Notified_WhenFlagTransitionsToDirty; + [Test] + procedure TestUnsubscribe_SubscriberNotNotified; - // Category 3: Chaining Dirty Flags - [Test] - procedure TestChain_A_Notifies_B_SimplePropagation; - [Test] - procedure TestChain_A_Notifies_B_Notifies_C_SimplePropagation; + // Category 3: Chaining Dirty Flags + [Test] + procedure TestChain_A_Notifies_B_SimplePropagation; + [Test] + procedure TestChain_A_Notifies_B_Notifies_C_SimplePropagation; - // Category 4: Chaining with Resets and Re-triggering (Consistency) - [Test] - procedure TestChain_A_B_ResetB_RetriggerA_BStaysCleanIfANotChanged; - [Test] - procedure TestChain_A_B_ResetA_ThenTriggerA_FullPropagationToB; - [Test] - procedure TestChain_A_B_C_IntermediateBReset_RetriggerA_PropagatesToC; - [Test] - procedure TestChain_A_B_C_AllReset_RetriggerA_FullPropagation; - [Test] - procedure TestChain_A_B_C_TriggerA_ResetA_TriggerA_EnsureCNotifiedCorrectly; + // Category 4: Chaining with Resets and Re-triggering (Consistency) + [Test] + procedure TestChain_A_B_ResetB_RetriggerA_BStaysCleanIfANotChanged; + [Test] + procedure TestChain_A_B_ResetA_ThenTriggerA_FullPropagationToB; + [Test] + procedure TestChain_A_B_C_IntermediateBReset_RetriggerA_PropagatesToC; + [Test] + procedure TestChain_A_B_C_AllReset_RetriggerA_FullPropagation; + [Test] + procedure TestChain_A_B_C_TriggerA_ResetA_TriggerA_EnsureCNotifiedCorrectly; - end; + end; implementation @@ -85,221 +85,221 @@ implementation constructor TMockSubscriber.Create(AShouldReturn: Boolean = True); begin - inherited Create; - NotifyCount := 0; - NotifyShouldReturn := AShouldReturn; - WasCalled := False; - LastReturnedValueFromSource := False; // Default + inherited Create; + NotifyCount := 0; + NotifyShouldReturn := AShouldReturn; + WasCalled := False; + LastReturnedValueFromSource := False; // Default end; function TMockSubscriber.Notify: Boolean; begin - Inc(NotifyCount); - WasCalled := True; - // This return value is what this subscriber tells the source signal. - // For testing, we usually want it to return false to signify it doesn't need more from this one event. - Result := NotifyShouldReturn; + Inc(NotifyCount); + WasCalled := True; + // This return value is what this subscriber tells the source signal. + // For testing, we usually want it to return false to signify it doesn't need more from this one event. + Result := NotifyShouldReturn; end; { TTestMycDirtyFlag } function TTestMycDirtyFlag.CreateAndPrepareDirtyFlag(StartDirty: Boolean = True): IMycDirty; begin - Result := TDirty.Construct; // Initially dirty - if not StartDirty then - Result.Reset; // Reset to make it clean - Assert.AreEqual(StartDirty, Result.State.IsSet, 'CreateAndPrepareDirtyFlag initial state incorrect.'); + Result := TDirty.Construct; // Initially dirty + if not StartDirty then + Result.Reset; // Reset to make it clean + Assert.AreEqual(StartDirty, Result.State.IsSet, 'CreateAndPrepareDirtyFlag initial state incorrect.'); end; procedure TTestMycDirtyFlag.Setup; begin - // Per-test setup + // Per-test setup end; procedure TTestMycDirtyFlag.TearDown; begin - // Per-test teardown + // Per-test teardown end; // Category 1: Basic State, Notify (as Subscriber method), and Reset procedure TTestMycDirtyFlag.TestCreate_InitialStateIsDirty; var - dirtyFlag: IMycDirty; + dirtyFlag: IMycDirty; begin - dirtyFlag := TDirty.Construct; - Assert.IsTrue(dirtyFlag.State.IsSet, 'Newly created dirty flag should be IsSet (dirty).'); + dirtyFlag := TDirty.Construct; + Assert.IsTrue(dirtyFlag.State.IsSet, 'Newly created dirty flag should be IsSet (dirty).'); end; procedure TTestMycDirtyFlag.TestReset_FromDirtyState_BecomesCleanAndReturnsTrue; var - dirtyFlag: IMycDirty; - resetResult: Boolean; + dirtyFlag: IMycDirty; + resetResult: Boolean; begin - dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty + dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty - resetResult := dirtyFlag.Reset; + resetResult := dirtyFlag.Reset; - Assert.IsFalse(dirtyFlag.State.IsSet, 'Flag should be clean (not IsSet) after Reset.'); - Assert.IsTrue(resetResult, 'Reset() should return True when resetting a dirty flag.'); + Assert.IsFalse(dirtyFlag.State.IsSet, 'Flag should be clean (not IsSet) after Reset.'); + Assert.IsTrue(resetResult, 'Reset() should return True when resetting a dirty flag.'); end; procedure TTestMycDirtyFlag.TestReset_FromCleanState_StaysCleanAndReturnsFalse; var - dirtyFlag: IMycDirty; - resetResult: Boolean; + dirtyFlag: IMycDirty; + resetResult: Boolean; begin - dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean + dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean - resetResult := dirtyFlag.Reset; + resetResult := dirtyFlag.Reset; - Assert.IsFalse(dirtyFlag.State.IsSet, 'Flag should remain clean (not IsSet) after Reset on clean flag.'); - Assert.IsFalse(resetResult, 'Reset() should return False when resetting an already clean flag.'); + Assert.IsFalse(dirtyFlag.State.IsSet, 'Flag should remain clean (not IsSet) after Reset on clean flag.'); + Assert.IsFalse(resetResult, 'Reset() should return False when resetting an already clean flag.'); end; procedure TTestMycDirtyFlag.TestNotify_OnCleanFlag_SetsDirtyAndReturnsTrue; var - dirtyFlag: IMycDirty; - notifyResult: Boolean; + dirtyFlag: IMycDirty; + notifyResult: Boolean; begin - dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean + dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean - notifyResult := dirtyFlag.Notify; // Call IMycSubscriber.Notify to make it dirty + notifyResult := dirtyFlag.Notify; // Call IMycSubscriber.Notify to make it dirty - Assert.IsTrue(dirtyFlag.State.IsSet, 'Flag should be dirty (IsSet) after Notify on clean flag.'); - Assert.IsTrue(notifyResult, 'Notify() should return True indicating a state change from clean to dirty.'); + Assert.IsTrue(dirtyFlag.State.IsSet, 'Flag should be dirty (IsSet) after Notify on clean flag.'); + Assert.IsTrue(notifyResult, 'Notify() should return True indicating a state change from clean to dirty.'); end; procedure TTestMycDirtyFlag.TestNotify_OnDirtyFlag_StaysDirtyAndReturnsFalse; var - dirtyFlag: IMycDirty; - notifyResult: Boolean; + dirtyFlag: IMycDirty; + notifyResult: Boolean; begin - dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty + dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty - notifyResult := dirtyFlag.Notify; // Call IMycSubscriber.Notify again + notifyResult := dirtyFlag.Notify; // Call IMycSubscriber.Notify again - Assert.IsTrue(dirtyFlag.State.IsSet, 'Flag should remain dirty (IsSet).'); - Assert.IsFalse(notifyResult, 'Notify() should return False as flag was already dirty (no state change to dirty).'); + Assert.IsTrue(dirtyFlag.State.IsSet, 'Flag should remain dirty (IsSet).'); + Assert.IsFalse(notifyResult, 'Notify() should return False as flag was already dirty (no state change to dirty).'); end; // Category 2: Subscriber Notifications procedure TTestMycDirtyFlag.TestSubscribe_ToAlreadyDirtyFlag_NotifiesSubscriberImmediately; var - dirtyFlag: IMycDirty; - subscriber: TMockSubscriber; - subscription: TState.TSubscription; + dirtyFlag: IMycDirty; + subscriber: TMockSubscriber; + subscription: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty - subscriber := TMockSubscriber.Create; + dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty + subscriber := TMockSubscriber.Create; - subscription := dirtyFlag.State.Subscribe(subscriber); + subscription := dirtyFlag.State.Subscribe(subscriber); - Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should be notified immediately when subscribing to an already dirty flag.'); - Assert.IsTrue(subscriber.WasCalled, 'Subscriber WasCalled should be true.'); + Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should be notified immediately when subscribing to an already dirty flag.'); + Assert.IsTrue(subscriber.WasCalled, 'Subscriber WasCalled should be true.'); end; procedure TTestMycDirtyFlag.TestSubscribe_ToCleanFlag_DoesNotNotifySubscriberImmediately; var - dirtyFlag: IMycDirty; - subscriber: TMockSubscriber; - subscription: TState.TSubscription; + dirtyFlag: IMycDirty; + subscriber: TMockSubscriber; + subscription: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean - subscriber := TMockSubscriber.Create; + dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean + subscriber := TMockSubscriber.Create; - subscription := dirtyFlag.State.Subscribe(subscriber); + subscription := dirtyFlag.State.Subscribe(subscriber); - Assert.AreEqual(0, subscriber.NotifyCount, 'Subscriber should NOT be notified immediately when subscribing to a clean flag.'); - Assert.IsFalse(subscriber.WasCalled, 'Subscriber WasCalled should be false.'); + Assert.AreEqual(0, subscriber.NotifyCount, 'Subscriber should NOT be notified immediately when subscribing to a clean flag.'); + Assert.IsFalse(subscriber.WasCalled, 'Subscriber WasCalled should be false.'); end; procedure TTestMycDirtyFlag.TestSubscriber_Notified_WhenFlagTransitionsToDirty; var - dirtyFlag: IMycDirty; - subscriber: TMockSubscriber; - subscription: TState.TSubscription; + dirtyFlag: IMycDirty; + subscriber: TMockSubscriber; + subscription: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean - subscriber := TMockSubscriber.Create; - subscription := dirtyFlag.State.Subscribe(subscriber); + dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean + subscriber := TMockSubscriber.Create; + subscription := dirtyFlag.State.Subscribe(subscriber); - Assert.AreEqual(0, subscriber.NotifyCount, 'Subscriber initially not notified.'); + Assert.AreEqual(0, subscriber.NotifyCount, 'Subscriber initially not notified.'); - dirtyFlag.Notify; // Make the flag dirty + dirtyFlag.Notify; // Make the flag dirty - Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should be notified once flag transitions to dirty.'); + Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should be notified once flag transitions to dirty.'); end; procedure TTestMycDirtyFlag.TestSubscriber_NotNotified_WhenSettingAlreadyDirtyFlagViaNotify; var - dirtyFlag: IMycDirty; - subscriber: TMockSubscriber; - subscription: TState.TSubscription; + dirtyFlag: IMycDirty; + subscriber: TMockSubscriber; + subscription: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty - subscriber := TMockSubscriber.Create; - subscription := dirtyFlag.State.Subscribe(subscriber); // Gets initial notification + dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty + subscriber := TMockSubscriber.Create; + subscription := dirtyFlag.State.Subscribe(subscriber); // Gets initial notification - Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber notified on subscribe to dirty flag.'); + Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber notified on subscribe to dirty flag.'); - dirtyFlag.Notify; // Notify again, flag was already dirty + dirtyFlag.Notify; // Notify again, flag was already dirty - Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should NOT be notified again if flag was already dirty.'); + Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should NOT be notified again if flag was already dirty.'); end; procedure TTestMycDirtyFlag.TestSubscriber_NotNotified_ByResetAction; var - dirtyFlag: IMycDirty; - subscriber: TMockSubscriber; - subscription: TState.TSubscription; + dirtyFlag: IMycDirty; + subscriber: TMockSubscriber; + subscription: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty - subscriber := TMockSubscriber.Create; - subscription := dirtyFlag.State.Subscribe(subscriber); // Gets initial notification + dirtyFlag := CreateAndPrepareDirtyFlag(True); // Start dirty + subscriber := TMockSubscriber.Create; + subscription := dirtyFlag.State.Subscribe(subscriber); // Gets initial notification - Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber notified on subscribe.'); - dirtyFlag.Reset; // Reset the flag - Assert.IsFalse(dirtyFlag.State.IsSet, 'Flag is now clean.'); + Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber notified on subscribe.'); + dirtyFlag.Reset; // Reset the flag + Assert.IsFalse(dirtyFlag.State.IsSet, 'Flag is now clean.'); - // Current TMycDirty.Reset does not notify subscribers. - Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should NOT be notified by Reset action.'); + // Current TMycDirty.Reset does not notify subscribers. + Assert.AreEqual(1, subscriber.NotifyCount, 'Subscriber should NOT be notified by Reset action.'); end; procedure TTestMycDirtyFlag.TestMultipleSubscribers_Notified_WhenFlagTransitionsToDirty; var - dirtyFlag: IMycDirty; - sub1, sub2: TMockSubscriber; - subscription1, subscription2: TState.TSubscription; + dirtyFlag: IMycDirty; + sub1, sub2: TMockSubscriber; + subscription1, subscription2: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean - sub1 := TMockSubscriber.Create; - sub2 := TMockSubscriber.Create; - subscription1 := dirtyFlag.State.Subscribe(sub1); - subscription2 := dirtyFlag.State.Subscribe(sub2); + dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean + sub1 := TMockSubscriber.Create; + sub2 := TMockSubscriber.Create; + subscription1 := dirtyFlag.State.Subscribe(sub1); + subscription2 := dirtyFlag.State.Subscribe(sub2); - dirtyFlag.Notify; // Make flag dirty + dirtyFlag.Notify; // Make flag dirty - Assert.AreEqual(1, sub1.NotifyCount, 'Subscriber 1 should be notified.'); - Assert.AreEqual(1, sub2.NotifyCount, 'Subscriber 2 should be notified.'); + Assert.AreEqual(1, sub1.NotifyCount, 'Subscriber 1 should be notified.'); + Assert.AreEqual(1, sub2.NotifyCount, 'Subscriber 2 should be notified.'); end; procedure TTestMycDirtyFlag.TestUnsubscribe_SubscriberNotNotified; var - dirtyFlag: IMycDirty; - subscriber: TMockSubscriber; - subscription: TState.TSubscription; + dirtyFlag: IMycDirty; + subscriber: TMockSubscriber; + subscription: TState.TSubscription; begin - dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean - subscriber := TMockSubscriber.Create; - subscription := dirtyFlag.State.Subscribe(subscriber); + dirtyFlag := CreateAndPrepareDirtyFlag(False); // Start clean + subscriber := TMockSubscriber.Create; + subscription := dirtyFlag.State.Subscribe(subscriber); - subscription.Unsubscribe; // Explicitly unsubscribe + subscription.Unsubscribe; // Explicitly unsubscribe - dirtyFlag.Notify; // Make flag dirty + dirtyFlag.Notify; // Make flag dirty - Assert.AreEqual(0, subscriber.NotifyCount, 'Unsubscribed subscriber should not be notified.'); + Assert.AreEqual(0, subscriber.NotifyCount, 'Unsubscribed subscriber should not be notified.'); end; // Category 3: Chaining Dirty Flags @@ -308,222 +308,222 @@ end; procedure TTestMycDirtyFlag.TestChain_A_Notifies_B_SimplePropagation; var - flagA, flagB: IMycDirty; - subToB: TMockSubscriber; - subscriptionA_B, subscriptionMock_B: TState.TSubscription; + flagA, flagB: IMycDirty; + subToB: TMockSubscriber; + subscriptionA_B, subscriptionMock_B: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); // A starts clean - flagB := CreateAndPrepareDirtyFlag(False); // B starts clean - subToB := TMockSubscriber.Create; + flagA := CreateAndPrepareDirtyFlag(False); // A starts clean + flagB := CreateAndPrepareDirtyFlag(False); // B starts clean + subToB := TMockSubscriber.Create; - subscriptionMock_B := flagB.State.Subscribe(subToB); - subscriptionA_B := flagA.State.Subscribe(flagB); // B subscribes to A's state changes (B's Notify will be called) + subscriptionMock_B := flagB.State.Subscribe(subToB); + subscriptionA_B := flagA.State.Subscribe(flagB); // B subscribes to A's state changes (B's Notify will be called) - flagA.Notify; // Make A dirty. This should trigger B.Notify + flagA.Notify; // Make A dirty. This should trigger B.Notify - Assert.IsTrue(flagA.State.IsSet, 'Flag A should be dirty.'); - Assert.IsTrue(flagB.State.IsSet, 'Flag B should become dirty due to A.'); - Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B should be notified once.'); + Assert.IsTrue(flagA.State.IsSet, 'Flag A should be dirty.'); + Assert.IsTrue(flagB.State.IsSet, 'Flag B should become dirty due to A.'); + Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B should be notified once.'); end; procedure TTestMycDirtyFlag.TestChain_A_Notifies_B_Notifies_C_SimplePropagation; var - flagA, flagB, flagC: IMycDirty; - subToC: TMockSubscriber; - subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; + flagA, flagB, flagC: IMycDirty; + subToC: TMockSubscriber; + subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); - flagB := CreateAndPrepareDirtyFlag(False); - flagC := CreateAndPrepareDirtyFlag(False); - subToC := TMockSubscriber.Create; + flagA := CreateAndPrepareDirtyFlag(False); + flagB := CreateAndPrepareDirtyFlag(False); + flagC := CreateAndPrepareDirtyFlag(False); + subToC := TMockSubscriber.Create; - subscriptionMock_C := flagC.State.Subscribe(subToC); - subscriptionC_B := flagB.State.Subscribe(flagC); // C subscribes to B - subscriptionB_A := flagA.State.Subscribe(flagB); // B subscribes to A + subscriptionMock_C := flagC.State.Subscribe(subToC); + subscriptionC_B := flagB.State.Subscribe(flagC); // C subscribes to B + subscriptionB_A := flagA.State.Subscribe(flagB); // B subscribes to A - flagA.Notify; // Make A dirty + flagA.Notify; // Make A dirty - Assert.IsTrue(flagA.State.IsSet, 'Flag A should be dirty in cascade.'); - Assert.IsTrue(flagB.State.IsSet, 'Flag B should be dirty in cascade.'); - Assert.IsTrue(flagC.State.IsSet, 'Flag C should be dirty in cascade.'); - Assert.AreEqual(1, subToC.NotifyCount, 'Subscriber to C should be notified once in cascade.'); + Assert.IsTrue(flagA.State.IsSet, 'Flag A should be dirty in cascade.'); + Assert.IsTrue(flagB.State.IsSet, 'Flag B should be dirty in cascade.'); + Assert.IsTrue(flagC.State.IsSet, 'Flag C should be dirty in cascade.'); + Assert.AreEqual(1, subToC.NotifyCount, 'Subscriber to C should be notified once in cascade.'); end; // Category 4: Chaining with Resets and Re-triggering (Consistency) procedure TTestMycDirtyFlag.TestChain_A_B_ResetB_RetriggerA_BStaysCleanIfANotChanged; var - flagA, flagB: IMycDirty; - subToB: TMockSubscriber; - subscriptionA_B, subscriptionMock_B: TState.TSubscription; + flagA, flagB: IMycDirty; + subToB: TMockSubscriber; + subscriptionA_B, subscriptionMock_B: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); - flagB := CreateAndPrepareDirtyFlag(False); - subToB := TMockSubscriber.Create; - subscriptionMock_B := flagB.State.Subscribe(subToB); - subscriptionA_B := flagA.State.Subscribe(flagB); + flagA := CreateAndPrepareDirtyFlag(False); + flagB := CreateAndPrepareDirtyFlag(False); + subToB := TMockSubscriber.Create; + subscriptionMock_B := flagB.State.Subscribe(subToB); + subscriptionA_B := flagA.State.Subscribe(flagB); - flagA.Notify; // A dirty -> B dirty. subToB notified. - Assert.IsTrue(flagB.State.IsSet, 'Flag B should be dirty initially.'); - Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B initially notified.'); + flagA.Notify; // A dirty -> B dirty. subToB notified. + Assert.IsTrue(flagB.State.IsSet, 'Flag B should be dirty initially.'); + Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B initially notified.'); - flagB.Reset; // B becomes clean. A is still dirty. - Assert.IsFalse(flagB.State.IsSet, 'Flag B should be clean after reset.'); - Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B not notified by B.Reset.'); + flagB.Reset; // B becomes clean. A is still dirty. + Assert.IsFalse(flagB.State.IsSet, 'Flag B should be clean after reset.'); + Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B not notified by B.Reset.'); - // Notify A again. A was already dirty. So A.Notify() returns false, A does not call ProtectedNotifyOwnSubscribers. - // Thus, B.Notify() is NOT called. B should remain clean. - flagA.Notify; + // Notify A again. A was already dirty. So A.Notify() returns false, A does not call ProtectedNotifyOwnSubscribers. + // Thus, B.Notify() is NOT called. B should remain clean. + flagA.Notify; - Assert.IsTrue(flagA.State.IsSet, 'Flag A remains dirty.'); - Assert.IsFalse(flagB.State.IsSet, 'Flag B should remain clean if A did not transition to dirty.'); - Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B should not be notified again.'); + Assert.IsTrue(flagA.State.IsSet, 'Flag A remains dirty.'); + Assert.IsFalse(flagB.State.IsSet, 'Flag B should remain clean if A did not transition to dirty.'); + Assert.AreEqual(1, subToB.NotifyCount, 'Subscriber to B should not be notified again.'); end; procedure TTestMycDirtyFlag.TestChain_A_B_ResetA_ThenTriggerA_FullPropagationToB; var - flagA, flagB: IMycDirty; - subToB: TMockSubscriber; - subscriptionA_B, subscriptionMock_B: TState.TSubscription; + flagA, flagB: IMycDirty; + subToB: TMockSubscriber; + subscriptionA_B, subscriptionMock_B: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); - flagB := CreateAndPrepareDirtyFlag(False); - subToB := TMockSubscriber.Create; - subscriptionMock_B := flagB.State.Subscribe(subToB); - subscriptionA_B := flagA.State.Subscribe(flagB); + flagA := CreateAndPrepareDirtyFlag(False); + flagB := CreateAndPrepareDirtyFlag(False); + subToB := TMockSubscriber.Create; + subscriptionMock_B := flagB.State.Subscribe(subToB); + subscriptionA_B := flagA.State.Subscribe(flagB); - flagA.Notify; // A dirty -> B dirty. subToB notified. - Assert.IsTrue(flagB.State.IsSet, 'Flag B should be dirty after A triggers.'); - Assert.AreEqual(1, subToB.NotifyCount, 'subToB notified once.'); + flagA.Notify; // A dirty -> B dirty. subToB notified. + Assert.IsTrue(flagB.State.IsSet, 'Flag B should be dirty after A triggers.'); + Assert.AreEqual(1, subToB.NotifyCount, 'subToB notified once.'); - flagA.Reset; // A becomes clean. B is still dirty (state change of A to clean doesn't propagate as a "dirty" signal to B). - Assert.IsFalse(flagA.State.IsSet, 'Flag A is clean after reset.'); - Assert.IsTrue(flagB.State.IsSet, 'Flag B remains dirty.'); // B's state doesn't change because A becoming clean doesn't call B.Notify + flagA.Reset; // A becomes clean. B is still dirty (state change of A to clean doesn't propagate as a "dirty" signal to B). + Assert.IsFalse(flagA.State.IsSet, 'Flag A is clean after reset.'); + Assert.IsTrue(flagB.State.IsSet, 'Flag B remains dirty.'); // B's state doesn't change because A becoming clean doesn't call B.Notify - flagA.Notify; // A (was clean) becomes dirty again. A.Notify() returns true. A notifies B. - // B.Notify() is called. B was dirty. B.Notify() sets FFlag to true (no change), returns false. - // So B does NOT notify subToB again. + flagA.Notify; // A (was clean) becomes dirty again. A.Notify() returns true. A notifies B. + // B.Notify() is called. B was dirty. B.Notify() sets FFlag to true (no change), returns false. + // So B does NOT notify subToB again. - Assert.IsTrue(flagA.State.IsSet, 'Flag A is dirty again.'); - Assert.IsTrue(flagB.State.IsSet, 'Flag B is dirty (was already, and A.Notify called B.Notify which set it dirty again).'); - Assert.AreEqual(1, subToB.NotifyCount, 'subToB should NOT be notified again as B did not transition from clean to dirty.'); + Assert.IsTrue(flagA.State.IsSet, 'Flag A is dirty again.'); + Assert.IsTrue(flagB.State.IsSet, 'Flag B is dirty (was already, and A.Notify called B.Notify which set it dirty again).'); + Assert.AreEqual(1, subToB.NotifyCount, 'subToB should NOT be notified again as B did not transition from clean to dirty.'); end; procedure TTestMycDirtyFlag.TestChain_A_B_C_IntermediateBReset_RetriggerA_PropagatesToC; var - flagA, flagB, flagC: IMycDirty; - subToC: TMockSubscriber; - subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; + flagA, flagB, flagC: IMycDirty; + subToC: TMockSubscriber; + subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); - flagB := CreateAndPrepareDirtyFlag(False); - flagC := CreateAndPrepareDirtyFlag(False); - subToC := TMockSubscriber.Create; + flagA := CreateAndPrepareDirtyFlag(False); + flagB := CreateAndPrepareDirtyFlag(False); + flagC := CreateAndPrepareDirtyFlag(False); + subToC := TMockSubscriber.Create; - subscriptionMock_C := flagC.State.Subscribe(subToC); - subscriptionC_B := flagB.State.Subscribe(flagC); - subscriptionB_A := flagA.State.Subscribe(flagB); + subscriptionMock_C := flagC.State.Subscribe(subToC); + subscriptionC_B := flagB.State.Subscribe(flagC); + subscriptionB_A := flagA.State.Subscribe(flagB); - // Initial full propagation - flagA.Notify; // A dirty -> B dirty -> C dirty. subToC notified. - Assert.IsTrue(flagC.State.IsSet, 'Flag C should be dirty initially.'); - Assert.AreEqual(1, subToC.NotifyCount, 'subToC initial count.'); + // Initial full propagation + flagA.Notify; // A dirty -> B dirty -> C dirty. subToC notified. + Assert.IsTrue(flagC.State.IsSet, 'Flag C should be dirty initially.'); + Assert.AreEqual(1, subToC.NotifyCount, 'subToC initial count.'); - // Intermediate reset - flagB.Reset; // B becomes clean. A is dirty, C is dirty. - Assert.IsFalse(flagB.State.IsSet, 'Flag B is clean.'); + // Intermediate reset + flagB.Reset; // B becomes clean. A is dirty, C is dirty. + Assert.IsFalse(flagB.State.IsSet, 'Flag B is clean.'); - // Reset and re-trigger A - flagA.Reset; // A becomes clean. - Assert.IsFalse(flagA.State.IsSet, 'Flag A is clean.'); + // Reset and re-trigger A + flagA.Reset; // A becomes clean. + Assert.IsFalse(flagA.State.IsSet, 'Flag A is clean.'); - flagA.Notify; // A (was clean) -> A dirty. A notifies B. - // B.Notify() called. B was clean -> B dirty. B notifies C. - // C.Notify() called. C was dirty -> C set dirty (no change), C.Notify() returns false. - // So subToC is NOT notified again. + flagA.Notify; // A (was clean) -> A dirty. A notifies B. + // B.Notify() called. B was clean -> B dirty. B notifies C. + // C.Notify() called. C was dirty -> C set dirty (no change), C.Notify() returns false. + // So subToC is NOT notified again. - Assert.IsTrue(flagA.State.IsSet, 'Flag A is dirty again.'); - Assert.IsTrue(flagB.State.IsSet, 'Flag B becomes dirty again.'); - Assert.IsTrue(flagC.State.IsSet, 'Flag C is dirty (was already).'); - Assert.AreEqual(1, subToC.NotifyCount, 'subToC should NOT be notified again.'); + Assert.IsTrue(flagA.State.IsSet, 'Flag A is dirty again.'); + Assert.IsTrue(flagB.State.IsSet, 'Flag B becomes dirty again.'); + Assert.IsTrue(flagC.State.IsSet, 'Flag C is dirty (was already).'); + Assert.AreEqual(1, subToC.NotifyCount, 'subToC should NOT be notified again.'); end; procedure TTestMycDirtyFlag.TestChain_A_B_C_AllReset_RetriggerA_FullPropagation; var - flagA, flagB, flagC: IMycDirty; - subToC: TMockSubscriber; - subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; + flagA, flagB, flagC: IMycDirty; + subToC: TMockSubscriber; + subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); - flagB := CreateAndPrepareDirtyFlag(False); - flagC := CreateAndPrepareDirtyFlag(False); - subToC := TMockSubscriber.Create; + flagA := CreateAndPrepareDirtyFlag(False); + flagB := CreateAndPrepareDirtyFlag(False); + flagC := CreateAndPrepareDirtyFlag(False); + subToC := TMockSubscriber.Create; - subscriptionMock_C := flagC.State.Subscribe(subToC); - subscriptionC_B := flagB.State.Subscribe(flagC); - subscriptionB_A := flagA.State.Subscribe(flagB); + subscriptionMock_C := flagC.State.Subscribe(subToC); + subscriptionC_B := flagB.State.Subscribe(flagC); + subscriptionB_A := flagA.State.Subscribe(flagB); - // All are clean. Trigger A. - flagA.Notify; // A dirty -> B dirty -> C dirty. subToC notified. - Assert.IsTrue(flagC.State.IsSet, 'Flag C dirty after first full propagation.'); - Assert.AreEqual(1, subToC.NotifyCount, 'subToC notified once.'); + // All are clean. Trigger A. + flagA.Notify; // A dirty -> B dirty -> C dirty. subToC notified. + Assert.IsTrue(flagC.State.IsSet, 'Flag C dirty after first full propagation.'); + Assert.AreEqual(1, subToC.NotifyCount, 'subToC notified once.'); - // Reset all - flagA.Reset; - flagB.Reset; - flagC.Reset; - Assert.IsFalse(flagA.State.IsSet, 'Flag A clean.'); - Assert.IsFalse(flagB.State.IsSet, 'Flag B clean.'); - Assert.IsFalse(flagC.State.IsSet, 'Flag C clean.'); - // subToC count is still 1, it's not notified by resets. + // Reset all + flagA.Reset; + flagB.Reset; + flagC.Reset; + Assert.IsFalse(flagA.State.IsSet, 'Flag A clean.'); + Assert.IsFalse(flagB.State.IsSet, 'Flag B clean.'); + Assert.IsFalse(flagC.State.IsSet, 'Flag C clean.'); + // subToC count is still 1, it's not notified by resets. - // Re-trigger A - flagA.Notify; // A (was clean) -> A dirty. A notifies B. - // B.Notify() called. B was clean -> B dirty. B notifies C. - // C.Notify() called. C was clean -> C dirty. C notifies subToC. + // Re-trigger A + flagA.Notify; // A (was clean) -> A dirty. A notifies B. + // B.Notify() called. B was clean -> B dirty. B notifies C. + // C.Notify() called. C was clean -> C dirty. C notifies subToC. - Assert.IsTrue(flagA.State.IsSet, 'Flag A dirty on re-trigger.'); - Assert.IsTrue(flagB.State.IsSet, 'Flag B dirty on re-trigger.'); - Assert.IsTrue(flagC.State.IsSet, 'Flag C dirty on re-trigger.'); - Assert.AreEqual(2, subToC.NotifyCount, 'subToC should be notified a second time.'); + Assert.IsTrue(flagA.State.IsSet, 'Flag A dirty on re-trigger.'); + Assert.IsTrue(flagB.State.IsSet, 'Flag B dirty on re-trigger.'); + Assert.IsTrue(flagC.State.IsSet, 'Flag C dirty on re-trigger.'); + Assert.AreEqual(2, subToC.NotifyCount, 'subToC should be notified a second time.'); end; procedure TTestMycDirtyFlag.TestChain_A_B_C_TriggerA_ResetA_TriggerA_EnsureCNotifiedCorrectly; var - flagA, flagB, flagC: IMycDirty; - subToC: TMockSubscriber; - subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; + flagA, flagB, flagC: IMycDirty; + subToC: TMockSubscriber; + subscriptionB_A, subscriptionC_B, subscriptionMock_C: TState.TSubscription; begin - flagA := CreateAndPrepareDirtyFlag(False); - flagB := CreateAndPrepareDirtyFlag(False); - flagC := CreateAndPrepareDirtyFlag(False); - subToC := TMockSubscriber.Create; + flagA := CreateAndPrepareDirtyFlag(False); + flagB := CreateAndPrepareDirtyFlag(False); + flagC := CreateAndPrepareDirtyFlag(False); + subToC := TMockSubscriber.Create; - subscriptionMock_C := flagC.State.Subscribe(subToC); - subscriptionC_B := flagB.State.Subscribe(flagC); - subscriptionB_A := flagA.State.Subscribe(flagB); + subscriptionMock_C := flagC.State.Subscribe(subToC); + subscriptionC_B := flagB.State.Subscribe(flagC); + subscriptionB_A := flagA.State.Subscribe(flagB); - // 1. Trigger A - flagA.Notify; // A, B, C become dirty. subToC notified (count = 1). - Assert.IsTrue(flagC.State.IsSet, 'C is dirty after 1st trigger.'); - Assert.AreEqual(1, subToC.NotifyCount, 'subToC count after 1st trigger.'); + // 1. Trigger A + flagA.Notify; // A, B, C become dirty. subToC notified (count = 1). + Assert.IsTrue(flagC.State.IsSet, 'C is dirty after 1st trigger.'); + Assert.AreEqual(1, subToC.NotifyCount, 'subToC count after 1st trigger.'); - // 2. Reset A (B and C remain dirty) - flagA.Reset; - Assert.IsFalse(flagA.State.IsSet, 'A is clean.'); - Assert.IsTrue(flagB.State.IsSet, 'B remains dirty.'); - Assert.IsTrue(flagC.State.IsSet, 'C remains dirty.'); + // 2. Reset A (B and C remain dirty) + flagA.Reset; + Assert.IsFalse(flagA.State.IsSet, 'A is clean.'); + Assert.IsTrue(flagB.State.IsSet, 'B remains dirty.'); + Assert.IsTrue(flagC.State.IsSet, 'C remains dirty.'); - // 3. Trigger A again - flagA.Notify; // A (was clean) becomes dirty. A notifies B. - // B.Notify() is called. B was dirty. B.Notify sets FFlag to true (no change), returns false. - // B does NOT notify C. C remains dirty. subToC is NOT notified again. - Assert.IsTrue(flagA.State.IsSet, 'A is dirty after 2nd trigger.'); - Assert.IsTrue(flagB.State.IsSet, 'B is still dirty (state did not flip to clean then dirty).'); - Assert.IsTrue(flagC.State.IsSet, 'C is still dirty.'); - Assert.AreEqual(1, subToC.NotifyCount, 'subToC count should remain 1.'); + // 3. Trigger A again + flagA.Notify; // A (was clean) becomes dirty. A notifies B. + // B.Notify() is called. B was dirty. B.Notify sets FFlag to true (no change), returns false. + // B does NOT notify C. C remains dirty. subToC is NOT notified again. + Assert.IsTrue(flagA.State.IsSet, 'A is dirty after 2nd trigger.'); + Assert.IsTrue(flagB.State.IsSet, 'B is still dirty (state did not flip to clean then dirty).'); + Assert.IsTrue(flagC.State.IsSet, 'C is still dirty.'); + Assert.AreEqual(1, subToC.NotifyCount, 'subToC count should remain 1.'); end; initialization - TDUnitX.RegisterTestFixture(TTestMycDirtyFlag); + TDUnitX.RegisterTestFixture(TTestMycDirtyFlag); end. diff --git a/Test/TestSignals_Latch.pas b/Test/TestSignals_Latch.pas index 7c647a1..a892a81 100644 --- a/Test/TestSignals_Latch.pas +++ b/Test/TestSignals_Latch.pas @@ -4,87 +4,87 @@ unit TestSignals_Latch; interface uses - DUnitX.TestFramework, - System.SysUtils, - Myc.Signals; // Unit under test, using TMycLatch static members + DUnitX.TestFramework, + System.SysUtils, + Myc.Signals; // Unit under test, using TMycLatch static members type - // Helper class to mock a subscriber. - TMockSubscriber = class(TInterfacedObject, IMycSubscriber) - public - NotifyCount: Integer; - NotifyShouldReturn: Boolean; // Determines what this mock's Notify method returns - WasCalled: Boolean; + // Helper class to mock a subscriber. + TMockSubscriber = class(TInterfacedObject, IMycSubscriber) + public + NotifyCount: Integer; + NotifyShouldReturn: Boolean; // Determines what this mock's Notify method returns + WasCalled: Boolean; - constructor Create(AShouldReturn: Boolean = True); // Parameter name AShouldReturn for clarity - function Notify: Boolean; // IMycSubscriber implementation. - end; + constructor Create(AShouldReturn: Boolean = True); // Parameter name AShouldReturn for clarity + function Notify: Boolean; // IMycSubscriber implementation. + end; - [TestFixture] - TTestMycLatch = class(TObject) - public - [Setup] - procedure Setup; - [TearDown] - procedure TearDown; + [TestFixture] + TTestMycLatch = class(TObject) + public + [Setup] + procedure Setup; + [TearDown] + procedure TearDown; - // --- Category 1: Basic Counter and State Functionality (Parameterized) --- - [TestCase('InitialPositive', '1,False')] - [TestCase('InitialZero_ReturnsNullLatch', '0,True')] - [TestCase('InitialNegative_ReturnsNullLatch', '-1,True')] - [TestCase('InitialLargePositive', '5,False')] - procedure TestCreate_InitialState(InitialCount: Integer; ExpectedIsSet: Boolean); + // --- Category 1: Basic Counter and State Functionality (Parameterized) --- + [TestCase('InitialPositive', '1,False')] + [TestCase('InitialZero_ReturnsNullLatch', '0,True')] + [TestCase('InitialNegative_ReturnsNullLatch', '-1,True')] + [TestCase('InitialLargePositive', '5,False')] + procedure TestCreate_InitialState(InitialCount: Integer; ExpectedIsSet: Boolean); - [TestCase('DecrementPositiveToZero', '1,False,True')] // InitialCount, ExpectedReturnFromLatchNotify, ExpectedIsSetAfterNotify - [TestCase('DecrementPositiveToPositive', '2,True,False')] - [TestCase('DecrementZeroToNegative', '0,False,True')] // Latch.Notify on count 0 returns false (0 > 0 is false) - [TestCase('DecrementNegativeToNegative', '-1,False,True')] // Latch.Notify on count -1 returns false (-1 > 0 is false) - procedure TestNotify_ReturnValueAndState_AfterOneNotify(InitialCount: Integer; ExpectedReturn: Boolean; ExpectedIsSet: Boolean); + [TestCase('DecrementPositiveToZero', '1,False,True')] // InitialCount, ExpectedReturnFromLatchNotify, ExpectedIsSetAfterNotify + [TestCase('DecrementPositiveToPositive', '2,True,False')] + [TestCase('DecrementZeroToNegative', '0,False,True')] // Latch.Notify on count 0 returns false (0 > 0 is false) + [TestCase('DecrementNegativeToNegative', '-1,False,True')] // Latch.Notify on count -1 returns false (-1 > 0 is false) + procedure TestNotify_ReturnValueAndState_AfterOneNotify(InitialCount: Integer; ExpectedReturn: Boolean; ExpectedIsSet: Boolean); - [Test] - procedure TestNotify_DecrementsCounter_StateChanges; - [Test] - procedure TestNotify_MultipleNotifies_CounterBecomesNegativeAndStaysSet; + [Test] + procedure TestNotify_DecrementsCounter_StateChanges; + [Test] + procedure TestNotify_MultipleNotifies_CounterBecomesNegativeAndStaysSet; - // --- Category 2: Notification to Subscribers --- - [Test] - procedure TestSubscriber_Single_IsNotifiedWhenLatchSet; - [Test] - procedure TestSubscriber_Multiple_AreNotifiedWhenLatchSet; - [Test] - procedure TestSubscriber_NotNotified_BeforeLatchSet; - [Test] - procedure TestSubscriber_NotifiedOnlyOnce_AfterLatchSetAndUnadvised; // Clarified name - [Test] - procedure TestSubscribe_ToAlreadySetLatch_NotifiesImmediately; + // --- Category 2: Notification to Subscribers --- + [Test] + procedure TestSubscriber_Single_IsNotifiedWhenLatchSet; + [Test] + procedure TestSubscriber_Multiple_AreNotifiedWhenLatchSet; + [Test] + procedure TestSubscriber_NotNotified_BeforeLatchSet; + [Test] + procedure TestSubscriber_NotifiedOnlyOnce_AfterLatchSetAndUnadvised; // Clarified name + [Test] + procedure TestSubscribe_ToAlreadySetLatch_NotifiesImmediately; - // --- Category 3: Chaining and Cascading Latches --- - [Test] - procedure TestChaining_A_Notifies_B; - [Test] - procedure TestCascade_A_Notifies_B_Notifies_C; - [Test] - procedure TestChaining_B_NeedsMultipleNotifiesFromA_WithSubscriberOnB; + // --- Category 3: Chaining and Cascading Latches --- + [Test] + procedure TestChaining_A_Notifies_B; + [Test] + procedure TestCascade_A_Notifies_B_Notifies_C; + [Test] + procedure TestChaining_B_NeedsMultipleNotifiesFromA_WithSubscriberOnB; - // --- Category 4: Special Cases --- - [Test] - procedure TestInitiallySetLatch_NotifiesNewSubscriberImmediately; // Using CreateLatch(0) + // --- Category 4: Special Cases --- + [Test] + procedure TestInitiallySetLatch_NotifiesNewSubscriberImmediately; // Using CreateLatch(0) - [Test] - procedure TestUnsubscribe_SubscriberNotNotified; + [Test] + procedure TestUnsubscribe_SubscriberNotNotified; - // --- Category 5: Counter Integrity / State for Later Subscribers --- - [Test] - procedure TestMultipleTriggersNoSubscriber_StateCorrectForLaterSubscriber; + // --- Category 5: Counter Integrity / State for Later Subscribers --- + [Test] + procedure TestMultipleTriggersNoSubscriber_StateCorrectForLaterSubscriber; - // --- Category 6: UnadviseAll Behavior on Latch Set --- - [Test] - procedure TestLatchSet_ClearsSubscribers_NoFurtherNotification; - [Test] - procedure TestLatchSet_SubscriptionFinalize_IsSafePostUnadviseAll; - [Test] - procedure TestLatchSet_NewSubscriberToSetLatch_NotifiedImmediatelyButNotPersistedForLatchNotify; - end; + // --- Category 6: UnadviseAll Behavior on Latch Set --- + [Test] + procedure TestLatchSet_ClearsSubscribers_NoFurtherNotification; + [Test] + procedure TestLatchSet_SubscriptionFinalize_IsSafePostUnadviseAll; + [Test] + procedure TestLatchSet_NewSubscriberToSetLatch_NotifiedImmediatelyButNotPersistedForLatchNotify; + end; implementation @@ -92,409 +92,425 @@ implementation constructor TMockSubscriber.Create(AShouldReturn: Boolean = True); begin - inherited Create; - NotifyCount := 0; - NotifyShouldReturn := AShouldReturn; - WasCalled := False; + inherited Create; + NotifyCount := 0; + NotifyShouldReturn := AShouldReturn; + WasCalled := False; end; function TMockSubscriber.Notify: Boolean; begin - Inc(NotifyCount); - WasCalled := True; - Result := NotifyShouldReturn; // This mock subscriber returns what it's configured to. + Inc(NotifyCount); + WasCalled := True; + Result := NotifyShouldReturn; // This mock subscriber returns what it's configured to. end; { TTestMycLatch } procedure TTestMycLatch.Setup; begin - // Per-test setup code can go here (if any). + // Per-test setup code can go here (if any). end; procedure TTestMycLatch.TearDown; begin - // Per-test teardown code can go here (if any). + // Per-test teardown code can go here (if any). end; // --- Category 1: Basic Counter and State Functionality (Parameterized) --- procedure TTestMycLatch.TestCreate_InitialState(InitialCount: Integer; ExpectedIsSet: Boolean); var - latch: IMycLatch; + latch: IMycLatch; begin - // TMycLatch.CreateLatch returns TMycLatch.Null if InitialCount <= 0 - latch := TLatch.Construct(InitialCount); - Assert.AreEqual(ExpectedIsSet, latch.State.IsSet, 'Latch initial IsSet state mismatch for count ' + IntToStr(InitialCount) + '.'); + // TMycLatch.CreateLatch returns TMycLatch.Null if InitialCount <= 0 + latch := TLatch.Construct(InitialCount); + Assert.AreEqual(ExpectedIsSet, latch.State.IsSet, 'Latch initial IsSet state mismatch for count ' + IntToStr(InitialCount) + '.'); end; -procedure TTestMycLatch.TestNotify_ReturnValueAndState_AfterOneNotify(InitialCount: Integer; ExpectedReturn: Boolean; ExpectedIsSet: Boolean); +procedure TTestMycLatch.TestNotify_ReturnValueAndState_AfterOneNotify( + InitialCount: Integer; + ExpectedReturn: Boolean; + ExpectedIsSet: Boolean +); var - latch: IMycLatch; - returnedValueFromNotify: Boolean; + latch: IMycLatch; + returnedValueFromNotify: Boolean; begin - latch := TLatch.Construct(InitialCount); - returnedValueFromNotify := latch.Notify; // This is IMycLatch (as IMycSubscriber).Notify + latch := TLatch.Construct(InitialCount); + returnedValueFromNotify := latch.Notify; // This is IMycLatch (as IMycSubscriber).Notify - Assert.AreEqual(ExpectedReturn, returnedValueFromNotify, 'Unexpected return value from Latch.Notify call for initial count ' + IntToStr(InitialCount) + '.'); - Assert.AreEqual(ExpectedIsSet, latch.State.IsSet, 'Unexpected IsSet state after Latch.Notify call for initial count ' + IntToStr(InitialCount) + '.'); + Assert.AreEqual( + ExpectedReturn, + returnedValueFromNotify, + 'Unexpected return value from Latch.Notify call for initial count ' + IntToStr(InitialCount) + '.' + ); + Assert.AreEqual( + ExpectedIsSet, + latch.State.IsSet, + 'Unexpected IsSet state after Latch.Notify call for initial count ' + IntToStr(InitialCount) + '.' + ); end; procedure TTestMycLatch.TestNotify_DecrementsCounter_StateChanges; var - latch: IMycLatch; + latch: IMycLatch; begin - latch := TLatch.Construct(1); - Assert.IsFalse(latch.State.IsSet, 'Latch should initially not be set (Count=1).'); - latch.Notify; // Count becomes 0 - Assert.IsTrue(latch.State.IsSet, 'Latch should be set after Notify (Count became 0).'); + latch := TLatch.Construct(1); + Assert.IsFalse(latch.State.IsSet, 'Latch should initially not be set (Count=1).'); + latch.Notify; // Count becomes 0 + Assert.IsTrue(latch.State.IsSet, 'Latch should be set after Notify (Count became 0).'); end; procedure TTestMycLatch.TestNotify_MultipleNotifies_CounterBecomesNegativeAndStaysSet; var - latch: IMycLatch; + latch: IMycLatch; begin - latch := TLatch.Construct(1); - latch.Notify; // Count becomes 0, IsSet = True - Assert.IsTrue(latch.State.IsSet, 'Latch should be set after first Notify.'); - latch.Notify; // Count becomes -1, IsSet should remain True - Assert.IsTrue(latch.State.IsSet, 'Latch should remain set after second Notify.'); + latch := TLatch.Construct(1); + latch.Notify; // Count becomes 0, IsSet = True + Assert.IsTrue(latch.State.IsSet, 'Latch should be set after first Notify.'); + latch.Notify; // Count becomes -1, IsSet should remain True + Assert.IsTrue(latch.State.IsSet, 'Latch should remain set after second Notify.'); end; // --- Category 2: Notification to Subscribers --- procedure TTestMycLatch.TestSubscriber_Single_IsNotifiedWhenLatchSet; var - latch: IMycLatch; - mockSub: TMockSubscriber; - subscription: TState.TSubscription; + latch: IMycLatch; + mockSub: TMockSubscriber; + subscription: TState.TSubscription; begin - latch := TLatch.Construct(1); - mockSub := TMockSubscriber.Create; - subscription := latch.State.Subscribe(mockSub); // Subscribing to the Latch's state + latch := TLatch.Construct(1); + mockSub := TMockSubscriber.Create; + subscription := latch.State.Subscribe(mockSub); // Subscribing to the Latch's state - Assert.IsFalse(latch.State.IsSet, 'Latch should initially not be set.'); - Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should not have been notified yet (before latch set).'); + Assert.IsFalse(latch.State.IsSet, 'Latch should initially not be set.'); + Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should not have been notified yet (before latch set).'); - latch.Notify; // Latch becomes set, notifies subscribers + latch.Notify; // Latch becomes set, notifies subscribers - Assert.IsTrue(latch.State.IsSet, 'Latch should be set after its Notify is called.'); - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should have been notified once when latch becomes set.'); + Assert.IsTrue(latch.State.IsSet, 'Latch should be set after its Notify is called.'); + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should have been notified once when latch becomes set.'); end; procedure TTestMycLatch.TestSubscriber_Multiple_AreNotifiedWhenLatchSet; var - latch: IMycLatch; - mockSub1, mockSub2, mockSub3: TMockSubscriber; - sub1, sub2, sub3: TState.TSubscription; // Keep subscriptions in scope + latch: IMycLatch; + mockSub1, mockSub2, mockSub3: TMockSubscriber; + sub1, sub2, sub3: TState.TSubscription; // Keep subscriptions in scope begin - latch := TLatch.Construct(1); - mockSub1 := TMockSubscriber.Create; - mockSub2 := TMockSubscriber.Create; - mockSub3 := TMockSubscriber.Create; + latch := TLatch.Construct(1); + mockSub1 := TMockSubscriber.Create; + mockSub2 := TMockSubscriber.Create; + mockSub3 := TMockSubscriber.Create; - sub1 := latch.State.Subscribe(mockSub1); - sub2 := latch.State.Subscribe(mockSub2); - sub3 := latch.State.Subscribe(mockSub3); + sub1 := latch.State.Subscribe(mockSub1); + sub2 := latch.State.Subscribe(mockSub2); + sub3 := latch.State.Subscribe(mockSub3); - latch.Notify; // Latch becomes set + latch.Notify; // Latch becomes set - Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 notification count mismatch.'); - Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 notification count mismatch.'); - Assert.AreEqual(1, mockSub3.NotifyCount, 'MockSub3 notification count mismatch.'); + Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 notification count mismatch.'); + Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 notification count mismatch.'); + Assert.AreEqual(1, mockSub3.NotifyCount, 'MockSub3 notification count mismatch.'); end; procedure TTestMycLatch.TestSubscriber_NotNotified_BeforeLatchSet; var - latch: IMycLatch; - mockSub: TMockSubscriber; - subscription: TState.TSubscription; + latch: IMycLatch; + mockSub: TMockSubscriber; + subscription: TState.TSubscription; begin - latch := TLatch.Construct(2); // Count = 2 - mockSub := TMockSubscriber.Create; - subscription := latch.State.Subscribe(mockSub); + latch := TLatch.Construct(2); // Count = 2 + mockSub := TMockSubscriber.Create; + subscription := latch.State.Subscribe(mockSub); - Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should not be notified upon subscription if latch is not set.'); - latch.Notify; // Count becomes 1, still not set - Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should still not be notified as latch is not yet set (Count=1).'); + Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should not be notified upon subscription if latch is not set.'); + latch.Notify; // Count becomes 1, still not set + Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should still not be notified as latch is not yet set (Count=1).'); end; procedure TTestMycLatch.TestSubscriber_NotifiedOnlyOnce_AfterLatchSetAndUnadvised; var - latch: IMycLatch; - mockSub: TMockSubscriber; - subscription: TState.TSubscription; + latch: IMycLatch; + mockSub: TMockSubscriber; + subscription: TState.TSubscription; begin - latch := TLatch.Construct(1); - mockSub := TMockSubscriber.Create; - subscription := latch.State.Subscribe(mockSub); + latch := TLatch.Construct(1); + mockSub := TMockSubscriber.Create; + subscription := latch.State.Subscribe(mockSub); - latch.Notify; // Sets latch, notifies MockSub. Subscribers are then unadvised by UnadviseAll. - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub notify count should be 1 after latch set.'); + latch.Notify; // Sets latch, notifies MockSub. Subscribers are then unadvised by UnadviseAll. + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub notify count should be 1 after latch set.'); - latch.Notify; // Call Notify on latch again (FCount becomes more negative). - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub notify count should remain 1 (not notified again as it was unadvised).'); + latch.Notify; // Call Notify on latch again (FCount becomes more negative). + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub notify count should remain 1 (not notified again as it was unadvised).'); end; procedure TTestMycLatch.TestSubscribe_ToAlreadySetLatch_NotifiesImmediately; var - latch: IMycLatch; - mockSub1, mockSub2: TMockSubscriber; - subscription1, subscription2: TState.TSubscription; + latch: IMycLatch; + mockSub1, mockSub2: TMockSubscriber; + subscription1, subscription2: TState.TSubscription; begin - latch := TLatch.Construct(1); // Create with count 1 - mockSub1 := TMockSubscriber.Create; - subscription1 := latch.State.Subscribe(mockSub1); // Subscribe before set + latch := TLatch.Construct(1); // Create with count 1 + mockSub1 := TMockSubscriber.Create; + subscription1 := latch.State.Subscribe(mockSub1); // Subscribe before set - latch.Notify; // Latch becomes set. mockSub1 is notified. + latch.Notify; // Latch becomes set. mockSub1 is notified. - Assert.IsTrue(latch.State.IsSet, 'Latch should be set after initial trigger.'); - Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 should have been notified once.'); + Assert.IsTrue(latch.State.IsSet, 'Latch should be set after initial trigger.'); + Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 should have been notified once.'); - // Attempt to subscribe mockSub2 after the latch is already set. - mockSub2 := TMockSubscriber.Create; - subscription2 := latch.State.Subscribe(mockSub2); // TMycLatch.Subscribe (via TMycAbstractFlag) notifies immediately if already set. + // Attempt to subscribe mockSub2 after the latch is already set. + mockSub2 := TMockSubscriber.Create; + subscription2 := latch.State.Subscribe(mockSub2); // TMycLatch.Subscribe (via TMycAbstractFlag) notifies immediately if already set. - Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 should be notified immediately upon subscribing to an already set latch.'); + Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 should be notified immediately upon subscribing to an already set latch.'); - latch.Notify; // Call Notify on latch again (FCount becomes more negative). - Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 notify count should remain 1 (was unadvised).'); - Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 notify count should remain 1 (was only notified on subscribe, not added to list).'); + latch.Notify; // Call Notify on latch again (FCount becomes more negative). + Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 notify count should remain 1 (was unadvised).'); + Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 notify count should remain 1 (was only notified on subscribe, not added to list).'); end; // --- Category 3: Chaining and Cascading Latches --- procedure TTestMycLatch.TestChaining_A_Notifies_B; var - latchA, latchB: IMycLatch; - mockSubForB: TMockSubscriber; - subHandle_B_listens_A, subHandle_Mock_listens_B: TState.TSubscription; + latchA, latchB: IMycLatch; + mockSubForB: TMockSubscriber; + subHandle_B_listens_A, subHandle_Mock_listens_B: TState.TSubscription; begin - latchA := TLatch.Construct(1); - latchB := TLatch.Construct(1); // latchB is an IMycSubscriber - mockSubForB := TMockSubscriber.Create; + latchA := TLatch.Construct(1); + latchB := TLatch.Construct(1); // latchB is an IMycSubscriber + mockSubForB := TMockSubscriber.Create; - subHandle_Mock_listens_B := latchB.State.Subscribe(mockSubForB); - // LatchA's state is an IMycSignal. LatchB (as IMycSubscriber) subscribes to it. - subHandle_B_listens_A := latchA.State.Subscribe(latchB); + subHandle_Mock_listens_B := latchB.State.Subscribe(mockSubForB); + // LatchA's state is an IMycSignal. LatchB (as IMycSubscriber) subscribes to it. + subHandle_B_listens_A := latchA.State.Subscribe(latchB); - Assert.IsFalse(latchA.State.IsSet, 'LatchA initially not set.'); - Assert.IsFalse(latchB.State.IsSet, 'LatchB initially not set.'); - Assert.AreEqual(0, mockSubForB.NotifyCount, 'MockSubForB initially not notified.'); + Assert.IsFalse(latchA.State.IsSet, 'LatchA initially not set.'); + Assert.IsFalse(latchB.State.IsSet, 'LatchB initially not set.'); + Assert.AreEqual(0, mockSubForB.NotifyCount, 'MockSubForB initially not notified.'); - latchA.Notify; // Call Notify on LatchA (as IMycSubscriber) + latchA.Notify; // Call Notify on LatchA (as IMycSubscriber) - Assert.IsTrue(latchA.State.IsSet, 'LatchA should be set after notify.'); - Assert.IsTrue(latchB.State.IsSet, 'LatchB should be set after being notified by LatchA.'); - Assert.AreEqual(1, mockSubForB.NotifyCount, 'MockSubForB should have been notified by LatchB.'); + Assert.IsTrue(latchA.State.IsSet, 'LatchA should be set after notify.'); + Assert.IsTrue(latchB.State.IsSet, 'LatchB should be set after being notified by LatchA.'); + Assert.AreEqual(1, mockSubForB.NotifyCount, 'MockSubForB should have been notified by LatchB.'); end; procedure TTestMycLatch.TestCascade_A_Notifies_B_Notifies_C; var - latchA, latchB, latchC: IMycLatch; - mockSubForC: TMockSubscriber; - sub_Mock_C, sub_C_B, sub_B_A: TState.TSubscription; + latchA, latchB, latchC: IMycLatch; + mockSubForC: TMockSubscriber; + sub_Mock_C, sub_C_B, sub_B_A: TState.TSubscription; begin - latchA := TLatch.Construct(1); - latchB := TLatch.Construct(1); - latchC := TLatch.Construct(1); - mockSubForC := TMockSubscriber.Create; + latchA := TLatch.Construct(1); + latchB := TLatch.Construct(1); + latchC := TLatch.Construct(1); + mockSubForC := TMockSubscriber.Create; - sub_Mock_C := latchC.State.Subscribe(mockSubForC); - sub_C_B := latchB.State.Subscribe(latchC); // LatchC subscribes to LatchB's state - sub_B_A := latchA.State.Subscribe(latchB); // LatchB subscribes to LatchA's state + sub_Mock_C := latchC.State.Subscribe(mockSubForC); + sub_C_B := latchB.State.Subscribe(latchC); // LatchC subscribes to LatchB's state + sub_B_A := latchA.State.Subscribe(latchB); // LatchB subscribes to LatchA's state - latchA.Notify; // Call Notify on LatchA + latchA.Notify; // Call Notify on LatchA - Assert.IsTrue(latchA.State.IsSet, 'LatchA state mismatch in cascade.'); - Assert.IsTrue(latchB.State.IsSet, 'LatchB state mismatch in cascade.'); - Assert.IsTrue(latchC.State.IsSet, 'LatchC state mismatch in cascade.'); - Assert.AreEqual(1, mockSubForC.NotifyCount, 'MockSubForC notification count mismatch in cascade.'); + Assert.IsTrue(latchA.State.IsSet, 'LatchA state mismatch in cascade.'); + Assert.IsTrue(latchB.State.IsSet, 'LatchB state mismatch in cascade.'); + Assert.IsTrue(latchC.State.IsSet, 'LatchC state mismatch in cascade.'); + Assert.AreEqual(1, mockSubForC.NotifyCount, 'MockSubForC notification count mismatch in cascade.'); end; procedure TTestMycLatch.TestChaining_B_NeedsMultipleNotifiesFromA_WithSubscriberOnB; var - latchA, latchB: IMycLatch; - mockSubForB: TMockSubscriber; - sub_Mock_B, sub_B_A: TState.TSubscription; + latchA, latchB: IMycLatch; + mockSubForB: TMockSubscriber; + sub_Mock_B, sub_B_A: TState.TSubscription; begin - // LatchA needs 2 notifies to become set. LatchB needs 1 notify to become set. - // LatchB subscribes to LatchA. So LatchB will be notified once LatchA becomes set. - latchA := TLatch.Construct(2); - latchB := TLatch.Construct(1); - mockSubForB := TMockSubscriber.Create; + // LatchA needs 2 notifies to become set. LatchB needs 1 notify to become set. + // LatchB subscribes to LatchA. So LatchB will be notified once LatchA becomes set. + latchA := TLatch.Construct(2); + latchB := TLatch.Construct(1); + mockSubForB := TMockSubscriber.Create; - sub_Mock_B := latchB.State.Subscribe(mockSubForB); - sub_B_A := latchA.State.Subscribe(latchB); + sub_Mock_B := latchB.State.Subscribe(mockSubForB); + sub_B_A := latchA.State.Subscribe(latchB); - latchA.Notify; // First notify for LatchA (count becomes 1) - Assert.IsFalse(latchA.State.IsSet, 'LatchA should not be set after first notify of two.'); - Assert.IsFalse(latchB.State.IsSet, 'LatchB should not have been triggered yet by LatchA.'); - Assert.AreEqual(0, mockSubForB.NotifyCount, 'MockSubForB should not have been notified yet.'); + latchA.Notify; // First notify for LatchA (count becomes 1) + Assert.IsFalse(latchA.State.IsSet, 'LatchA should not be set after first notify of two.'); + Assert.IsFalse(latchB.State.IsSet, 'LatchB should not have been triggered yet by LatchA.'); + Assert.AreEqual(0, mockSubForB.NotifyCount, 'MockSubForB should not have been notified yet.'); - latchA.Notify; // Second notify for LatchA (count becomes 0, LatchA becomes set) - Assert.IsTrue(latchA.State.IsSet, 'LatchA should be set after second notify.'); - // When LatchA becomes set, it notifies its subscribers (LatchB). LatchB.Notify is called. - Assert.IsTrue(latchB.State.IsSet, 'LatchB should now be set by LatchA.'); - Assert.AreEqual(1, mockSubForB.NotifyCount, 'MockSubForB should have been notified by LatchB.'); + latchA.Notify; // Second notify for LatchA (count becomes 0, LatchA becomes set) + Assert.IsTrue(latchA.State.IsSet, 'LatchA should be set after second notify.'); + // When LatchA becomes set, it notifies its subscribers (LatchB). LatchB.Notify is called. + Assert.IsTrue(latchB.State.IsSet, 'LatchB should now be set by LatchA.'); + Assert.AreEqual(1, mockSubForB.NotifyCount, 'MockSubForB should have been notified by LatchB.'); end; // --- Category 4: Special Cases --- procedure TTestMycLatch.TestInitiallySetLatch_NotifiesNewSubscriberImmediately; var - latch: IMycLatch; // Will be TMycLatch.Null - mockSub: TMockSubscriber; - subscription: TState.TSubscription; + latch: IMycLatch; // Will be TMycLatch.Null + mockSub: TMockSubscriber; + subscription: TState.TSubscription; begin - latch := TLatch.Construct(0); // Returns TMycLatch.Null which is set. - mockSub := TMockSubscriber.Create; + latch := TLatch.Construct(0); // Returns TMycLatch.Null which is set. + mockSub := TMockSubscriber.Create; - subscription := latch.State.Subscribe(mockSub); // TMycLatch.Subscribe notifies immediately if already set. + subscription := latch.State.Subscribe(mockSub); // TMycLatch.Subscribe notifies immediately if already set. - Assert.IsTrue(latch.State.IsSet, 'Latch IsSet property mismatch (should be true for Null latch).'); - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should be notified immediately upon subscribing to an initially set latch.'); + Assert.IsTrue(latch.State.IsSet, 'Latch IsSet property mismatch (should be true for Null latch).'); + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should be notified immediately upon subscribing to an initially set latch.'); end; procedure TTestMycLatch.TestUnsubscribe_SubscriberNotNotified; var - latch: IMycLatch; - mockSub: TMockSubscriber; - subscription: TState.TSubscription; + latch: IMycLatch; + mockSub: TMockSubscriber; + subscription: TState.TSubscription; begin - latch := TLatch.Construct(1); - mockSub := TMockSubscriber.Create; + latch := TLatch.Construct(1); + mockSub := TMockSubscriber.Create; - subscription := latch.State.Subscribe(mockSub); - subscription.Unsubscribe; // Explicitly call Unsubscribe on the record + subscription := latch.State.Subscribe(mockSub); + subscription.Unsubscribe; // Explicitly call Unsubscribe on the record - latch.Notify; // Latch becomes set + latch.Notify; // Latch becomes set - Assert.AreEqual(0, mockSub.NotifyCount, 'Unsubscribed MockSub should not be notified.'); + Assert.AreEqual(0, mockSub.NotifyCount, 'Unsubscribed MockSub should not be notified.'); end; // --- Category 5: Counter Integrity / State for Later Subscribers --- procedure TTestMycLatch.TestMultipleTriggersNoSubscriber_StateCorrectForLaterSubscriber; var - latch: IMycLatch; - mockSub: TMockSubscriber; - subscription: TState.TSubscription; + latch: IMycLatch; + mockSub: TMockSubscriber; + subscription: TState.TSubscription; begin - latch := TLatch.Construct(3); + latch := TLatch.Construct(3); - latch.Notify; // Count -> 2 - latch.Notify; // Count -> 1 - Assert.IsFalse(latch.State.IsSet, 'Latch should not be set yet after partial notifies.'); + latch.Notify; // Count -> 2 + latch.Notify; // Count -> 1 + Assert.IsFalse(latch.State.IsSet, 'Latch should not be set yet after partial notifies.'); - mockSub := TMockSubscriber.Create; - subscription := latch.State.Subscribe(mockSub); - Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should not be notified on subscribe if latch not yet set.'); + mockSub := TMockSubscriber.Create; + subscription := latch.State.Subscribe(mockSub); + Assert.AreEqual(0, mockSub.NotifyCount, 'MockSub should not be notified on subscribe if latch not yet set.'); - latch.Notify; // Count -> 0, Latch becomes set and notifies mockSub - Assert.IsTrue(latch.State.IsSet, 'Latch should now be set.'); - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should have been notified when latch becomes set.'); + latch.Notify; // Count -> 0, Latch becomes set and notifies mockSub + Assert.IsTrue(latch.State.IsSet, 'Latch should now be set.'); + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should have been notified when latch becomes set.'); end; // --- Category 6: UnadviseAll Behavior on Latch Set --- procedure TTestMycLatch.TestLatchSet_ClearsSubscribers_NoFurtherNotification; var - latch: IMycLatch; - mockSub1, mockSub2: TMockSubscriber; - subscription1, subscription2: TState.TSubscription; + latch: IMycLatch; + mockSub1, mockSub2: TMockSubscriber; + subscription1, subscription2: TState.TSubscription; begin - latch := TLatch.Construct(1); - mockSub1 := TMockSubscriber.Create; - mockSub2 := TMockSubscriber.Create; + latch := TLatch.Construct(1); + mockSub1 := TMockSubscriber.Create; + mockSub2 := TMockSubscriber.Create; - subscription1 := latch.State.Subscribe(mockSub1); - subscription2 := latch.State.Subscribe(mockSub2); + subscription1 := latch.State.Subscribe(mockSub1); + subscription2 := latch.State.Subscribe(mockSub2); - Assert.AreEqual(0, mockSub1.NotifyCount, 'MockSub1 initial NotifyCount should be 0.'); - Assert.AreEqual(0, mockSub2.NotifyCount, 'MockSub2 initial NotifyCount should be 0.'); + Assert.AreEqual(0, mockSub1.NotifyCount, 'MockSub1 initial NotifyCount should be 0.'); + Assert.AreEqual(0, mockSub2.NotifyCount, 'MockSub2 initial NotifyCount should be 0.'); - latch.Notify; // FCount becomes 0. Subscribers notified, then UnadviseAll called. + latch.Notify; // FCount becomes 0. Subscribers notified, then UnadviseAll called. - Assert.IsTrue(latch.State.IsSet, 'Latch should be set.'); - Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 should have been notified once when latch became set.'); - Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 should have been notified once when latch became set.'); + Assert.IsTrue(latch.State.IsSet, 'Latch should be set.'); + Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 should have been notified once when latch became set.'); + Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 should have been notified once when latch became set.'); - latch.Notify; // Call Notify on the latch again (FCount becomes -1) + latch.Notify; // Call Notify on the latch again (FCount becomes -1) - Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 should NOT be notified again after UnadviseAll.'); - Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 should NOT be notified again after UnadviseAll.'); + Assert.AreEqual(1, mockSub1.NotifyCount, 'MockSub1 should NOT be notified again after UnadviseAll.'); + Assert.AreEqual(1, mockSub2.NotifyCount, 'MockSub2 should NOT be notified again after UnadviseAll.'); end; procedure TTestMycLatch.TestLatchSet_SubscriptionFinalize_IsSafePostUnadviseAll; var - latch: IMycLatch; - mockSub: TMockSubscriber; - // 'subscription' will be declared in an inner scope to control its finalization + latch: IMycLatch; + mockSub: TMockSubscriber; +// 'subscription' will be declared in an inner scope to control its finalization begin - latch := TLatch.Construct(1); - mockSub := TMockSubscriber.Create; + latch := TLatch.Construct(1); + mockSub := TMockSubscriber.Create; - var noException: Boolean := True; - try - begin // Inner block to control lifetime of 'subscription' - var subscription: TState.TSubscription; // Local to this block - subscription := latch.State.Subscribe(mockSub); + var noException: Boolean := True; + try + begin // Inner block to control lifetime of 'subscription' + var subscription: TState.TSubscription; // Local to this block + subscription := latch.State.Subscribe(mockSub); - latch.Notify; // Sets the latch, mockSub is notified, UnadviseAll is called internally. - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub was notified when latch set.'); + latch.Notify; // Sets the latch, mockSub is notified, UnadviseAll is called internally. + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub was notified when latch set.'); - // When 'subscription' goes out of scope at the end of this 'begin..end' block, - // its Finalize operator will be called, which in turn calls subscription.Unsubscribe. - // This happens *after* UnadviseAll was triggered by latch.Notify. - end; // <-- subscription.Finalize (and thus Unsubscribe) is called here. - except - on E: Exception do - begin - noException := False; - // Optional: Log.Error('Exception in TestLatchSet_SubscriptionFinalize_IsSafePostUnadviseAll: ' + E.Message); + // When 'subscription' goes out of scope at the end of this 'begin..end' block, + // its Finalize operator will be called, which in turn calls subscription.Unsubscribe. + // This happens *after* UnadviseAll was triggered by latch.Notify. + end; // <-- subscription.Finalize (and thus Unsubscribe) is called here. + except + on E: Exception do + begin + noException := False; + // Optional: Log.Error('Exception in TestLatchSet_SubscriptionFinalize_IsSafePostUnadviseAll: ' + E.Message); + end; end; - end; - Assert.IsTrue(noException, 'Finalizing subscription after Latch set (and UnadviseAll) should not raise an exception.'); + Assert.IsTrue(noException, 'Finalizing subscription after Latch set (and UnadviseAll) should not raise an exception.'); - // Further check: calling Notify on latch again should not affect the original mockSub - latch.Notify; - Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should not be notified after its subscription was finalized post UnadviseAll.'); + // Further check: calling Notify on latch again should not affect the original mockSub + latch.Notify; + Assert.AreEqual(1, mockSub.NotifyCount, 'MockSub should not be notified after its subscription was finalized post UnadviseAll.'); end; procedure TTestMycLatch.TestLatchSet_NewSubscriberToSetLatch_NotifiedImmediatelyButNotPersistedForLatchNotify; var - latch: IMycLatch; - mockSubInitial, mockSubNew: TMockSubscriber; - subscriptionInitial, subscriptionNew: TState.TSubscription; + latch: IMycLatch; + mockSubInitial, mockSubNew: TMockSubscriber; + subscriptionInitial, subscriptionNew: TState.TSubscription; begin - latch := TLatch.Construct(1); - mockSubInitial := TMockSubscriber.Create; - subscriptionInitial := latch.State.Subscribe(mockSubInitial); + latch := TLatch.Construct(1); + mockSubInitial := TMockSubscriber.Create; + subscriptionInitial := latch.State.Subscribe(mockSubInitial); - // Set the latch; mockSubInitial is notified, UnadviseAll is called. - latch.Notify; - Assert.AreEqual(1, mockSubInitial.NotifyCount, 'Initial subscriber notified.'); + // Set the latch; mockSubInitial is notified, UnadviseAll is called. + latch.Notify; + Assert.AreEqual(1, mockSubInitial.NotifyCount, 'Initial subscriber notified.'); - // Subscribe a new subscriber to the already set latch - mockSubNew := TMockSubscriber.Create; - subscriptionNew := latch.State.Subscribe(mockSubNew); + // Subscribe a new subscriber to the already set latch + mockSubNew := TMockSubscriber.Create; + subscriptionNew := latch.State.Subscribe(mockSubNew); - // New subscriber should be notified immediately upon subscription to an already set latch - Assert.AreEqual(1, mockSubNew.NotifyCount, 'New subscriber should be notified immediately upon subscription.'); - // The direct check of subscriptionNew.FTag was removed as FTag is private. - // The correct behavior (no persistent subscription) is verified by the next step. + // New subscriber should be notified immediately upon subscription to an already set latch + Assert.AreEqual(1, mockSubNew.NotifyCount, 'New subscriber should be notified immediately upon subscription.'); + // The direct check of subscriptionNew.FTag was removed as FTag is private. + // The correct behavior (no persistent subscription) is verified by the next step. - // Call Notify on the latch again. - latch.Notify; + // Call Notify on the latch again. + latch.Notify; - // mockSubInitial should not be notified again (was unadvised). - Assert.AreEqual(1, mockSubInitial.NotifyCount, 'Initial subscriber (unadvised) not notified again.'); - // mockSubNew should also not be notified again, as it was only notified immediately - // and not persistently added to FSubscribers for subsequent Latch.Notify calls. - Assert.AreEqual(1, mockSubNew.NotifyCount, 'New subscriber (notified once on subscribe) not notified by subsequent Latch.Notify calls.'); + // mockSubInitial should not be notified again (was unadvised). + Assert.AreEqual(1, mockSubInitial.NotifyCount, 'Initial subscriber (unadvised) not notified again.'); + // mockSubNew should also not be notified again, as it was only notified immediately + // and not persistently added to FSubscribers for subsequent Latch.Notify calls. + Assert.AreEqual( + 1, + mockSubNew.NotifyCount, + 'New subscriber (notified once on subscribe) not notified by subsequent Latch.Notify calls.' + ); end; initialization - TDUnitX.RegisterTestFixture(TTestMycLatch); + TDUnitX.RegisterTestFixture(TTestMycLatch); end. diff --git a/Test/TestTasks.pas b/Test/TestTasks.pas index 6612f5e..8366bda 100644 --- a/Test/TestTasks.pas +++ b/Test/TestTasks.pas @@ -8,7 +8,8 @@ uses System.Classes, System.SyncObjs, Myc.Core.Tasks, - Myc.Signals, Myc.Core.Signals, + Myc.Signals, + Myc.Core.Signals, Myc.Core.Atomic; type @@ -73,10 +74,7 @@ var procWrapper: TProc; begin executed := False; - procWrapper := procedure - begin - executed := True; - end; + procWrapper := procedure begin executed := True; end; threadState := FFactory.CreateThread(procWrapper); // CreateThread in TaskFactory now uses TMycLatch.CreateLatch Assert.IsNotNull(threadState, 'CreateThread should return a valid state object'); @@ -93,12 +91,14 @@ begin jobExecuted := False; jobCompletedLatch := TLatch.Construct(1); // Changed from Signals.CreateLatch - FFactory.Run( - procedure - begin - jobExecuted := True; - jobCompletedLatch.Notify; - end).Notify; + FFactory + .Run( + procedure + begin + jobExecuted := True; + jobCompletedLatch.Notify; + end) + .Notify; FFactory.WaitFor(jobCompletedLatch.State); Assert.IsTrue(jobExecuted, 'Immediate job should have executed'); @@ -113,12 +113,14 @@ begin jobExecuted := False; jobCompletedLatch := TLatch.Construct(1); // Changed from Signals.CreateLatch - subscriber := FFactory.Run( - procedure - begin - jobExecuted := True; - jobCompletedLatch.Notify; - end); + subscriber := + FFactory.Run( + procedure + begin + jobExecuted := True; + jobCompletedLatch.Notify; + end + ); Assert.IsNotNull(subscriber, 'Run should return a subscriber for delayed job'); // Use TMycLatch.Null for comparison @@ -130,7 +132,6 @@ begin Assert.IsTrue(jobExecuted, 'Delayed job should execute after all notifications'); end; - procedure TMycTaskFactoryTests.TestWaitForAlreadySetState; var alreadySetLatch: IMycLatch; @@ -161,12 +162,13 @@ begin Assert.IsFalse(FFactory.InWorkerThread, 'Test method itself should not be in a factory worker thread'); FFactory.EnqueueJob( - procedure - begin - inMainThreadInJob := FFactory.InMainThread; - inWorkerThreadInJob := FFactory.InWorkerThread; - jobDoneLatch.Notify; - end); + procedure + begin + inMainThreadInJob := FFactory.InMainThread; + inWorkerThreadInJob := FFactory.InWorkerThread; + jobDoneLatch.Notify; + end + ); FFactory.WaitFor(jobDoneLatch.State); @@ -181,22 +183,20 @@ begin jobDoneLatch := TLatch.Construct(1); FFactory.EnqueueJob( - procedure - begin - try - raise TMycTaskFactory.ETaskException.Create('Test Exception From Job'); - finally - jobDoneLatch.Notify; - end; - end); + procedure + begin + try + raise TMycTaskFactory.ETaskException.Create('Test Exception From Job'); + finally + jobDoneLatch.Notify; + end; + end + ); Assert.WillRaise( - procedure - begin - FFactory.WaitFor(jobDoneLatch.State); - end, - TMycTaskFactory.ETaskException, - 'WaitFor should re-raise the exception from the job' + procedure begin FFactory.WaitFor(jobDoneLatch.State); end, + TMycTaskFactory.ETaskException, + 'WaitFor should re-raise the exception from the job' ); var noExceptionRaised: Boolean := True; @@ -213,12 +213,9 @@ begin FFactory.Teardown; Assert.WillRaise( - procedure - begin - FFactory.EnqueueJob(procedure begin end); - end, - TMycTaskFactory.ETaskException, - 'Running a job on a torn-down factory should raise ETaskException' + procedure begin FFactory.EnqueueJob(procedure begin end); end, + TMycTaskFactory.ETaskException, + 'Running a job on a torn-down factory should raise ETaskException' ); end; @@ -233,18 +230,19 @@ begin dummyStateToWaitFor := TLatch.Construct(1).State; FFactory.EnqueueJob( - procedure - begin - try - FFactory.WaitFor(dummyStateToWaitFor); - except - on E: TMycTaskFactory.ETaskException do - begin - exceptionCaughtInJob := True; - end; - end; - jobDoneLatch.Notify; - end); + procedure + begin + try + FFactory.WaitFor(dummyStateToWaitFor); + except + on E: TMycTaskFactory.ETaskException do + begin + exceptionCaughtInJob := True; + end; + end; + jobDoneLatch.Notify; + end + ); FFactory.WaitFor(jobDoneLatch.State); Assert.IsTrue(exceptionCaughtInJob, 'WaitFor called within a worker thread job should raise ETaskException');