Perf: Restore core optimizations and stabilize VM execution

This commit restores and enhances several high-performance features that
were
previously lost, while fixing critical bugs in scope management.

Performance Optimizations:
- Zero-Copy TCO: Refactored TailCallRequest to use (Rc, usize), moving
  arguments
  directly on the VM stack via drain/resize instead of heap-allocating
  Vecs.
- Slice-based Calls: Native functions and field accessors now operate
  directly
  on stack slices, significantly reducing memory churn.
- SoA Push Fast-Path: Restored specialized 'push' intrinsic for
  RecordSeries.
  Matches layouts via Arc::ptr_eq to distribute values directly into
  columns
  without keyword lookups.

Architectural Improvements:
- Static Stack Frames (max_slots): The Binder now calculates the maximum

  required slots per lambda. The VM pre-resizes the stack frame,
  preventing
  collisions between local variables and temporary call arguments.
- Macro Hygiene: Fixed a bug where macro-internal variables could
  overwrite
  outer call arguments due to stack overlap.
- Trait Refactoring: Unified series operations via a polymorphic
  'push_value'
  on the Series trait, with a generic implementation for
  ScalarSeries<T>.

Code Quality:
- Resolved all 'cargo clippy' warnings (collapsible ifs, redundant
  borrows, etc).
- Restored 100% test pass rate (64/64 tests).
- Verified stability of all examples and benchmarks.
This commit is contained in:
Michael Schimmel
2026-03-10 13:06:56 +01:00
parent beb693a068
commit 260669cba1
16 changed files with 237 additions and 260 deletions
+39
View File
@@ -109,6 +109,45 @@ pub fn lookup(name: &str, args: &[StaticType]) -> Option<(Value, StaticType)> {
)),
// --- Constant Unary for -1 (decrement optimization) ---
// --- Series & Streams ---
("push", [StaticType::Any, StaticType::Any]) => Some((
Value::make_function(Purity::Impure, |args| {
if args.len() < 2 { return Value::Void; }
let series_val = &args[0];
let item = &args[1];
if let Value::Object(obj) = series_val {
if let Some(rs) = obj.as_any().downcast_ref::<crate::ast::rtl::series::RecordSeries>() {
// SoA Fast-Path: Push record values directly if they match the layout.
if let Value::Record(layout, values) = item
&& std::sync::Arc::ptr_eq(rs.layout(), layout)
{
rs.push_record_values(values);
return Value::Void;
}
}
// Fallback to dynamic push (works for ScalarSeries and RecordSeries)
if let Some(series) = obj.as_series() {
series.push_value(item.clone());
}
}
Value::Void
}),
StaticType::Void,
)),
("len", [StaticType::Any]) => Some((
Value::make_function(Purity::Pure, |args| {
if let Some(Value::Object(obj)) = args.first()
&& let Some(series) = obj.as_series()
{
return Value::Int(series.len() as i64);
}
Value::Int(0)
}),
StaticType::Int,
)),
// Special case: tak uses (- x 1). The specializer sees Call("-", [Int, Int]).
_ => None,
}