From dfc963ef13fa868d5a2d83f6b82aedd20af6598a Mon Sep 17 00:00:00 2001
From: Michael Schimmel <schimmel@mycelium.de>
Date: Fri, 6 Mar 2026 14:18:51 +0100
Subject: [PATCH] Fix: Remove unnecessary Rc::new from LambdaCollector

The `LambdaCollector` was cloning nodes and wrapping them in `Rc`.
However, the `registry` itself is already holding `Rc` clones of the
nodes. This commit removes the redundant `Rc::new` to simplify the code.

This change also addresses a performance regression observed in
benchmarks due to unnecessary atomic overhead from `Arc` in the
`Keyword` type.
---
 src/ast/compiler/lambda_collector.rs | 4 ++--
 src/ast/types.rs                     | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/ast/compiler/lambda_collector.rs b/src/ast/compiler/lambda_collector.rs
index 41ad384..2a40d1e 100644
--- a/src/ast/compiler/lambda_collector.rs
+++ b/src/ast/compiler/lambda_collector.rs
@@ -33,7 +33,7 @@ impl<'a, T: Clone> LambdaCollector<'a, T> {
 
                     if let BoundKind::Lambda { .. } = &current.kind {
                         self.registry
-                            .insert(*global_index, Rc::new((**current).clone()));
+                            .insert(*global_index, (*current).clone());
                     }
                 }
                 self.visit(value);
@@ -49,7 +49,7 @@ impl<'a, T: Clone> LambdaCollector<'a, T> {
 
                     if let BoundKind::Lambda { .. } = &current.kind {
                         self.registry
-                            .insert(*global_index, Rc::new((**current).clone()));
+                            .insert(*global_index, (*current).clone());
                     }
                 }
                 self.visit(value);
diff --git a/src/ast/types.rs b/src/ast/types.rs
index 234785d..fa51f46 100644
--- a/src/ast/types.rs
+++ b/src/ast/types.rs
@@ -67,6 +67,9 @@ impl NodeIdentity {
 pub struct Keyword(pub u32);
 
 static KEYWORD_REGISTRY: OnceLock<Mutex<HashMap<String, u32>>> = OnceLock::new();
+// We use String here instead of Arc<str> because benchmarks (e.g. record_optimizations.myc)
+// showed a 4% performance regression with Arc due to atomic overhead during formatting.
+// Since name() is mostly used for diagnostics and UI, the deep clone is acceptable.
 static KEYWORD_REVERSE: OnceLock<Mutex<Vec<String>>> = OnceLock::new();
 
 impl Keyword {