Brummel
d83b10f939
The retrieval-mode enum used opaque single letters `Mode { C, A }`;
neither the identifier nor the operator-facing `--mode a` token
conveyed what the mode does. Rename to self-describing names that map
directly onto the glossary definitions:
Mode::C -> Mode::Lexical (BM25 + tag filter, offline, no IONOS)
Mode::A -> Mode::Hybrid (lexical u semantic -> RRF -> rerank)
Decisions taken (the issue's open questions, resolved):
- CLI canonical tokens are now `lexical` / `hybrid`; the default is
`lexical`. The legacy `c` / `a` tokens stay accepted as
case-insensitive input aliases (zero cost; protects hand-typed
invocations). A unit test pins the alias contract.
- The diagnostics `mode` string (Debug-derived) now emits
"Lexical"/"Hybrid". Verified safe: no downstream consumer parses it.
doctate is the future integrator and embeds the library (the `Mode`
enum), not the JSON string (design spec §103).
- The reserved, out-of-scope generative tier (spec's "Mode B") keeps
conceptual room: a future `Mode::Generative` does not collide with
the retrieval-strategy names Lexical/Hybrid.
Surface: enum + FromStr, CLI defaults and `eval --mode both`
expansion, the private `collect_mode_c`/`collect_mode_a` methods (now
`collect_lexical`/`collect_hybrid`) and their comments, the two
pipeline mode test files (renamed), the eval CLI test, the glossary
(old letter forms demoted to Avoid lists), and the spec CLI synopsis.
closes #2
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
30 lines
1.0 KiB
Rust
30 lines
1.0 KiB
Rust
use alpha_id::model::{Filter, Tags, Mode};
|
|
|
|
#[test]
|
|
fn filter_billable_only_rejects_non_primary() {
|
|
let tags = Tags { billable: false, valid: true, chapter: "I".into(), exotic: false };
|
|
let f = Filter { billable_only: true, valid_only: false, chapters: None, exclude_exotic: false };
|
|
assert!(!f.accepts(&tags));
|
|
}
|
|
|
|
#[test]
|
|
fn filter_default_accepts_everything() {
|
|
let tags = Tags { billable: false, valid: false, chapter: "II".into(), exotic: true };
|
|
assert!(Filter::default().accepts(&tags));
|
|
}
|
|
|
|
#[test]
|
|
fn mode_parses_from_str() {
|
|
assert_eq!("lexical".parse::<Mode>().unwrap(), Mode::Lexical);
|
|
assert_eq!("hybrid".parse::<Mode>().unwrap(), Mode::Hybrid);
|
|
}
|
|
|
|
#[test]
|
|
fn mode_letter_aliases_still_parse_to_new_variants() {
|
|
// The legacy `c`/`a` CLI tokens remain accepted aliases (case-insensitive)
|
|
// for the renamed canonical `lexical`/`hybrid` modes.
|
|
assert_eq!("c".parse::<Mode>().unwrap(), Mode::Lexical);
|
|
assert_eq!("a".parse::<Mode>().unwrap(), Mode::Hybrid);
|
|
assert_eq!("A".parse::<Mode>().unwrap(), Mode::Hybrid);
|
|
}
|