Brummel
76b21c00eb
Deletes `ParamMode::Implicit`. `ParamMode` is now `{Own, Borrow}`:
every fn-type slot on every signature carries an explicit `own` or
`borrow`, no defaulted position survives anywhere (model 0008 §2,
spec 0062). The parser rejects a bare fn-type slot; `borrow-return`
and `borrow-over-value` reject at the signature; the corpus is
migrated to minimal-ownership modes (consumed ⇒ own, read-only-heap
⇒ borrow, value ⇒ trivial-own). The documented `Implicit`-ret-mode
leak is fixed: an owned heap return now drops exactly once (live=0,
acceptance criterion 5).
This was the easy half. Removing the default ACTIVATED a family of
drop paths that `Implicit` had silently skipped — the pre-cutover
language was leaking (and in places mis-dropping) here rather than
crashing, because an Implicit scrutinee turned the drop off. Making
the modes explicit (Own) turned those paths on and exposed two
latent-bug clusters, all fixed RED-first as part of this cutover:
Drop-soundness family (four legs):
A. lit-sub-pattern double-free — the desugar re-matched the same
owned scrutinee in the lit fall-through; fixed by grouping
consecutive same-ctor arms into one match (bind fields once),
in ailang-core desugar.
B. Cons-husk leak on non-tail arm bodies — the lit-sub-pattern
desugar rebound the owned scrutinee via `Let $mp = xs`, which
bumped consume_count and suppressed the existing fn-return
partial_drop. Fixed by not rebinding a bare-Var scrutinee
(one husk-freeing mechanism, not two).
C. polymorphic `drop_<T>` rc_dec'd monomorphised value fields —
the per-ADT drop fn was emitted once from the polymorphic
TypeDef, defaulting type-var fields to ptr and rc_dec'ing
inline Ints (segfault). Fixed with per-monomorph drop
functions (new ailang-codegen::dropmono): the drop set is
collected from the lowered MIR, value-type fields are skipped,
heap fields still freed once; monomorphic-concrete ADTs keep
their byte-identical un-suffixed drop symbol.
D. static Str literal passed to an `(own Str)` param — the
literal lowers to a header-less rodata constant; the callee's
now-active rc_dec read its length field as a refcount and
freed a static address (segfault). Fixed with the missing
fourth StrRep::Static→Heap promotion in lower_to_mir's App arm,
gated on Own mode (borrow args stay static, no regression).
over-strict-mode lint over-fired: it suggested `(borrow V)` for
value-typed params (which `borrow-over-value` rejects — own is the
only legal mode there) and fired on `(intrinsic)` bodies (whose
consumption the linearity walk cannot observe). Tightened to skip
both; contract 0008 updated to the narrowed firing scope.
Irreversible step — canonical-form hash reset (model 0008 §6,
acceptance criterion 6). Every signature now carries explicit modes,
so the hashable canonical JSON changed for every module. RATIFY:
the corpus-wide hash-pin reset (hash_pin, prelude_module_hash_pin,
mono_hash_stability, eq_ord_e2e, embed_export_hash_stable, the
ct4/iter*/loop_recur schema-extension pins) and the list ir_snapshot
golden were regenerated once, deliberately, as the intended one-time
consequence of removing the mode elision from the canonical form —
not a regression. Each regenerated hash verified deterministic across
two runs.
Also fixes a pre-existing latent failure surfaced by the verification
gate, unrelated to this cutover: the `every_contract_names_a_resolvable_
ratifying_test` resolver (design_index_pin) could not resolve the
" + " dual-link ratifying-test form (`uniqueness.rs + linearity.rs`)
that the #57 audit-close (dfdc65f) introduced — it shipped red on that
commit. Resolver taught the dual-link form, mirroring its sibling.
Verification: cargo test --workspace = 731 passed, 0 failed (twice,
stable); e2e 102 passed, no binary exits non-zero (corpus crash-free);
grep-clean for Implicit/fn_implicit/mode_eq across crates; every drop
fix confirmed via emitted IR + AILANG_RC_STATS balance on the head==K,
head!=K, and Nil paths. Three BLOCKEDs en route (the unsound first
husk-dec attempt, the over-strict derivation premise, the leg-B fix
direction) were each treated as a real design/spec gap and rediagnosed,
not patched over.
Supersedes #54 (return-position-only leak patch). Precondition #57
(linearity hardening) was already met. Spec docs/specs/0062, plan
docs/plans/0121.
closes #55
88 lines
3.0 KiB
Plaintext
88 lines
3.0 KiB
Plaintext
; Bench fixture: HOF + polymorphic ADT pipeline.
|
|
;
|
|
; Builds a polymorphic List<Int> of length n, then folds it with a
|
|
; higher-order function `inc` to compute the sum of incremented
|
|
; elements. Distinct from bench_list_sum:
|
|
; 1. Uses `(data List (vars a) ...)` — polymorphic ADT, exercises
|
|
; the 13b/14a polymorphism-at-runtime path. The Cons cell
|
|
; layout is the same width as bench_list_sum's IntList ICons,
|
|
; but the type-arg substitution is the additional code path.
|
|
; 2. The traversal is via `fold_with_fn` — an HOF taking
|
|
; `(fn-type (params (own a)) (ret (own (con Int))))` as its first param.
|
|
; Each step calls `(app f h)` — an indirect call through the
|
|
; fn-arg. This is the only fixture that exercises tight-loop
|
|
; indirect dispatch.
|
|
;
|
|
; Build phase is alloc-heavy (n Cons cells); fold phase is
|
|
; dispatch-heavy (n indirect calls). Per-iteration cost should be
|
|
; visibly higher than bench_list_sum's direct sum.
|
|
;
|
|
; Result for size n (using inc(x) = x+1):
|
|
; sum (inc 0) + (inc 1) + ... + (inc (n-1)) = sum 1..n = n*(n+1)/2
|
|
;
|
|
; Sizes:
|
|
; 100_000 -> 5_000_050_000
|
|
; 1_000_000 -> 500_000_500_000
|
|
; 3_000_000 -> 4_500_001_500_000
|
|
|
|
(module bench_hof_pipeline
|
|
|
|
(data List (vars a)
|
|
(doc "Polymorphic singly-linked list. Same shape as list_map_poly's List, replicated here so the bench fixture is self-contained.")
|
|
(ctor Nil)
|
|
(ctor Cons a (con List a)))
|
|
|
|
(fn build_n
|
|
(doc "Build [0, 1, ..., n-1] :: List Int. Tail-recursive accumulator form.")
|
|
(type
|
|
(fn-type
|
|
(params (own (con Int)) (own (con List (con Int))))
|
|
(ret (own (con List (con Int))))))
|
|
(params n acc)
|
|
(body
|
|
(if (app eq n 0)
|
|
acc
|
|
(tail-app build_n
|
|
(app - n 1)
|
|
(term-ctor List Cons (app - n 1) acc)))))
|
|
|
|
(fn inc
|
|
(doc "Add 1 to an Int. Used as the HOF argument to fold_with_fn.")
|
|
(type (fn-type (params (own (con Int))) (ret (own (con Int)))))
|
|
(params x)
|
|
(body (app + x 1)))
|
|
|
|
(fn fold_with_fn
|
|
(doc "Polymorphic foldl-with-mapping. Apply f:(a)->Int to every element of xs, sum into acc. Tail-recursive on (xs, acc); the f arg is forwarded unchanged.")
|
|
(type
|
|
(forall (vars a)
|
|
(fn-type
|
|
(params (borrow (fn-type (params (own a)) (ret (own (con Int)))))
|
|
(own (con List a))
|
|
(own (con Int)))
|
|
(ret (own (con Int))))))
|
|
(params f xs acc)
|
|
(body
|
|
(match xs
|
|
(case (pat-ctor Nil) acc)
|
|
(case (pat-ctor Cons h t)
|
|
(tail-app fold_with_fn f t (app + acc (app f h)))))))
|
|
|
|
(fn run_one
|
|
(doc "Build [0..n-1], fold with inc, print sum of (inc x).")
|
|
(type (fn-type (params (own (con Int))) (ret (own (con Unit))) (effects IO)))
|
|
(params n)
|
|
(body
|
|
(app print
|
|
(app fold_with_fn inc
|
|
(app build_n n (term-ctor List Nil))
|
|
0))))
|
|
|
|
(fn main
|
|
(type (fn-type (params) (ret (own (con Unit))) (effects IO)))
|
|
(params)
|
|
(body
|
|
(seq (app run_one 100000)
|
|
(seq (app run_one 1000000)
|
|
(app run_one 3000000))))))
|