Brummel
76b21c00eb
Deletes `ParamMode::Implicit`. `ParamMode` is now `{Own, Borrow}`:
every fn-type slot on every signature carries an explicit `own` or
`borrow`, no defaulted position survives anywhere (model 0008 §2,
spec 0062). The parser rejects a bare fn-type slot; `borrow-return`
and `borrow-over-value` reject at the signature; the corpus is
migrated to minimal-ownership modes (consumed ⇒ own, read-only-heap
⇒ borrow, value ⇒ trivial-own). The documented `Implicit`-ret-mode
leak is fixed: an owned heap return now drops exactly once (live=0,
acceptance criterion 5).
This was the easy half. Removing the default ACTIVATED a family of
drop paths that `Implicit` had silently skipped — the pre-cutover
language was leaking (and in places mis-dropping) here rather than
crashing, because an Implicit scrutinee turned the drop off. Making
the modes explicit (Own) turned those paths on and exposed two
latent-bug clusters, all fixed RED-first as part of this cutover:
Drop-soundness family (four legs):
A. lit-sub-pattern double-free — the desugar re-matched the same
owned scrutinee in the lit fall-through; fixed by grouping
consecutive same-ctor arms into one match (bind fields once),
in ailang-core desugar.
B. Cons-husk leak on non-tail arm bodies — the lit-sub-pattern
desugar rebound the owned scrutinee via `Let $mp = xs`, which
bumped consume_count and suppressed the existing fn-return
partial_drop. Fixed by not rebinding a bare-Var scrutinee
(one husk-freeing mechanism, not two).
C. polymorphic `drop_<T>` rc_dec'd monomorphised value fields —
the per-ADT drop fn was emitted once from the polymorphic
TypeDef, defaulting type-var fields to ptr and rc_dec'ing
inline Ints (segfault). Fixed with per-monomorph drop
functions (new ailang-codegen::dropmono): the drop set is
collected from the lowered MIR, value-type fields are skipped,
heap fields still freed once; monomorphic-concrete ADTs keep
their byte-identical un-suffixed drop symbol.
D. static Str literal passed to an `(own Str)` param — the
literal lowers to a header-less rodata constant; the callee's
now-active rc_dec read its length field as a refcount and
freed a static address (segfault). Fixed with the missing
fourth StrRep::Static→Heap promotion in lower_to_mir's App arm,
gated on Own mode (borrow args stay static, no regression).
over-strict-mode lint over-fired: it suggested `(borrow V)` for
value-typed params (which `borrow-over-value` rejects — own is the
only legal mode there) and fired on `(intrinsic)` bodies (whose
consumption the linearity walk cannot observe). Tightened to skip
both; contract 0008 updated to the narrowed firing scope.
Irreversible step — canonical-form hash reset (model 0008 §6,
acceptance criterion 6). Every signature now carries explicit modes,
so the hashable canonical JSON changed for every module. RATIFY:
the corpus-wide hash-pin reset (hash_pin, prelude_module_hash_pin,
mono_hash_stability, eq_ord_e2e, embed_export_hash_stable, the
ct4/iter*/loop_recur schema-extension pins) and the list ir_snapshot
golden were regenerated once, deliberately, as the intended one-time
consequence of removing the mode elision from the canonical form —
not a regression. Each regenerated hash verified deterministic across
two runs.
Also fixes a pre-existing latent failure surfaced by the verification
gate, unrelated to this cutover: the `every_contract_names_a_resolvable_
ratifying_test` resolver (design_index_pin) could not resolve the
" + " dual-link ratifying-test form (`uniqueness.rs + linearity.rs`)
that the #57 audit-close (dfdc65f) introduced — it shipped red on that
commit. Resolver taught the dual-link form, mirroring its sibling.
Verification: cargo test --workspace = 731 passed, 0 failed (twice,
stable); e2e 102 passed, no binary exits non-zero (corpus crash-free);
grep-clean for Implicit/fn_implicit/mode_eq across crates; every drop
fix confirmed via emitted IR + AILANG_RC_STATS balance on the head==K,
head!=K, and Nil paths. Three BLOCKEDs en route (the unsound first
husk-dec attempt, the over-strict derivation premise, the leg-B fix
direction) were each treated as a real design/spec gap and rediagnosed,
not patched over.
Supersedes #54 (return-position-only leak patch). Precondition #57
(linearity hardening) was already met. Spec docs/specs/0062, plan
docs/plans/0121.
closes #55
95 lines
3.0 KiB
Plaintext
95 lines
3.0 KiB
Plaintext
; Bench fixture: explicit-mode pair of bench_list_sum.
|
|
;
|
|
; Same algorithm and same sizes as bench_list_sum.ail (build a list of
|
|
; 0..N-1, sum it, print) but with full `(borrow)` / `(own)` annotations
|
|
; on every fn-param signature in the hot path. Under --alloc=rc the
|
|
; codegen now emits `inc`/`dec` instructions: each cell allocated by
|
|
; `cons_n_acc` is dec'd as `sum_list_acc` walks the chain.
|
|
;
|
|
; The IntList is `(drop-iterative)` so the param drop on the LCons arm
|
|
; stays O(1) stack regardless of length — without this, dec-ing a
|
|
; 3M-cell chain at scope close would recursive-overflow.
|
|
;
|
|
; This is the "RC-fair" arm of the cross-language bench (21'f);
|
|
; pairs with bench/reference/list_sum_explicit_free.c which adds
|
|
; matching free() calls. Together they answer "what does RC's full
|
|
; alloc+dec cost look like vs C's full malloc+free cost?".
|
|
;
|
|
; Sizes match bench_list_sum exactly:
|
|
; 100_000 * 24 B = 2.4 MB
|
|
; 1_000_000 * 24 B = 24 MB
|
|
; 3_000_000 * 24 B = 72 MB
|
|
;
|
|
; Expected stdout (one int per line):
|
|
; 100_000 -> 4999950000
|
|
; 1_000_000 -> 499999500000
|
|
; 3_000_000 -> 4499998500000
|
|
|
|
(module bench_list_sum_explicit
|
|
|
|
(data IntList
|
|
(doc "Singly-linked Int list. drop-iterative so Own-param drops are O(1) stack.")
|
|
(ctor INil)
|
|
(ctor ICons (con Int) (con IntList))
|
|
(drop-iterative))
|
|
|
|
(fn cons_n_acc
|
|
(doc "Tail-recursive: prepend (n-1, n-2, ..., 0) onto acc. Returns owned chain.")
|
|
(type
|
|
(fn-type
|
|
(params (own (con Int)) (own (con IntList)))
|
|
(ret (own (con IntList)))))
|
|
(params n acc)
|
|
(body
|
|
(if (app eq n 0)
|
|
acc
|
|
(tail-app cons_n_acc
|
|
(app - n 1)
|
|
(term-ctor IntList ICons (app - n 1) acc)))))
|
|
|
|
(fn cons_n
|
|
(doc "Build [0..n-1] :: IntList. Returns owned chain; caller owns and consumes.")
|
|
(type
|
|
(fn-type
|
|
(params (own (con Int)))
|
|
(ret (own (con IntList)))))
|
|
(params n)
|
|
(body (app cons_n_acc n (term-ctor IntList INil))))
|
|
|
|
(fn sum_acc
|
|
(doc "Tail-recursive sum. Owns xs; consumes via LCons-arm move-into-tail-call.")
|
|
(type
|
|
(fn-type
|
|
(params (own (con IntList)) (own (con Int)))
|
|
(ret (own (con Int)))))
|
|
(params xs acc)
|
|
(body
|
|
(match xs
|
|
(case (pat-ctor INil) acc)
|
|
(case (pat-ctor ICons h t)
|
|
(tail-app sum_acc t (app + acc h))))))
|
|
|
|
(fn sum_list
|
|
(doc "Sum every element. Owns xs, hands it to sum_acc which consumes it.")
|
|
(type
|
|
(fn-type
|
|
(params (own (con IntList)))
|
|
(ret (own (con Int)))))
|
|
(params xs)
|
|
(body (app sum_acc xs 0)))
|
|
|
|
(fn run_one
|
|
(doc "Build, sum, print. The owned list flows from cons_n into sum_list and is fully consumed.")
|
|
(type (fn-type (params (own (con Int))) (ret (own (con Unit))) (effects IO)))
|
|
(params n)
|
|
(body
|
|
(app print (app sum_list (app cons_n n)))))
|
|
|
|
(fn main
|
|
(type (fn-type (params) (ret (own (con Unit))) (effects IO)))
|
|
(params)
|
|
(body
|
|
(seq (app run_one 100000)
|
|
(seq (app run_one 1000000)
|
|
(app run_one 3000000))))))
|