audit: cycle 0044 — drift-clean (walk-forward family)
Architect drift review over 61a8436..HEAD (the 0044 walk-forward cycle: speca4712eb, plan7d52eff, feat4764656). Cycle is sound, no drift: - C1 — walk_forward reuses the shared sweep::run_indexed core; output is roll order (index-sorted), not completion order; walk_forward_is_deterministic_across_thread_counts pins 1-vs-8-thread equality. Parallelism is across windows, never within. - C2 — no look-ahead is structural: WindowRoller::next emits is.1 = oos_start-1, so oos.0 == is.1+1 by construction; roller_every_split_has_no_lookahead asserts it with zero ticks materialized (a pure bounds invariant). - C9 — aura-engine has no aura-registry dependency (grep clean; Cargo.toml lists only aura-core/aura-std); the in-sample optimize is closure-supplied, the CLI bridges engine+registry. The orchestration primitive bakes in no search policy. - C12 axis 3 realized as a sibling of sweep/mc; the atomic unit is unchanged. - #71 firewall — the walk_forward API carries WindowBounds + a per-window closure, never a materialized stream Vec; per-window data is a bounds-keyed closure concern. - R2 honored — WalkForwardResult stores only windows + stitched_oos_equity; param_stability is a pure on-demand reduction (sweep-precedent, non-redundant). The #69 reconciliation-comment provenance (R2, 2026-06-15) matches the spec and the feat commit body. MetricStats::from_values extraction is behaviour-preserving (the 7 mc tests stay green). The lib.rs module header was updated in the feat commit to list walk-forward as delivered, so no doc-lag remains for the audit. One non-load-bearing observation (not fixed — demo-only, crosses no contract): the CLI walkforward_window_source regenerates the full synthetic seed-stream per window-source construction. Confined to the built-in demo; bounds-keyed, no #71 line. Regression gate (test suite — no dedicated regression scripts in project facts): cargo test --workspace green (aura-engine 152 incl. walkforward 9 + mc 9, aura-cli 14, all crates 0 red); clippy --workspace --all-targets -D warnings exit 0; cargo doc --workspace --no-deps clean. closes #69
This commit is contained in:
